juanpablo-santos commented on a change in pull request #15: URL: https://github.com/apache/jspwiki/pull/15#discussion_r546411406
########## File path: .github/dependabot.yml ########## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +version: 2 +updates: Review comment: Hi, according to [dependabot documentation](https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuration-options-for-dependency-updates#specifying-dependencies-and-versions-to-ignore) version's ranges can be excluded, so the file should have at least the following exclusions * `javax.servlet:javax.servlet-api` should exclude the range `[3.2.0,)` * `javax.servlet.jsp:javax.servlet.jsp-api` should exclude the range `[2.4.0,)` * `org.apache.tomcat:*` should exclude the range `[10.0.0,)` * we use only a couple of `embed` dependencies on the portable module, but using a wildcard seems safer on the long run * `org.slf4j:*` should exclude the range `[1.8.0-beta1,2.0.0)` * the range comes from a bit of a search on central + checking [version ordering](https://medium.com/@MichaKutz/legit-but-useless-maven-version-ranges-explained-d4ba66ac654) (cfr. with last section of the article) * last, according to the documentation, the `Dockerfile` could/would also be checked for newer versions. In this case, I think it would be safe to just ignore it. best regards, juan pablo ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
