takalat commented on a change in pull request #44:
URL: https://github.com/apache/jspwiki/pull/44#discussion_r585901825
##########
File path:
jspwiki-main/src/main/java/org/apache/wiki/preferences/Preferences.java
##########
@@ -125,19 +133,21 @@ public static void reloadPreferences( final PageContext
pageContext ) {
* @param request
* @param prefs The default hashmap of preferences
*/
- private static void parseJSONPreferences( final HttpServletRequest
request, final Preferences prefs ) {
- final String prefVal = TextUtil.urlDecodeUTF8(
HttpUtil.retrieveCookieValue( request, "JSPWikiUserPrefs" ) );
- if( prefVal != null ) {
+ private static void parseJSONPreferences( final Preferences prefs,
final String prefVal ) {
Review comment:
I assume this meant only changing signature to package scope. Changed
method modifier to default modifier in the latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
