Re: 1.7.1 breaking change related to ADLS support

Thanks Marc. I gonna review the new PR. Regards JB Le ven. 20 déc. 2024 à 00:48, Marc Cenac a écrit : > Yesterday we reverted the PR in main and cherry picked into the 1.7.x > branch https://github.com/apache/iceberg/pull/11817 > > Today I have opened https://github.com/apache/iceberg/pull/118

Re: 1.7.1 breaking change related to ADLS support

Yesterday we reverted the PR in main and cherry picked into the 1.7.x branch https://github.com/apache/iceberg/pull/11817 Today I have opened https://github.com/apache/iceberg/pull/11830 which is the previous code with some new tests and a fix for the breaking change On Wed, Dec 18, 2024 at 1:59 

Re: 1.7.1 breaking change related to ADLS support

Apologies for introducing the breaking change. I just opened https://github.com/apache/iceberg/pull/11812 to revert. Let me know if there is something else I can do to help fix On Tue, Dec 17, 2024 at 8:35 AM Jean-Baptiste Onofré wrote: > Hi Cheng, > > Thanks for the update. The issue appeared

Re: 1.7.1 breaking change related to ADLS support

Hi Cheng, Thanks for the update. The issue appeared in the test, but I guess it can also impact runtime use. Let me take a look at the update PR. Regards JB On Tue, Dec 17, 2024 at 3:06 PM Cheng Pan wrote: > > Spark 3.5.4 (under RC3 voting) introduces a breaking change that requires > Iceberg

Re: 1.7.1 breaking change related to ADLS support

Spark 3.5.4 (under RC3 voting) introduces a breaking change that requires Iceberg to be patched[1]. Please include Spark 3.5.4 support in the patch release. Since some users are sticky to Java 8, it would be great if Iceberg also releases a new patch version of 1.6.x, otherwise they won’t be ab

Re: 1.7.1 breaking change related to ADLS support

That works for me. In the meantime, I will draft a proposal (in terms of content) for 1.8.0. I volunteer to drive 1.7.2 release if needed. Regards JB On Tue, Dec 17, 2024 at 9:58 AM Fokko Driesprong wrote: > > Thanks for raising this Alex, > > I suggest doing a 1.7.2 patch release since we don'

Re: 1.7.1 breaking change related to ADLS support

I agree with Fokko in that we should do a 1.7.2 release for people using ADLSFileIO On Tue, Dec 17, 2024 at 9:58 AM Fokko Driesprong wrote: > Thanks for raising this Alex, > > I suggest doing a 1.7.2 patch release since we don't want to leave the > 1.7.x version in a broken state for the ADLSFil

Re: 1.7.1 breaking change related to ADLS support

I took the liberty of creating a 1.7.2 milestone: https://github.com/apache/iceberg/milestone/52 Kind regards, Fokko Op di 17 dec 2024 om 09:58 schreef Fokko Driesprong : > Thanks for raising this Alex, > > I suggest doing a 1.7.2 patch release since we don't want to leave the > 1.7.x version in

Re: 1.7.1 breaking change related to ADLS support

Thanks for raising this Alex, I suggest doing a 1.7.2 patch release since we don't want to leave the 1.7.x version in a broken state for the ADLSFileIO. Kind regards, Fokko Op di 17 dec 2024 om 07:40 schreef Jean-Baptiste Onofré : > Hi Alex, > > It was exactly my concern (and question) when I d

Re: 1.7.1 breaking change related to ADLS support

Hi Alex, It was exactly my concern (and question) when I did the review on the PR. I agree it's breaking change and definitely not good in a micro/patch release. As 1.7.0 is still working, I would propose to wait 1.8.0 if possible: I'm actually preparing a new thread with 1.8.0 proposal (in term

1.7.1 breaking change related to ADLS support

Just a heads up, but I believe this PR ( https://github.com/apache/iceberg/pull/11504) that was added to the 1.7.1 introduced a breaking change for anyone previously supporting ADLSFileIO / credentials with sasTokens. I added some details in the PR com