I agree with Fokko in that we should do a 1.7.2 release for people using ADLSFileIO
On Tue, Dec 17, 2024 at 9:58 AM Fokko Driesprong <fo...@apache.org> wrote: > Thanks for raising this Alex, > > I suggest doing a 1.7.2 patch release since we don't want to leave the > 1.7.x version in a broken state for the ADLSFileIO. > > Kind regards, > Fokko > > Op di 17 dec 2024 om 07:40 schreef Jean-Baptiste Onofré <j...@nanthrax.net>: > >> Hi Alex, >> >> It was exactly my concern (and question) when I did the review on the PR. >> >> I agree it's breaking change and definitely not good in a micro/patch >> release. >> >> As 1.7.0 is still working, I would propose to wait 1.8.0 if possible: >> I'm actually preparing a new thread with 1.8.0 proposal (in terms of >> timing and content like improved security/auth flow in REST). >> >> Would it work for you or are you calling for 1.7.2 ? >> >> Regards >> JB >> >> On Tue, Dec 17, 2024 at 1:06 AM Alex Reid <alex.james.r...@gmail.com> >> wrote: >> > >> > Just a heads up, but I believe this PR ( >> https://github.com/apache/iceberg/pull/11504) that was added to the >> 1.7.1 introduced a breaking change for anyone previously supporting >> ADLSFileIO / credentials with sasTokens. I added some details in the PR >> comments, but will also provide those details here as well since the PR is >> closed. >> > >> > On initialization of ADLSFileIO, AzureProperties is created and builds >> a map of account -> sasToken here when you create ADLSFileIO using >> adls.sas-token. as the credential mechanism. >> > >> > Prior to this change, the account passed in here (which is used to >> lookup the sasToken from the map mentioned above) was parsed to include . >> dfs.core.windows.net so when generating the adls.sas-token. property to >> pass into ADLSFileIO, you needed to include .dfs.core.windows.net as >> part of the adls.sas-token. property name. After this change, we are >> parsing the ADLSLocation account to NOT include adls.sas-token., so now the >> sasToken lookup from the map doesn't find the sasToken. When someone >> updates to 1.7.1, they will/would also need to update how they are >> configuring / building the ADLSFileIO properties when using sasTokens. >> > >> > >> > -alex >> >
