Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Eduard Tudenhöfner
Thanks everyone for participating. The vote result is: +1: 6 (binding), 8 (non-binding) +0: 0 -1: 0 Therefore, the release candidate is passed. On Thu, Feb 27, 2025 at 10:53 PM Steve Zhang wrote: > +1 (non-binding) > > - Checked signature/SHA512 > - Ran RAT license check > - Ran tests on JDK1

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Aihua Xu
Thanks Alex. On Thu, Feb 27, 2025 at 10:31 AM Alex Dutra wrote: > Hi Aihua, > > I was indeed suspecting that you had a custom RESTClient :-) Thanks for > digging further and clarifying! Let me know if you need my help in adapting > your code. > > And with that: +1 (non-binding) from me as well.

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Steve Zhang
+1 (non-binding) - Checked signature/SHA512 - Ran RAT license check - Ran tests on JDK17 Thanks, Steve Zhang > On Feb 27, 2025, at 11:45 AM, Daniel Weeks wrote: > > +1 (binding) > > Verified sigs/sums/license/build/test (Java 17) > > -Dan > > On Thu, Feb 27, 2025 at 11:30 AM Aihua Xu

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Daniel Weeks
+1 (binding) Verified sigs/sums/license/build/test (Java 17) -Dan On Thu, Feb 27, 2025 at 11:30 AM Aihua Xu wrote: > Thanks Alex. > > On Thu, Feb 27, 2025 at 10:31 AM Alex Dutra > wrote: > >> Hi Aihua, >> >> I was indeed suspecting that you had a custom RESTClient :-) Thanks for >> digging fu

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Alex Dutra
Hi Aihua, I was indeed suspecting that you had a custom RESTClient :-) Thanks for digging further and clarifying! Let me know if you need my help in adapting your code. And with that: +1 (non-binding) from me as well. Thanks, Alex On Thu, Feb 27, 2025 at 6:45 PM Aihua Xu wrote: > Hi Alex, >

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Aihua Xu
Hi Alex, I checked our code further. We have an internal implementation for RESTClient which needs an update after your change to place the token in DefaultAuthSession and not pass through initHeaders anymore. The existing code assumes the token coming from initHeaders and we need to make the chan

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Alex Dutra
Hi Aihua Xu, I reviewed your PR but without further details I do not agree with your change, and I am unable to reproduce the issue. Besides, we have unit tests that cover this extensively. Could you please provide a simple reproducer or a test case? Thanks! Alex On Thu, Feb 27, 2025 at 5:06 P

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Aihua Xu
I'm running within our integration tests. I'm able to trace and find the breaking change: https://github.com/apache/iceberg/pull/11992. Seems we need to make the following changes to pass the token: https://github.com/apache/iceberg/pull/12415/files. Alex, can you help take a look at this? if (ha

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Alex Dutra
Hi Aihua, I just tested 1.8.1 with Polaris OSS and I am not seeing anything different. Can you share your setup? Below is my Spark setup. Thanks, Alex ./gradlew run token=$(curl -s http://localhost:8181/api/catalog/v1/oauth/tokens \ --user root: \ -d grant_type=client_credentials \ -d s

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-26 Thread Aihua Xu
I tested 1.8.1 RC with Snowflake build. I'm seeing the following (I'm not seeing that in 1.7.x). "exception": "java.io.IOException: *Authorization header is missing*\n\tat org.apache.polaris.service.dropwizard.auth.PolarisPrincipalAuthenticator.filter(PolarisPrincipalAuthenticator.java:43)\n\tat o

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-26 Thread Péter Váry
+1 checked the signatures, checksums build and run some tests Amogh Jahagirdar <2am...@gmail.com> ezt írta (időpont: 2025. febr. 26., Sze, 6:11): > +1 (binding) > > Verified signatures, checksum, RAT checks. > Ran build and test with JDK17 > > Thanks, > Amogh Jahagirdar > > On Wed, Feb 26, 2025

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-25 Thread Amogh Jahagirdar
+1 (binding) Verified signatures, checksum, RAT checks. Ran build and test with JDK17 Thanks, Amogh Jahagirdar On Wed, Feb 26, 2025 at 2:30 AM Honah J. wrote: > +1 (binding) > > - Checked signatures and checksum > - Checked license > - Full Build and Test > > Best regards, > Honah > > On Tue,

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-25 Thread Honah J.
+1 (binding) - Checked signatures and checksum - Checked license - Full Build and Test Best regards, Honah On Tue, Feb 25, 2025 at 10:52 AM Russell Spitzer wrote: > +1 > Checked Sigs and Checksum > Ran Rat > Ran full build/test > > > On Tue, Feb 25, 2025 at 11:30 AM Driesprong, Fokko > wro

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-25 Thread Russell Spitzer
+1 Checked Sigs and Checksum Ran Rat Ran full build/test On Tue, Feb 25, 2025 at 11:30 AM Driesprong, Fokko wrote: > +1 (binding) > >- Checked signatures and checksum >- Checked licenses >- Spotchecked NOTICE/LICENSE > > Kind regards, > Fokko > > Op di 25 feb 2025 om 16:56 schree

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-25 Thread Driesprong, Fokko
+1 (binding) - Checked signatures and checksum - Checked licenses - Spotchecked NOTICE/LICENSE Kind regards, Fokko Op di 25 feb 2025 om 16:56 schreef Kevin Liu : > +1 (non-binding) > > I followed "How to Verify a Release" >

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-25 Thread Kevin Liu
+1 (non-binding) I followed "How to Verify a Release" . Checked out artifact from SVN, ``` svn checkout https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.8.1-rc1/ . ``` Verified * Signature Good * Checksum Ok * RAT

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-25 Thread Jean-Baptiste Onofré
+1 (non binding) - Hash and checksum are good - LICENSE and NOTICE are OK in different distributed artifacts (source distribution, aws bundle, etc) - ASF header present in all expected files - No binary file found in the source distribution - Did quick smoke tests Thanks, Regards JB On Mon, Feb

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-24 Thread Ajantha Bhat
+1 (non-binding) * validated checksum and signature * checked license docs & ran RAT checks * ran build and tests with JDK11 - Ajantha On Tue, Feb 25, 2025 at 9:52 AM Renjie Liu wrote: > +1 binding. > > Did following check: > 1. Verified sha512 > 2. Verified signature > 3. Run test and build >

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-24 Thread Renjie Liu
+1 binding. Did following check: 1. Verified sha512 2. Verified signature 3. Run test and build 4. Run dev/check-license On Tue, Feb 25, 2025 at 7:46 AM Yuya Ebihara wrote: > +1 (non-binding) > > I verified that Trino CI is green with Iceberg 1.8.1. > Thanks for your work, Edward. > > BR, > Yuy

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-24 Thread Yuya Ebihara
+1 (non-binding) I verified that Trino CI is green with Iceberg 1.8.1. Thanks for your work, Edward. BR, Yuya On Tue, Feb 25, 2025 at 2:20 AM Hussein Awala wrote: > +1 (non-binding) - Tested with Spark 3.5.4, JDK 17, S3 FileIO (MinIO), and > Hive3 as the catalog. > Validated the following oper

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-24 Thread Hussein Awala
+1 (non-binding) - Tested with Spark 3.5.4, JDK 17, S3 FileIO (MinIO), and Hive3 as the catalog. Validated the following operations: - Creating a new table - Appending data - Merging into tables - Updating schema and properties - Scanning tables On Mon, Feb 24, 2025 at 2:49 PM Eduard Tudenhoefner

[VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-24 Thread Eduard Tudenhoefner
Hi Everyone, I propose that we release the following RC as the official Apache Iceberg 1.8.1 release. The commit ID is *9ce0fcf0af7becf25ad9fc996c3bad2afdcfd33d* * This corresponds to the tag: *apache-iceberg-1.8.1-rc1* * https://github.com/apache/iceberg/commits/apache-iceberg-1.8.1-rc1 * https: