Re: [VOTE] Release Apache Iceberg 1.4.0 RC1

JB, we do have tests for converting filters as well as for checking actual pushdown. Looks like we initially missed decimals but I've added them in PR 8682. The more tests we have the better. If you have a bit of time, it would be nice to go back and check what else we missed. I'd start by look

Re: [VOTE] Release Apache Iceberg 1.4.0 RC2

+1 (binding) Validated signature, checksum, local build + tests. - Anton On 2023/09/30 04:58:15 Jean-Baptiste Onofré wrote: > +1 (non binding) > > As for RC1, I checked: > - signature and hash are OK > - ASF headers are there > - source distribution doesn't contain binary > - build is OK > > T

Re: [VOTE] Release Apache Iceberg 1.4.0 RC2

+1 (non binding) As for RC1, I checked: - signature and hash are OK - ASF headers are there - source distribution doesn't contain binary - build is OK Thanks, Regards JB On Sat, Sep 30, 2023 at 1:25 AM Anton Okolnychyi wrote: > > Hi Everyone, > > I propose that we release the following RC as th

Re: [VOTE] Release Apache Iceberg 1.4.0 RC1

Thanks Anton, Do we have unit tests about filter pushdown ? Maybe worth to add something around that right ? Anyway, I'm adding filter test cases in my "samples" repo. Thanks ! Regards JB On Fri, Sep 29, 2023 at 6:30 PM Anton Okolnychyi wrote: > > Ugh, it looks like the filter pushdown issue i

[VOTE] Release Apache Iceberg 1.4.0 RC2

Hi Everyone, I propose that we release the following RC as the official Apache Iceberg 1.4.0 release. The commit ID is 10367c380098c2e06a49521a33681ac7f6c64b2c * This corresponds to the tag: apache-iceberg-1.4.0-rc2 * https://github.com/apache/iceberg/commits/apache-iceberg-1.4.0-rc2 * https://

Re: Migration of PyIceberg to iceberg-python repository

+1 Great work Fokko! Pucheng, We still want to maintain all of the issues in the Python repository. The one thing we will lose is pull requests, but I assume there are very few. On Fri, Sep 29, 2023 at 10:34 AM Pucheng Yang wrote: > Thanks for doing this. I wonder how do we deal with all the

Re: Migration of PyIceberg to iceberg-python repository

+1 On Fri, Sep 29, 2023 at 8:34 AM Pucheng Yang wrote: > Thanks for doing this. I wonder how do we deal with all the issues filed > for python module but still open in iceberg repo? > > On Fri, Sep 29, 2023 at 7:55 AM Eduard Tudenhoefner > wrote: > >> +1 on moving to a separate repo and maintai

Re: [VOTE] Release Apache Iceberg 1.4.0 RC1

It is actually something we would want to fix. We used V1 filters before and Spark was responsible for converting values. We migrated to V2 filters and missed to convert Spark internal decimal values. https://github.com/apache/iceberg/pull/8682 Thanks everyone for testing, it means a lot! I'll

Re: [VOTE] Release Apache Iceberg 1.4.0 RC1

Ugh, it looks like the filter pushdown issue is a regression. I tested 1.3.1 and it worked. I guess it is because we migrated to V2 filters and their behavior is different. I need to take a closer look. On 2023/09/29 11:36:09 Eduard Tudenhoefner wrote: > +1 (non-binding) > > * validated checksu

Re: Migration of PyIceberg to iceberg-python repository

Thanks for doing this. I wonder how do we deal with all the issues filed for python module but still open in iceberg repo? On Fri, Sep 29, 2023 at 7:55 AM Eduard Tudenhoefner wrote: > +1 on moving to a separate repo and maintaining git history > > On Fri, Sep 29, 2023 at 3:30 PM Jean-Baptiste On

Re: Migration of PyIceberg to iceberg-python repository

+1 on moving to a separate repo and maintaining git history On Fri, Sep 29, 2023 at 3:30 PM Jean-Baptiste Onofré wrote: > Awesome, it looks even better ;) > > Thanks ! > Regards > JB > > On Fri, Sep 29, 2023 at 2:31 PM Fokko Driesprong wrote: > > > > Hey Ajantha, > > > > That's a great suggesti

Re: Migration of PyIceberg to iceberg-python repository

Awesome, it looks even better ;) Thanks ! Regards JB On Fri, Sep 29, 2023 at 2:31 PM Fokko Driesprong wrote: > > Hey Ajantha, > > That's a great suggestion. I've followed the steps and created a new PR here: > https://github.com/apache/iceberg-python/pull/3 > > The subdirectory-filter command m

Re: Migration of PyIceberg to iceberg-python repository

Hi Fokko, Thanks for quickly addressing it. The new PR LGTM. One minor suggestion is we can have new commits related to new repo like "Add missing root files" as an independent PR before this PR and keep the diff just for moving the folder. Thanks, Ajantha On Fri, Sep 29, 2023 at 6:05 PM Fokko D

Re: Migration of PyIceberg to iceberg-python repository

Hi Fokko +1 to move PyIceberg to iceberg-python repo. Can we keep track of log history ? For me, it's not a blocker, we can move even if we lose the history though. Regards JB On Fri, Sep 29, 2023 at 1:25 PM Fokko Driesprong wrote: > > Hey everyone 👋 > > A while ago we discussed that Rust and G

Re: [DISCUSSION] Rename master branch as main for the main repository

+1000 Let me know how I can help! On Fri, Sep 29, 2023 at 7:35 AM Jean-Baptiste Onofré wrote: > Hi guys, > > The Apache CoC (https://www.apache.org/foundation/policies/conduct) > especially contains section 5 about the wording we use. Several Apache > projects renamed the master branch to t

[DISCUSSION] Rename master branch as main for the main repository

Hi guys, The Apache CoC (https://www.apache.org/foundation/policies/conduct) especially contains section 5 about the wording we use. Several Apache projects renamed the master branch to the main branch (Apache Karaf, ActiveMQ, Airflow, ...). As we already use main for go, rust, and python reposito

Re: Migration of PyIceberg to iceberg-python repository

Hey Ajantha, That's a great suggestion. I've followed the steps and created a new PR here: https://github.com/apache/iceberg-python/pull/3 The subdirectory-filter command moves a subdirectory to the root directory. This way I still had to add some files afterward (.github/*, .gitignore, etc.), th

Re: Migration of PyIceberg to iceberg-python repository

I think we are gonna lose the history of commits if we merge the above PR. There are ways to move the subfolder into a new repo by retaining commit history. For example: - https://medium.com/@ayushya/move-directory-from-one-repository-to-another-preserving-git-history-d210fa049d4b - https://gist.

Re: [VOTE] Release Apache Iceberg 1.4.0 RC1

+1 (non-binding) * validated checksum and signature * checked license docs & ran RAT checks * ran build and tests with JDK17 * ran some tests with Spark 3.4 + 3.5 and the new iceberg-aws-bundle.jar * ran some internal tests I found two test issues with Flink (#8680

Migration of PyIceberg to iceberg-python repository

Hey everyone 👋 A while ago we discussed that Rust and Go are going into a separate repository: https://lists.apache.org/thread/4s02lmwf1kyrxxdpj3q9w2fqnxq2llbn Since we just did the PyIcerg 0.5.0 release, I think it is a good moment to migrate PyIceberg to iceberg-python as well: https://github.

Re: [VOTE] Release Apache Iceberg 1.4.0 RC1

+1 (non-binding) - Verified Nessie integration testing (API v2 and V1) with Spark-3.3_2.12_runtime jar. - Validated checksum and signature - Checked license docs & ran RAT checks - Verified build with JDK11 Thanks, Ajantha On Fri, Sep 29, 2023 at 3:13 PM Fokko Driesprong wrote: > +1 (binding)

Re: [VOTE] Release Apache Iceberg 1.4.0 RC1

+1 (binding) Thanks Anton for running the release and everyone who contributed! Checks I did: - Updated the docker-spark-iceberg repo , and everything runs fine (still with Spark 3.4 since there were some problems with Jupyte

[GitHub] [iceberg-python] dependabot[bot] opened a new pull request, #1: Bump pypa/cibuildwheel from 2.16.0 to 2.16.1

dependabot[bot] opened a new pull request, #1: URL: https://github.com/apache/iceberg-python/pull/1 Bumps [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) from 2.16.0 to 2.16.1. Release notes Sourced from https://github.com/pypa/cibuildwheel/releases";>pypa/cibuildwheel's