Hi Fokko, Thanks for quickly addressing it. The new PR LGTM. One minor suggestion is we can have new commits related to new repo like "Add missing root files" as an independent PR before this PR and keep the diff just for moving the folder.
Thanks, Ajantha On Fri, Sep 29, 2023 at 6:05 PM Fokko Driesprong <fo...@apache.org> wrote: > Hey Ajantha, > > That's a great suggestion. I've followed the steps and created a new PR > here: https://github.com/apache/iceberg-python/pull/3 > > The subdirectory-filter command moves a subdirectory to the root > directory. This way I still had to add some files afterward (.github/*, > .gitignore, etc.), these are in a separate commit. Please take a look. > > Thanks, > > Fokko > > Op vr 29 sep 2023 om 13:39 schreef Ajantha Bhat <ajanthab...@gmail.com>: > >> I think we are gonna lose the history of commits if we merge the above PR. >> >> There are ways to move the subfolder into a new repo by retaining commit >> history. >> For example: >> - >> https://medium.com/@ayushya/move-directory-from-one-repository-to-another-preserving-git-history-d210fa049d4b >> >> - https://gist.github.com/trongthanh/2779392 >> >> Please give it a try. >> >> Thanks, >> Ajantha >> >> On Fri, Sep 29, 2023 at 4:55 PM Fokko Driesprong <fo...@apache.org> >> wrote: >> >>> Hey everyone 👋 >>> >>> A while ago we discussed that Rust and Go are going into a separate >>> repository: >>> https://lists.apache.org/thread/4s02lmwf1kyrxxdpj3q9w2fqnxq2llbn >>> >>> Since we just did the PyIcerg 0.5.0 release, I think it is a good moment >>> to migrate PyIceberg to iceberg-python as well: >>> https://github.com/apache/iceberg-python/pull/2 >>> <https://github.com/apache/iceberg-python/pull/2> I went over the PRs >>> that are ready to merge and got them in. If there is anything missing, >>> please let me know. >>> >>> I would suggest merging the PR and leaving the source code in the main >>> repository for another week or so to make sure that we didn't miss anything. >>> >>> Since PyIceberg now also hosts the docs on the Github pages of the >>> Iceberg repository, moving PyIceberg will also free up the Github pages for >>> the migration of the docs back into the main repository. >>> >>> Let me know if there are any concerns. >>> >>> Kind regards, >>> Fokko Driesprong >>> >>
