Re: Review Request 26178: Truncating table doesnt invalidate stats

2014-09-30 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26178/#review54998 --- Ship it! Ship It! - Prasanth_J On Sept. 30, 2014, 5:47 p.m., Ash

Re: Review Request 26261: hive stats issue when insert query is appending data into table

2014-10-01 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26261/#review55192 --- Ship it! Ship It! - Prasanth_J On Oct. 2, 2014, 4:51 a.m., Ashut

Re: Review Request 27167: Constant folding should happen early

2014-10-24 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27167/#review58401 --- Ship it! Ship It! - Prasanth_J On Oct. 24, 2014, 9:49 p.m., Ashu

Re: Review Request 24830: HIVE-7548: Precondition checks should not fail the merge task in case of automatic trigger

2014-08-25 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24830/#review51419 --- ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java

Re: Review Request 24830: HIVE-7548: Precondition checks should not fail the merge task in case of automatic trigger

2014-08-25 Thread j . prasanth . j
> On Aug. 25, 2014, 6:48 p.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 1549 > > > > > > Use named capture in java as much as possible. > > > > (?[0-9]+) etc. Named

Re: Review Request 24830: HIVE-7548: Precondition checks should not fail the merge task in case of automatic trigger

2014-08-25 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24830/ --- (Updated Aug. 25, 2014, 7:54 p.m.) Review request for hive and Gunther Hagleitn

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51754 --- metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51762 --- ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51763 --- ql/src/test/queries/clientpositive/temp_table_display_colstats_tbll

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread j . prasanth . j
> On Aug. 28, 2014, 7:59 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 89 > > > > > > This doesn't look good. Can you use Map > > instead? with key being fully qualif

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread j . prasanth . j
> On Aug. 28, 2014, 8:02 a.m., Prasanth_J wrote: > > ql/src/test/queries/clientpositive/temp_table_display_colstats_tbllvl.q, > > line 1 > > > > > > Can you also add a testcase for partitioned table? similar to > > col

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread j . prasanth . j
> On Aug. 28, 2014, 7:56 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java, > > line 396 > > > > > > Is there any reason why you are not using FieldSchema's equ

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-29 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51875 --- Ship it! Ship It! - Prasanth_J On Aug. 29, 2014, 6:13 a.m., Jaso

Re: Review Request 24627: HIVE-7704: Create tez task for fast file merging

2014-09-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24627/ --- (Updated Sept. 5, 2014, 7:51 a.m.) Review request for hive and Gunther Hagleitn

Re: Review Request 25341: HIVE-7078 Need file sink operators that work with ACID

2014-09-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25341/#review52339 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java

Review Request 25395: HIVE-7990: With fetch column stats disabled number of elements in grouping set is not taken into account

2014-09-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25395/ --- Review request for hive, Ashutosh Chauhan, Gunther Hagleitner, and Harish Butani

Re: Review Request 25395: HIVE-7990: With fetch column stats disabled number of elements in grouping set is not taken into account

2014-09-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25395/#review52493 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/St

Re: Review Request 25395: HIVE-7990: With fetch column stats disabled number of elements in grouping set is not taken into account

2014-09-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25395/#review52494 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/St

Re: Review Request 25395: HIVE-7990: With fetch column stats disabled number of elements in grouping set is not taken into account

2014-09-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25395/#review52527 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/St

Re: Review Request 25395: HIVE-7990: With fetch column stats disabled number of elements in grouping set is not taken into account

2014-09-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25395/ --- (Updated Sept. 5, 2014, 10:34 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 24627: HIVE-7704: Create tez task for fast file merging

2014-09-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24627/ --- (Updated Sept. 6, 2014, 2:03 a.m.) Review request for hive and Gunther Hagleitn

Re: Review Request 24627: HIVE-7704: Create tez task for fast file merging

2014-09-08 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24627/#review52679 --- ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractFileMergeOperato

Re: Review Request 24627: HIVE-7704: Create tez task for fast file merging

2014-09-09 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24627/ --- (Updated Sept. 9, 2014, 7:32 a.m.) Review request for hive and Gunther Hagleitn

Review Request 67420: HIVE-19772: Streaming ingest V2 API can generate invalid orc file if interrupted

2018-06-01 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67420/ --- Review request for hive, Eugene Koifman and Gopal V. Bugs: HIVE-19772 https

Re: Review Request 67406: HIVE-19663 refactor LLAP IO report generation

2018-06-01 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67406/#review204216 --- Ship it! Ship It! - Prasanth_J On May 31, 2018, 10:19 p.m.,

Re: Review Request 67420: HIVE-19772: Streaming ingest V2 API can generate invalid orc file if interrupted

2018-06-04 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67420/ --- (Updated June 5, 2018, 6:39 a.m.) Review request for hive, Eugene Koifman and G

Review Request 67474: HIVE-19817: Hive streaming API + dynamic partitioning + json/regex writer does not work

2018-06-06 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67474/ --- Review request for hive and Eugene Koifman. Bugs: HIVE-19817 https://issues

Review Request 67497: HIVE-19794: Disable removing order by from subquery in GenericUDTFGetSplits

2018-06-07 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67497/ --- Review request for hive and Jason Dere. Bugs: HIVE-19794 https://issues.apa

Re: Review Request 54094: HIVE-15190: Field names are not preserved in ORC files written with ACID

2018-06-14 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54094/#review204793 --- ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java Lines

Review Request 67858: HIVE-20126: OrcInputFormat does not pass conf to orc reader options

2018-07-09 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67858/ --- Review request for hive and Sergey Shelukhin. Bugs: HIVE-20126 https://issu

Review Request 67966: HIVE-20202: Add profiler endpoint to httpserver

2018-07-18 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67966/ --- Review request for hive and Gopal V. Bugs: HIVE-20202 https://issues.apache

Re: Review Request 67966: HIVE-20202: Add profiler endpoint to httpserver

2018-07-18 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67966/ --- (Updated July 18, 2018, 6:42 p.m.) Review request for hive and Gopal V. Chang

Re: Review Request 67966: HIVE-20202: Add profiler endpoint to httpserver

2018-07-18 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67966/ --- (Updated July 19, 2018, 1:08 a.m.) Review request for hive and Gopal V. Chang

Re: Review Request 67966: HIVE-20202: Add profiler endpoint to httpserver

2018-07-19 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67966/ --- (Updated July 19, 2018, 7:05 a.m.) Review request for hive and Gopal V. Chang

Re: Review Request 67966: HIVE-20202: Add profiler endpoint to httpserver

2018-07-19 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67966/ --- (Updated July 19, 2018, 8:10 p.m.) Review request for hive and Gopal V. Chang

Re: Review Request 67966: HIVE-20202: Add profiler endpoint to httpserver

2018-07-21 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67966/ --- (Updated July 21, 2018, 9:47 a.m.) Review request for hive and Gopal V. Chang

Review Request 68075: HIVE-20249: LLAP IO: NPE during refCount decrement

2018-07-26 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68075/ --- Review request for hive and Sergey Shelukhin. Bugs: HIVE-20249 https://issu

Re: Review Request 68075: HIVE-20249: LLAP IO: NPE during refCount decrement

2018-07-26 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68075/ --- (Updated July 27, 2018, 12:21 a.m.) Review request for hive and Sergey Shelukhi

Review Request 68115: HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List object inspectors

2018-07-30 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68115/ --- Review request for hive, Gopal V and Sergey Shelukhin. Repository: hive-git D

Re: Review Request 68115: HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List object inspectors

2018-07-30 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68115/ --- (Updated July 31, 2018, 12:08 a.m.) Review request for hive, Gopal V and Sergey

Re: Review Request 68115: HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List object inspectors

2018-07-30 Thread j . prasanth . j
> On July 31, 2018, 12:17 a.m., Gopal V wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java > > Lines 76 (patched) > > > > > > The type -> ObjectInspector is the only on

Re: Review Request 68115: HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List object inspectors

2018-08-01 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68115/ --- (Updated Aug. 1, 2018, 10:32 p.m.) Review request for hive, Gopal V and Sergey

Re: Review Request 68709: HIVE-20547 HS2: support Tez sessions started by someone else (part 1)

2018-09-13 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68709/#review208584 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezExternalSession

Re: Review Request 68709: HIVE-20547 HS2: support Tez sessions started by someone else (part 1)

2018-09-13 Thread j . prasanth . j
> On Sept. 13, 2018, 8:03 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezExternalSessionsRegistryClient.java > > Lines 37 (patched) > > > > > > Yes. Tez needs severals fixes in addition

Re: Review Request 68709: HIVE-20547 HS2: support Tez sessions started by someone else (part 1)

2018-09-13 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68709/#review208608 --- Ship it! Ship It! - Prasanth_J On Sept. 13, 2018, 8:11 p.m.,

Review Request 68946: HIVE-20707: Automatic MSCK REPAIR for external tables

2018-10-07 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68946/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-20707 https://issu

Re: Review Request 68946: HIVE-20707: Automatic MSCK REPAIR for external tables

2018-10-11 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68946/ --- (Updated Oct. 12, 2018, 1:35 a.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 68946: HIVE-20707: Automatic MSCK REPAIR for external tables

2018-10-11 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68946/ --- (Updated Oct. 12, 2018, 1:35 a.m.) Review request for hive, Ashutosh Chauhan an

Review Request 69011: HIVE-20713: Use percentage for join conversion size thresholds

2018-10-12 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69011/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-20713 https://issu

Re: Review Request 68946: HIVE-20707: Automatic MSCK REPAIR for external tables

2018-10-15 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68946/ --- (Updated Oct. 16, 2018, 12:21 a.m.) Review request for hive, Ashutosh Chauhan a

Re: Review Request 68946: HIVE-20707: Automatic MSCK REPAIR for external tables

2018-10-15 Thread j . prasanth . j
> On Oct. 16, 2018, 2:28 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > > Lines 4761 (patched) > > > > > > Should this be on by default? If there are a lot of external tables

Re: Review Request 68946: HIVE-20707: Automatic MSCK REPAIR for external tables

2018-10-15 Thread j . prasanth . j
> On Oct. 16, 2018, 2:28 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > > Lines 4761 (patched) > > > > > > Should this be on by default? If there are a lot of external tables

Re: Review Request 68946: HIVE-20707: Automatic MSCK REPAIR for external tables

2018-10-16 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68946/ --- (Updated Oct. 16, 2018, 7:02 a.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 68946: HIVE-20707: Automatic MSCK REPAIR for external tables

2018-10-17 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68946/ --- (Updated Oct. 17, 2018, 7:14 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 69148: HIVE-20793 add RP namespacing to workload management

2018-10-26 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69148/#review210105 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 54

Re: Review Request 69148: HIVE-20793 add RP namespacing to workload management

2018-10-26 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69148/#review210118 --- Ship it! Ship It! - Prasanth_J On Oct. 26, 2018, 11:23 p.m.,

Re: Review Request 68946: HIVE-20707: Automatic MSCK REPAIR for external tables

2018-10-29 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68946/ --- (Updated Oct. 29, 2018, 9:17 a.m.) Review request for hive, Ashutosh Chauhan an

Review Request 69965: HIVE-21254: Pre-upgrade tool should handle exceptions and skip db/tables

2019-02-12 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69965/ --- Review request for hive, Eugene Koifman and Jason Dere. Bugs: HIVE-21254 ht

Re: Review Request 69965: HIVE-21254: Pre-upgrade tool should handle exceptions and skip db/tables

2019-02-12 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69965/ --- (Updated Feb. 13, 2019, 1:15 a.m.) Review request for hive, Eugene Koifman and

Re: Review Request 69965: HIVE-21254: Pre-upgrade tool should handle exceptions and skip db/tables

2019-02-13 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69965/ --- (Updated Feb. 14, 2019, 12:17 a.m.) Review request for hive, Eugene Koifman and

Re: Review Request 70224: HIVE-21457: Perf optimizations in ORC split-generation

2019-03-15 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70224/ --- (Updated March 16, 2019, 12:28 a.m.) Review request for hive and Gopal V. Cha

Review Request 70224: HIVE-21457: Perf optimizations in ORC split-generation

2019-03-15 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70224/ --- Review request for hive and Gopal V. Bugs: HIVE-21457 https://issues.apache

Review Request 70372: HIVE-21427: Syslog storage handler

2019-04-02 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70372/ --- Review request for hive, Ashutosh Chauhan and Jason Dere. Bugs: HIVE-21427

Re: Review Request 70372: HIVE-21427: Syslog storage handler

2019-04-03 Thread j . prasanth . j
> On April 3, 2019, 9:54 p.m., Jason Dere wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java > > Line 615 (original), 615 (patched) > > > > > > Just curious about this one,

Re: Review Request 70372: HIVE-21427: Syslog storage handler

2019-04-04 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70372/ --- (Updated April 4, 2019, 6:18 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 70372: HIVE-21427: Syslog storage handler

2019-04-04 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70372/ --- (Updated April 4, 2019, 9:28 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 70372: HIVE-21427: Syslog storage handler

2019-04-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70372/ --- (Updated April 5, 2019, 7:39 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 70372: HIVE-21427: Syslog storage handler

2019-04-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70372/ --- (Updated April 5, 2019, 11:05 p.m.) Review request for hive, Ashutosh Chauhan a

Review Request 70442: HIVE-21597: WM trigger validation should happen at the time of create or alter

2019-04-10 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70442/ --- Review request for hive and Daniel Dai. Bugs: HIVE-21597 https://issues.apa

Re: Review Request 71555: Incompatible java.util.ArrayList for java 11

2019-10-01 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71555/#review218010 --- Ship it! Ship It! - Prasanth_J On Sept. 30, 2019, 7:23 a.m.,

Re: Review Request 24176: Fetch aggregated stats from MetaStore

2014-08-01 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24176/#review49414 --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreCl

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-06 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/#review49814 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinPr

Review Request 24575: HIVE-7679: JOIN operator should update the column stats when number of rows changes

2014-08-11 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24575/ --- Review request for hive, Gunther Hagleitner and Harish Butani. Bugs: HIVE-7679

Review Request 24627: HIVE-7704: Create tez task for fast file merging

2014-08-12 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24627/ --- Review request for hive and Gunther Hagleitner. Bugs: HIVE-7704 https://iss

Re: Review Request 24627: HIVE-7704: Create tez task for fast file merging

2014-08-12 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24627/ --- (Updated Aug. 13, 2014, 2:17 a.m.) Review request for hive and Gunther Hagleitn

Review Request 24711: HIVE-7734: Join stats annotation rule is not updating columns statistics correctly

2014-08-14 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24711/ --- Review request for hive, Gunther Hagleitner and Harish Butani. Bugs: HIVE-7734

Re: Review Request 24627: HIVE-7704: Create tez task for fast file merging

2014-08-14 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24627/ --- (Updated Aug. 14, 2014, 8:53 p.m.) Review request for hive and Gunther Hagleitn

Re: Review Request 24627: HIVE-7704: Create tez task for fast file merging

2014-08-14 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24627/ --- (Updated Aug. 15, 2014, 5:27 a.m.) Review request for hive and Gunther Hagleitn

Review Request 24830: HIVE-7548: Precondition checks should not fail the merge task in case of automatic trigger

2014-08-18 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24830/ --- Review request for hive and Gunther Hagleitner. Repository: hive-git Descript

Review Request 24834: HIVE-7771: ORC PPD fails for some decimal predicates

2014-08-18 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24834/ --- Review request for hive and Gunther Hagleitner. Repository: hive-git Descript

Re: Review Request 24834: HIVE-7771: ORC PPD fails for some decimal predicates

2014-08-18 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24834/ --- (Updated Aug. 19, 2014, 1:32 a.m.) Review request for hive, Gopal V and Gunther

Re: Review Request 24834: HIVE-7771: ORC PPD fails for some decimal predicates

2014-08-18 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24834/#review50955 --- ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java

Re: Review Request 24834: HIVE-7771: ORC PPD fails for some decimal predicates

2014-08-19 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24834/ --- (Updated Aug. 19, 2014, 5:51 p.m.) Review request for hive, Gopal V and Gunther

Re: Review Request 24834: HIVE-7771: ORC PPD fails for some decimal predicates

2014-08-19 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24834/ --- (Updated Aug. 19, 2014, 5:59 p.m.) Review request for hive, Gopal V and Gunther

Re: Review Request 24913: HIVE-7222: Support timestamp column statistics in ORC and extend PPD for timestamp

2014-08-20 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24913/#review51146 --- Ship it! Ship It! - Prasanth_J On Aug. 20, 2014, 10:36 p.m., Dan

Re: Review Request 27455: HIVE-8689 handle overflows in statistics better

2014-10-31 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27455/#review59440 --- ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java

Re: Review Request 27599: HIVE-8735 : statistics update can fail due to long paths

2014-11-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27599/#review60033 --- ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsSetupCons

Re: Review Request 27599: HIVE-8735 : statistics update can fail due to long paths

2014-11-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27599/#review60099 --- Ship it! Ship It! - Prasanth_J On Nov. 6, 2014, 3:07 a.m., Serge

Re: Review Request 62596: HIVE-17611: Add new LazyBinary SerDe for faster writes

2017-09-26 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62596/#review186334 --- Ship it! Ship It! - Prasanth_J On Sept. 26, 2017, 9:10 p.m.,

Re: Review Request 62596: HIVE-17611: Add new LazyBinary SerDe for faster writes

2017-09-26 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62596/#review186332 --- serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinar

Review Request 62680: HIVE-17637: Move WorkloadManager to service module

2017-09-28 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62680/ --- Review request for hive and Sergey Shelukhin. Bugs: HIVE-17637 https://issu

Re: Review Request 62706: HIVE-17473 implement workload management pools

2017-10-17 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62706/#review188406 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.ja

Re: Review Request 62706: HIVE-17473 implement workload management pools

2017-10-18 Thread j . prasanth . j
> On Oct. 17, 2017, 10:48 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java > > Lines 70 (patched) > > > > > > nit: throw if defaultPoolName is still null here. > > Serge

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

2017-10-25 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/#review189249 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/QueryAllocationMan

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

2017-10-26 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/#review189373 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.jav

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-26 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63346/#review189384 --- metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql Lines 9

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

2017-10-27 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/#review189450 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.ja

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

2017-10-27 Thread j . prasanth . j
> On Oct. 25, 2017, 9:57 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > > Line 98 (original), 110 (patched) > > > > > > would be cleaner with executor service + threa

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

2017-10-27 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/#review189456 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

2017-10-27 Thread j . prasanth . j
> On Oct. 25, 2017, 9:57 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > > Lines 130 (patched) > > > > > > use notEmpty.awaitUninterruptibly() ? won't wake up for spur

  1   2   3   4   >