> On Oct. 17, 2017, 10:48 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java > > Lines 70 (patched) > > <https://reviews.apache.org/r/62706/diff/1/?file=1840587#file1840587line70> > > > > nit: throw if defaultPoolName is still null here. > > Sergey Shelukhin wrote: > Why? I actually wonder how this is going to work w.r.t. Tez. I think > default pool name might just mean Tez.
I was thinking default is only applicable for tez. For LLAP case where RP can have many pools and only one default pool I guess this is ok. For Tez case we could just name it 'default' or 'tez' - Prasanth_J ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62706/#review188406 ----------------------------------------------------------- On Oct. 18, 2017, 8:45 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62706/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2017, 8:45 p.m.) > > > Review request for hive, Zhiyuan Yang and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersWorkloadManager.java > 8485ba66c9 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > 4f2997b95b > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java > 54c7f74cb4 > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java > 17c62cf4fb > service/src/java/org/apache/hive/service/server/HiveServer2.java b121a0617d > > > Diff: https://reviews.apache.org/r/62706/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
