----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62706/#review188406 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java Lines 70 (patched) <https://reviews.apache.org/r/62706/#comment265398> nit: throw if defaultPoolName is still null here. ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java Lines 137 (patched) <https://reviews.apache.org/r/62706/#comment265399> should we do some validation here? To check for max depth of tree. May be we shouldn't allow >2 depth. Should we also add limits to how wide the tree can be. Or max children (cannot be greater than some fraction of executor count). ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java Line 126 (original), 225 (patched) <https://reviews.apache.org/r/62706/#comment265400> does this launch all sessions synchronously? should we make sure the created sessions are open and are not in accepted state? ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java Lines 329 (patched) <https://reviews.apache.org/r/62706/#comment265402> isn't this equivalent to sessionsClaimed.acquier()? blocked until acquire ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java Lines 337 (patched) <https://reviews.apache.org/r/62706/#comment265403> will this keep reacquiring readlock over and over? - Prasanth_J On Sept. 30, 2017, 12:57 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62706/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2017, 12:57 a.m.) > > > Review request for hive, Zhiyuan Yang and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > 4f2997b95b > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java > 3f621271cc > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java > 7adf895077 > service/src/java/org/apache/hive/service/server/HiveServer2.java 5cb973ca95 > > > Diff: https://reviews.apache.org/r/62706/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
