----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27599/#review60033 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsSetupConstants.java <https://reviews.apache.org/r/27599/#comment101370> Why is this limit required? The clients (StatsTask, FSOp) makes sure the stats key prefix is less than maxPrefixLength (defaults to 150). If it exceeds the prefix is MD5'ed to 17bytes. So the stats key prefix should never exceed 255 varchar default. ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java <https://reviews.apache.org/r/27599/#comment101372> Isn't it clients responsibility to do all these stuff? - Prasanth_J On Nov. 4, 2014, 11:56 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27599/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 11:56 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java > b074ca9 > ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java > 5e317ab > > ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsSetupConstants.java > 70badf2 > ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java > 4625d27 > > Diff: https://reviews.apache.org/r/27599/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
