/hadoop/hive/ql/io/parquet/TestMapredParquetOutputFormat.java
417676dee2ecfe34bffd3839562cc7e302687453
Diff: https://reviews.apache.org/r/26434/diff/
Testing
---
test on a local cluster
Thanks,
cheng xu
/TestFilterPredicateFactory.java
PRE-CREATION
Diff: https://reviews.apache.org/r/26968/diff/
Testing
---
local UT passed
Thanks,
cheng xu
7d05b4faab0d5292e5a857c61d3f7bd506842cec
Diff: https://reviews.apache.org/r/27027/diff/
Testing
---
test on local cluster
Thanks,
cheng xu
eviews.apache.org/r/27263/#comment99901>
TEST_NAME should be testTSV2Output instead.
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
<https://reviews.apache.org/r/27263/#comment99902>
The same as above.
ca
- cheng xu
On Oct. 28, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27263/#review58760
---
Ship it!
Thanks for clean up the test class. LGTM!
- cheng xu
/hive/service/cli/session/HiveSessionImpl.java
b39d64dbec7b7d4beb622ce72c86ed1c8264f042
Diff: https://reviews.apache.org/r/24986/diff/
Testing
---
Thanks,
cheng xu
/org/apache/hive/service/cli/session/HiveSessionImpl.java
bc0a02c1df7f9fdb848d5f078e94a663a579e571
Diff: https://reviews.apache.org/r/24986/diff/
Testing
---
Thanks,
cheng xu
bc0a02c1df7f9fdb848d5f078e94a663a579e571
Diff: https://reviews.apache.org/r/24986/diff/
Testing
---
Thanks,
cheng xu
AUX_CLASSPATH}
else
CLASSPATH=${CLASSPATH}:${AUX_CLASSPATH}
fi
- cheng
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24986/#review51436
/HiveSessionImpl.java
bc0a02c1df7f9fdb848d5f078e94a663a579e571
Diff: https://reviews.apache.org/r/24986/diff/
Testing
---
Thanks,
cheng xu
: https://reviews.apache.org/r/24986/diff/
Testing
---
Thanks,
cheng xu
://reviews.apache.org/r/24986/diff/
Testing
---
Thanks,
cheng xu
: add unit test case for line wrapping
Diffs
-
beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java
PRE-CREATION
Diff: https://reviews.apache.org/r/25288/diff/
Testing
---
UT
Thanks,
cheng xu
/AvroSerdeUtils.java
7c48e9bbe4e3844d9b91b790ff66ced2b0a823d7
Diff: https://reviews.apache.org/r/25332/diff/
Testing
---
UT
Thanks,
cheng xu
/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
0b5ef12bfa8464f8b007a7fe8b180b2b33a8
Diff: https://reviews.apache.org/r/24986/diff/
Testing
---
Thanks,
cheng xu
69545b046db06fd56f35a0da09d3d6960832484d
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java
7c48e9bbe4e3844d9b91b790ff66ced2b0a823d7
Diff: https://reviews.apache.org/r/25332/diff/
Testing
---
UT
Thanks,
cheng xu
ne by the editor or the console
other than hive beeline side. Am I right?
- cheng
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25288/#review52145
-------
/TestCSVSerde.java PRE-CREATION
Diff: https://reviews.apache.org/r/25468/diff/
Testing
---
Unit test
Thanks,
cheng xu
is is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25468/#review52688
---
On Sept. 9, 2014, 2:16 a.m., cheng xu wrote:
>
> ---
ata:
aa,bb
dd,cc
(4) select a from csv_table:
+-+--+
| a |
+-+--+
| aa |
| dd |
+-+--+
If I am missing anything, please help figure it out. Thanks!
- cheng
---
This is an automatically generated e-mail. To rep
To reply, visit:
https://reviews.apache.org/r/25468/#review52688
-------
On Sept. 9, 2014, 2:16 a.m., cheng xu wrote:
>
> ---
> This is an automaticall
<https://reviews.apache.org/r/25329/#comment93114>
Just a suggestion, you can use query test instead of unit test to avoid
some many assert statements.
- cheng xu
On Sept. 15, 2014, 11:29 a.m., Xiaomeng Huang wrote:
>
> -
--truncateTable option for beeline when cell value exceeds the console
length
Diffs
-
Diff: https://reviews.apache.org/r/23540/diff/
Testing
---
UT passed
Thanks,
cheng xu
https://reviews.apache.org/media/uploaded/files/2014/07/16/638c6539-499f-4455-8088-46dfd25c9310__HIVE-6928.patch
Thanks,
cheng xu
beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java b78b7ad
Diff: https://reviews.apache.org/r/23541/diff/
Testing
---
UT passed
Thanks,
cheng xu
/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
e79b129
service/src/java/org/apache/hive/service/cli/session/SessionManager.java
6650c05
Diff: https://reviews.apache.org/r/23602/diff/
Testing
---
test locally
Thanks,
cheng xu
---
test locally
Thanks,
cheng xu
/HiveSessionImpl.java
6a7ee7a
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
e79b129
service/src/java/org/apache/hive/service/cli/session/SessionManager.java
6650c05
Diff: https://reviews.apache.org/r/23602/diff/
Testing
---
test locally
Thanks,
cheng xu
/HiveSessionImpl.java
6a7ee7a
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
e79b129
service/src/java/org/apache/hive/service/cli/session/SessionManager.java
6650c05
Diff: https://reviews.apache.org/r/23602/diff/
Testing
---
test locally
Thanks,
cheng xu
/TestSessionGlobalInitFile.java
PRE-CREATION
Diff: https://reviews.apache.org/r/23671/diff/
Testing
---
Thanks,
cheng xu
/HiveSessionImpl.java
<https://reviews.apache.org/r/23602/#comment84400>
will this output be removed before check-in?
- cheng xu
On July 17, 2014, 6:30 a.m., cheng xu wrote:
>
> ---
> This is an automatically generated e-mail.
/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java
PRE-CREATION
Diff: https://reviews.apache.org/r/23671/diff/
Testing
---
Thanks,
cheng xu
/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java
PRE-CREATION
Diff: https://reviews.apache.org/r/23671/diff/
Testing
---
Thanks,
cheng xu
>
not blank line, it means deleting this line
- cheng
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23671/#review48103
-------
ssion/SessionManager.java
6650c053e2979eb9f61ce4f62ab5644f4ee44a05
service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java
PRE-CREATION
Diff: https://reviews.apache.org/r/23671/diff/
Testing
---
Thanks,
cheng xu
ssion/SessionManager.java
6650c053e2979eb9f61ce4f62ab5644f4ee44a05
service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java
PRE-CREATION
Diff: https://reviews.apache.org/r/23671/diff/
Testing
---
Thanks,
cheng xu
/diff/
Testing
---
Thanks,
cheng xu
/session/SessionManager.java
6650c053e2979eb9f61ce4f62ab5644f4ee44a05
service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java
PRE-CREATION
Diff: https://reviews.apache.org/r/23671/diff/
Testing
---
Thanks,
cheng xu
7853c3f38f3c3fb9ae0b9939c714f1dc940ba053
pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d
Diff: https://reviews.apache.org/r/23722/diff/
Testing
---
Thanks,
cheng xu
https://reviews.apache.org/r/23722/diff/
Testing
---
Thanks,
cheng xu
/SeparatedValuesOutputFormat.java
7853c3f38f3c3fb9ae0b9939c714f1dc940ba053
pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d
Diff: https://reviews.apache.org/r/23722/diff/
Testing (updated)
---
UT
Thanks,
cheng xu
://reviews.apache.org/r/23722/diff/
Testing
---
UT
Thanks,
cheng xu
Thanks,
cheng xu
/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
bd97aff5959fd9040fc0f0a1f6b782f2aa6f
pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d
Diff: https://reviews.apache.org/r/23799/diff/
Testing
---
Thanks,
cheng xu
390d062b8dc52dfa790c7351f3db44c1e0dd7e37
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
bd97aff5959fd9040fc0f0a1f6b782f2aa6f
pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d
Diff: https://reviews.apache.org/r/23799/diff/
Testing
---
Thanks,
cheng xu
Diff: https://reviews.apache.org/r/23799/diff/
Testing
---
Thanks,
cheng xu
/apache/hive/beeline/TestBeeLineWithArgs.java
bd97aff5959fd9040fc0f0a1f6b782f2aa6f
pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d
Diff: https://reviews.apache.org/r/23799/diff/
Testing
---
Thanks,
cheng xu
/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
bd97aff5959fd9040fc0f0a1f6b782f2aa6f
pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d
Diff: https://reviews.apache.org/r/23799/diff/
Testing
---
Thanks,
cheng xu
, "\001" delimiter may not be easy to fully
support just using SuperCSV. We can consider this in a new jira if a strong
need for it. Thanks very much for figuring it out.
- cheng
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23799/#revi
390d062b8dc52dfa790c7351f3db44c1e0dd7e37
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
bd97aff5959fd9040fc0f0a1f6b782f2aa6f
pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d
Diff: https://reviews.apache.org/r/23799/diff/
Testing
---
Thanks,
cheng xu
.java
bd97aff5959fd9040fc0f0a1f6b782f2aa6f
pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d
Diff: https://reviews.apache.org/r/23799/diff/
Testing
---
Thanks,
cheng xu
ve/beeline/TestBeeLineWithArgs.java
bd97aff5959fd9040fc0f0a1f6b782f2aa6f
pom.xml b3216e1ea4abcf692a933024d415754322210d59
Diff: https://reviews.apache.org/r/23799/diff/
Testing
---
Thanks,
cheng xu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23799/#review49698
---
On Aug. 6, 2014, 5:41 a.m., cheng xu wrote:
>
> ---
> This is an automat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24488/#review50008
---
Ship it!
Ship It!
- cheng xu
On Aug. 8, 2014, 2:39 a.m., Navis
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java
fcfcf4227610279090a867cdeeb36dbc3d13d902
Diff: https://reviews.apache.org/r/24597/diff/
Testing
---
Thanks,
cheng xu
/SessionStateTest-V1.jar PRE-CREATION
ql/src/test/resources/SessionStateTest-V2.jar PRE-CREATION
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
b39d64dbec7b7d4beb622ce72c86ed1c8264f042
Diff: https://reviews.apache.org/r/24986/diff/
Testing
---
Thanks,
cheng xu
automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26968/#review59500
-------
On Oct. 21, 2014, 8:13 a.m., cheng xu wrote:
>
> ---
> This is an automatically generat
che.org/r/27566/diff/
Testing
---
Thanks,
cheng xu
s.apache.org/r/27566/#review60674
---
On Nov. 4, 2014, 8:06 a.m., cheng xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
0
Diff: https://reviews.apache.org/r/27566/diff/
Testing
---
Thanks,
cheng xu
7664line53>
> >
> > Wow, this is not good. I created HIVE-8825 to fix catching Throwable.
> > Should be quick fix.
Let's do it in HIVE-8825 Once this patch ready.
- cheng
---
This is an
or.java dea3460
Diff: https://reviews.apache.org/r/27566/diff/
Testing
---
Thanks,
cheng xu
ed to
> > remove it from the top level license file. I filed HIVE-8826 to do that.
> > Should be an easy fix.
>
> cheng xu wrote:
> Thank Brock for your kind remind.
> (1) The original license to the top of the file added
> (2) JLine part is already added, does thi
che.org/r/27566/diff/
Testing
---
Thanks,
cheng xu
Testing
---
UT passed locally
Thanks,
cheng xu
0811
-------
On Nov. 12, 2014, 2:43 a.m., cheng xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27566/
> -
java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460
Diff: https://reviews.apache.org/r/27566/diff/
Testing
---
Thanks,
cheng xu
verMethods.java 88a37d5
hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6
pom.xml ec8c4fe
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460
Diff: https://reviews.apache.org/r/27566/diff/
Testing
---
Thanks,
cheng xu
diff/
Testing
---
Thanks,
cheng xu
6968/diff/4/?file=751469#file751469line765>
> >
> > Please add assert for leaf.getParquetType() everywhere we are checking
> > leaf.getOrcType()
No need anymore since reserve the previous implement for getType().
- cheng
--------
/PredicateLeaf.java 616c6db
serde/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java db0f014
Diff: https://reviews.apache.org/r/26968/diff/
Testing
---
local UT passed
Thanks,
cheng xu
db0f014
Diff: https://reviews.apache.org/r/26968/diff/
Testing
---
local UT passed
Thanks,
cheng xu
Correct ?
Yes, that's right!
- cheng
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26968/#review61668
---
On Nov. 15, 20
/PredicateLeaf.java 616c6db
serde/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java db0f014
Diff: https://reviews.apache.org/r/26968/diff/
Testing
---
local UT passed
Thanks,
cheng xu
/results/clientpositive/parquet_types.q.out 275897c
Diff: https://reviews.apache.org/r/28147/diff/
Testing
---
related UT and QL tests passed
Thanks,
cheng xu
tests passed
Thanks,
cheng xu
31d5c29
shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
2e00d93
shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
8161fc1
Diff: https://reviews.apache.org/r/28283/diff/
Testing
---
Thanks,
cheng xu
8161fc1
Diff: https://reviews.apache.org/r/28283/diff/
Testing
---
Thanks,
cheng xu
/parquet/TestParquetSerDe.java
8ac7864
ql/src/test/queries/clientpositive/parquet_types.q 22585c3
ql/src/test/results/clientpositive/parquet_types.q.out 275897c
Diff: https://reviews.apache.org/r/28147/diff/
Testing
---
related UT and QL tests passed
Thanks,
cheng xu
or checking cbinary
again.
- cheng
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28147/#review62744
---
On Nov. 21, 20
Thanks,
cheng xu
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28283/#review62626
-------
On Nov. 21, 2014, 2:30 a.m., cheng xu wrote:
>
>
: https://reviews.apache.org/r/28283/diff/
Testing
---
Thanks,
cheng xu
his is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28147/#review62822
---
On Nov. 24, 2014, 4:16 a.m., cheng xu wrote:
>
> ---
> This i
/clientpositive/parquet_types.q 22585c3
ql/src/test/results/clientpositive/parquet_types.q.out 275897c
Diff: https://reviews.apache.org/r/28147/diff/
Testing
---
related UT and QL tests passed
Thanks,
cheng xu
ey provider.
For java key provider, it stores the key into a file. And I digged into the
code and found that two key providers are trying to open the same key file and
one thread will not be awared of the changed key by another thread.
> On Dec. 1, 2014, 9:35 p.m., Se
fa66a4a
Diff: https://reviews.apache.org/r/28283/diff/
Testing
---
Thanks,
cheng xu
/Hadoop20SShims.java
2e00d93
shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
8161fc1
shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java
fa66a4a
Diff: https://reviews.apache.org/r/28283/diff/
Testing
---
Thanks,
cheng xu
comment106793>
Please the trim trailing spaces.
serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
<https://reviews.apache.org/r/28786/#comment106795>
Please the trim trailing spaces.
serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.j
-------
On Dec. 3, 2014, 1:02 a.m., cheng xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28283/
> ---
/28283/diff/
Testing
---
Thanks,
cheng xu
serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java
8cb2dc3
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java
cd5a0fa
Diff: https://reviews.apache.org/r/28933/diff/
Testing
---
Test passed for added cases
Thanks,
cheng xu
tps://reviews.apache.org/r/28936/#comment107513>
magic number
Thank Navis for your good catch and patch. I tested it locally and worked well
for the auto-complete of hive configurations. LGTM despite one minor issue.
- cheng xu
On Dec. 11, 2014, 7:36 a.m., Navis Ryu
p/hive/ql/io/TestHiveStoragePerformance.java
<https://reviews.apache.org/r/28964/#comment107611>
Can we output the size of file here or output the throughput of IO instead
like TestDFSIO?
Thank Sergio for your patch. Just one question below.
- cheng xu
On Dec. 11, 2014, 10:42 p.m.,
64857
-------
On Dec. 11, 2014, 5:57 a.m., cheng xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28933/
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28933/#review65039
-------
On Dec. 11, 2014, 5:57 a.m., cheng xu wrote:
>
> -
b2dc3
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java
cd5a0fa
Diff: https://reviews.apache.org/r/28933/diff/
Testing
---
Test passed for added cases
Thanks,
cheng xu
k/storage/ColumnarStorageBench.java
<https://reviews.apache.org/r/28964/#comment111627>
No need to break line here.
- cheng xu
On Jan. 9, 2015, 6:38 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-ma
/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java
<https://reviews.apache.org/r/28964/#comment112333>
trailing whitespace
- cheng xu
On Jan. 14, 2015, 11:48 p.m., Sergio Pena wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28964/#review68410
---
Ship it!
Ship It!
- cheng xu
On Jan. 15, 2015, 8:08 p.m
1 - 100 of 233 matches
Mail list logo
