> On Sept. 9, 2014, 8:49 a.m., Lars Francke wrote: > > Looks good apart from minor comments. > > > > Maybe add a test for the Serialization part? > > https://issues.apache.org/jira/browse/HIVE-5976 integration might be nice: > > "STORED AS CSV". Unfortunately there's no documentation yet so I'm not sure > > if it's feasible.
Good point! Why not file it in a new jira ticket as a future work? - cheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25468/#review52688 ----------------------------------------------------------- On Sept. 9, 2014, 2:16 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25468/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 2:16 a.m.) > > > Review request for hive. > > > Bugs: HIVE-7777 > https://issues.apache.org/jira/browse/HIVE-7777 > > > Repository: hive-git > > > Description > ------- > > HIVE-7777: add CSVSerde support > > > Diffs > ----- > > serde/pom.xml f8bcc830cfb298d739819db8fbaa2f98f221ccf3 > serde/src/java/org/apache/hadoop/hive/serde2/CSVSerde.java PRE-CREATION > serde/src/test/org/apache/hadoop/hive/serde2/TestCSVSerde.java PRE-CREATION > > Diff: https://reviews.apache.org/r/25468/diff/ > > > Testing > ------- > > Unit test > > > Thanks, > > cheng xu > >
