> On Dec. 14, 2014, 7:50 a.m., Mohit Sabharwal wrote: > > ql/src/test/results/clientpositive/avro_timestamp.q.out, line 101 > > <https://reviews.apache.org/r/28933/diff/1/?file=789140#file789140line101> > > > > Looks like we are truncating the timestamp from millis to nanos because > > Avro spec expects millis. > > > > Any idea why the precision for the partition timestamp column is > > printed in nanos whenever timestamp is in where clause ? > > > > Also maybe add another query in the test with millis in the where > > clause ? > > Mohit Sabharwal wrote: > Typo... I meant "truncating the timestamp from nanos to millis "
This following entry may be helpful. Timestamp is typically in the precision of millis. Do you think there is any special requirement to improve the precision for partition? For the test case, maybe we can use timestamp in the precision of millis instead to avoid confusing. See http://svn.apache.org/repos/asf/openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/TimestampHelper.java - cheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28933/#review65039 ----------------------------------------------------------- On Dec. 11, 2014, 5:57 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28933/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 5:57 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > The patch includes: > 1.add timestamp support for AvroSerde > 2.add related test cases > > > Diffs > ----- > > data/files/avro_timestamp.txt PRE-CREATION > ql/src/test/queries/clientpositive/avro_timestamp.q PRE-CREATION > ql/src/test/results/clientpositive/avro_timestamp.q.out PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java > 07c5ecf > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 7639a2b > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java > c8eac89 > serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java > c84b1a0 > serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java > 8cb2dc3 > serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java > cd5a0fa > > Diff: https://reviews.apache.org/r/28933/diff/ > > > Testing > ------- > > Test passed for added cases > > > Thanks, > > cheng xu > >
