> On Sept. 9, 2014, 3:07 p.m., Brock Noland wrote: > > serde/pom.xml, line 73 > > <https://reviews.apache.org/r/25468/diff/1/?file=683466#file683466line73> > > > > These should only be indented by two spaces, not four. Have you tried > > submitting an MR job on a cluster with this patch? The reason I ask is that > > I think the serde must be in here: > > > > https://github.com/apache/hive/blob/trunk/ql/pom.xml#L563 > > > > for it to be available to MR jobs.
I think it does not need to add the class alone because "org.apache.hive:hive-serde" was already included. BTW, I do a test as the following steps: (1) create a table with the csv format: create table csv_table(a string, b string) row format serde 'org.apache.hadoop.hive.serde2.OpenCSVSerde' WITH SERDEPROPERTIES( "separatorChar" = ",", "quoteChar" = "'", "escapeChar" = "\" ) stored as textfile; (2) load data by: load data local inpath "/root/workspace/data" overwrite into table csv_table; (3) cat /root/workspace/data: aa,bb dd,cc (4) select a from csv_table: +-----+--+ | a | +-----+--+ | aa | | dd | +-----+--+ If I am missing anything, please help figure it out. Thanks! - cheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25468/#review52723 ----------------------------------------------------------- On Sept. 9, 2014, 2:16 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25468/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 2:16 a.m.) > > > Review request for hive. > > > Bugs: HIVE-7777 > https://issues.apache.org/jira/browse/HIVE-7777 > > > Repository: hive-git > > > Description > ------- > > HIVE-7777: add CSVSerde support > > > Diffs > ----- > > serde/pom.xml f8bcc830cfb298d739819db8fbaa2f98f221ccf3 > serde/src/java/org/apache/hadoop/hive/serde2/CSVSerde.java PRE-CREATION > serde/src/test/org/apache/hadoop/hive/serde2/TestCSVSerde.java PRE-CREATION > > Diff: https://reviews.apache.org/r/25468/diff/ > > > Testing > ------- > > Unit test > > > Thanks, > > cheng xu > >
