m the system ;any
configuration needed to be set to enable deletion or Is there any design
strategy/decision/rationale for not deleting them at all?
Also, in these files I don't see the session end message being logged, is it
reserved for future use?
ereas, If I run the same queries/commands in CLI mode, I get exception
saying /home/grade.jar does not exists or /home/temp.zip does not exists
etc.
Is there any defect logged for same ?
-Mohit
***
perty hive.querylog.location
by adding into hive-default.xml. I will comment on that.
-Mohit
***
This e-mail and attachments contain confidential information from HUAWEI,
which is intended only for the person or e
Sent: Wednesday, January 05, 2011 12:42 PM
To: mohitsi...@huawei.com
Cc: dev@hive.apache.org; hive-...@hadoop.apache.org; edlinuxg...@gmail.com
Subject: Re: Regarding Hive History File(s).
Hi Mohit,
Usually it's the Ops/IT staff that ends up managing things like a production
HiveServer instan
thread named logCleanupThread.
We can extend the same feature in Hive as well, or if we can't; you might
help us enlighten.
-Mohit
***
This e-mail and attachments contain confidential information
uery being mentioned in test case for
this defect.
LOAD DATA LOCAL INPATH '/home/test/kv2.txt' INTO TABLE tst_src1;
Kindly confirm, if I'm doing anything wrong or it is known(and fixed) or it
is really a
TITION (dt='23-02-2010',country='UK');
but it doesn't results in any exception, I'm getting OK response on console.
As per this defect fix, it should actually fail with console error message
Partition : [{dt='23-02-
way (including,
but not limited to, total or partial disclosure, reproduction, or
dissemination) by persons other than the intended recipient's) is
prohibited. If you receive this e-mail in error, please notify the sender by
phone or email immediately and delete it!
_
From:
Thanks Carl, will surely file a bug.
Right Carl; agreed; test case(s) not required, well actually I was looking
out for queries which He Yongqiang used locally to test it.
Just to ensure that we are in sync regarding this defect, because defect
description is somewhat vague.
-Mohit
the pointers to re-produce it's side effect, It will
be great.
-Mohit
***
This e-mail and attachments contain confidential information from HUAWEI,
which is intended only for the person or entity
, so I was wondering how the code change helped preventing client
hang?
Thanks and Regards,
-Mohit
ng the latest operation (and not the first
operation) in the session.
- Mohit Sabharwal
On Oct. 3, 2014, 12:02 a.m., Brock Noland wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26299/#review55366
---
Ship it!
Ship It!
- Mohit Sabharwal
On Oct. 3, 2014, 5:24 p.m
4f6dad4909be9a29ef5a92addda9e674a28606e9
Diff: https://reviews.apache.org/r/26385/diff/
Testing
---
Added unit test
Thanks,
Mohit Sabharwal
/hive/ql/parse/HiveSemanticAnalyzerHookContextImpl.java
4f6dad4909be9a29ef5a92addda9e674a28606e9
Diff: https://reviews.apache.org/r/26385/diff/
Testing
---
Added unit test
Thanks,
Mohit Sabharwal
-HIVE-5700.postgres.sql
aedb2b5dbf9b513cb7c124f59e05ea9831455a72
Diff: https://reviews.apache.org/r/26403/diff/
Testing
---
Added unit test
Thanks,
Mohit Sabharwal
e27ead312a68d30d94802095f2c60
Diff: https://reviews.apache.org/r/26403/diff/
Testing
---
Added unit test
Thanks,
Mohit Sabharwal
://reviews.apache.org/r/26515/diff/
Testing
---
Added unit test
Thanks,
Mohit Sabharwal
---
Added unit test
Thanks,
Mohit Sabharwal
adoop/hive/shims/HadoopShims.java
d56795f7be1cffa13ea7b3ea2cd50db90730c020
Diff: https://reviews.apache.org/r/26515/diff/
Testing
---
Added unit test
Thanks,
Mohit Sabharwal
ead312a68d30d94802095f2c60
Diff: https://reviews.apache.org/r/26403/diff/
Testing
---
Added unit test
Thanks,
Mohit Sabharwal
che/hadoop/hive/ql/parse/RowResolver.java
<https://reviews.apache.org/r/26577/#comment96633>
same
- Mohit Sabharwal
On Oct. 11, 2014, 8:11 a.m., Lars Francke wrote:
>
> ---
> This is an
/apache/hadoop/hive/shims/HadoopShims.java
d56795f7be1cffa13ea7b3ea2cd50db90730c020
Diff: https://reviews.apache.org/r/26515/diff/
Testing
---
Added unit test
Thanks,
Mohit Sabharwal
/hadoop/hive/shims/HadoopShims.java
d56795f7be1cffa13ea7b3ea2cd50db90730c020
Diff: https://reviews.apache.org/r/26515/diff/
Testing
---
Added unit test
Thanks,
Mohit Sabharwal
test to verify build name is correctly extracted.
Thanks,
Mohit Sabharwal
: https://reviews.apache.org/r/26988/diff/
Testing
---
Added unit test that issues async execute statements and follows
it up with getJobID calls.
Did not add to ThriftCLIServiceTest since test needs a miniMR cluster
to run jobs that generate jobIDs.
Thanks,
Mohit Sabharwal
e25450531a71ef4ae4c6d9ea1788e618189a17cb
Diff: https://reviews.apache.org/r/27177/diff/
Testing
---
Manually verified explain output is printed on few create, alter, load and
select queries.
Thanks,
Mohit Sabharwal
he.org/r/27292/#comment100024>
nit: "Failed to load queue allocations file"
- Mohit Sabharwal
On Oct. 28, 2014, 5:48 p.m., Prasad Mujumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
hose details from the calling
> > method. Does that answer the question ?
> >
> > - yes, we don't really need to protect the config. The AtomicReference
> > it just a workaround to retriev the refernced object to a nested block
Thanks! LGTM.
- Mohit
-test
Thanks,
Mohit Sabharwal
ff114c04f396fa3b51aa6c065ae019dac2db3a81
Diff: https://reviews.apache.org/r/25086/diff/
Testing
---
Added q-test
Thanks,
Mohit Sabharwal
Diff: https://reviews.apache.org/r/25086/diff/
Testing
---
Added q-test
Thanks,
Mohit Sabharwal
Reg. disabling merge commits, if Apache is ok installing git server-side
hook scripts, setting up a pre-receive hook could be a possible option:
http://stackoverflow.com/questions/2039773/have-remote-git-repository-refuse-merge-commits-on-push
On Wed, Sep 17, 2014 at 10:56 AM, Sergey Shelukhin
5d6401058bdd993
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java
28c9080660b9d4c19789ece1754ef4ecec27f2e7
Diff: https://reviews.apache.org/r/25871/diff/
Testing
---
Thanks,
Mohit Sabharwal
/TypeInfoToSchema.java
4169558a8467e569bf5adc2433e640c9589d3452
Diff: https://reviews.apache.org/r/25907/diff/
Testing
---
Add q-test.
Thanks,
Mohit Sabharwal
rcharObjectInspector.java
28c9080660b9d4c19789ece1754ef4ecec27f2e7
Diff: https://reviews.apache.org/r/25871/diff/
Testing
---
Thanks,
Mohit Sabharwal
0f53e31d32137be89c6e7d0bcdc1b184c0964ad9
serde/src/test/resources/avro-struct.avsc
c8c83d777ca6088723e6f1e5cd6e6547bc6a9bc3
Diff: https://reviews.apache.org/r/25907/diff/
Testing
---
Add q-test.
Thanks,
Mohit Sabharwal
truct.avsc
007e6c2838bfcc1c345ce3cd590f74e30fb2e8b1
Diff: https://reviews.apache.org/r/26112/diff/
Testing
---
Added q-test.
Thanks,
Mohit Sabharwal
, varchar in TestHiveSchemaConverter
- Removed char, varchar negative q-test files.
Thanks,
Mohit Sabharwal
e efficiency, and also can we use
> > Guava's Iterables to make this logic cleaner?
Changed to set. However, couldn't really see a way to make the logic cleaner
using Iterables (like removeAll with a predicate), since we need the index from
,
Mohit Sabharwal
/ShimLoader.java
<https://reviews.apache.org/r/27460/#comment100906>
missing trailing 'S'
shims/common/src/main/java/org/apache/hadoop/hive/shims/ShimLoader.java
<https://reviews.apache.org/r/27460/#comment100907>
missing trailing 'S'
- Mohit Sabha
va/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/27566/#comment102692>
confCompleter
hcatalog/hcatalog-pig-adapter/pom.xml
<https://reviews.apache.org/r/27566/#comment102695>
2.12 ?
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/T
etween
getOrcLiteral() and getParquetLiteral().
serde/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java
<https://reviews.apache.org/r/26968/#comment102792>
ORC -> parquet
- Mohit Sabharwal
On Oct. 21, 2014, 8:13 a.m., cheng xu wrote:
>
> --
" + e, e);
ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java
<https://reviews.apache.org/r/26968/#comment103460>
Should we add one for date, decimal and timestamp ? -- ones we don't
support currently -- just to make
566/#comment103666>
Please remove the word "contains". It's not part of the license.
beeline/src/java/org/apache/hive/beeline/BeeLine.java
<https://reviews.apache.org/r/27566/#comment103668>
move import up in jline section
- Mohit Sabharwal
On Nov. 13, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26968/#review61847
---
Ship it!
Thanks for making the changes!
- Mohit Sabharwal
On
is a great one.
- Mohit Sabharwal
On Nov. 18, 2014, 1:58 a.m., cheng xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28147/#review62133
---
Ship it!
Ship It!
- Mohit Sabharwal
On Nov. 19, 2014, 2:01 a.m
/localhost:1 -n user -p TestPassword --debug
Thanks,
Mohit Sabharwal
er. This way the user name format can be managed by
> > individual authentication handlers rather than high level HS2 RPC processor.
Thanks!, filed follow up JIRA HIVE-8928 to explore Prasad's and Szehon's
suggestions.
- Mohit
ELECT cchar, LENGTH(cchar), cvarchar, LENGTH(cvarchar), cbinary FROM
parquet_types
Or you can pass it through hex() if original data has unprintable
characters:
SELECT cchar, LENGTH(cchar), cvarchar, LENGTH(cvarchar), hex(cbinary) FROM
parquet_types
- Mohit Sabharwal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28147/#review62754
---
Ship it!
Thanks for the changes!
- Mohit Sabharwal
On Nov. 24
/Driver.java
<https://reviews.apache.org/r/26966/#comment107120>
nit: while we're here, this code will be cleaner if we replace the many
continues with bunch of else if {} blocks or, better, a switch {}
- Mohit Sabharwal
On Oct. 21, 2014, 6:55 a.m., Navi
/LoadSemanticAnalyzer.java
<https://reviews.apache.org/r/26966/#comment107141>
Looks like FileUtils.isLocalFile is a 'best effort' check based on URI
format. So probably better to just trust the user ?
- Mohit Sabharwal
On Oct. 21, 2014, 6:55 a.m.,
rg/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java
<https://reviews.apache.org/r/28933/#comment107974>
"Test for timestamp" instead of "Test for date"
- Mohit Sabharwal
On Dec. 11, 2014, 5:57 a.m., cheng xu wrote:
>
> -
> On Dec. 14, 2014, 7:50 a.m., Mohit Sabharwal wrote:
> > ql/src/test/results/clientpositive/avro_timestamp.q.out, line 101
> > <https://reviews.apache.org/r/28933/diff/1/?file=789140#file789140line101>
> >
> > Looks like we are truncating the timestamp from
c/test/results/clientpositive/varchar_udf1.q.java8.out PRE-CREATION
ql/src/test/results/clientpositive/varchar_udf1.q.out
842bd38cb5070994df3a264cc691372384433ae3
Diff: https://reviews.apache.org/r/29061/diff/
Testing
---
Tested using varchar_udf1.q.
Out file changes for this test are included in the patch
Thanks,
Mohit Sabharwal
5070994df3a264cc691372384433ae3
Diff: https://reviews.apache.org/r/29061/diff/
Testing
---
Tested using varchar_udf1.q.
Out file changes for this test are included in the patch
Thanks,
Mohit Sabharwal
691372384433ae3
Diff: https://reviews.apache.org/r/29061/diff/
Testing
---
Tested using varchar_udf1.q.
Out file changes for this test are included in the patch
Thanks,
Mohit Sabharwal
the JIRA as
well?
- Mohit Sabharwal
On Dec. 16, 2014, 3:40 a.m., cheng xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
this patch pass for both Java 7 and Java 8
Thanks,
Mohit Sabharwal
Diff: https://reviews.apache.org/r/29325/diff/
Testing
---
Tests pass for both Java 7 and Java 8
Thanks,
Mohit Sabharwal
: https://reviews.apache.org/r/29382/diff/
Testing
---
Tests pass on Java 8 and Java 7
Thanks,
Mohit Sabharwal
/test/results/clientpositive/stats_list_bucket.q.java1.8.out
80a0f9c8683eb527c05854a38b1f6f03d48dd467
Diff: https://reviews.apache.org/r/29465/diff/
Testing
---
Tested with Java 8 and Java 7.
Thanks,
Mohit Sabharwal
a0449aa39f8fc7960fe42680781a9f5ba01d42b8
Diff: https://reviews.apache.org/r/29520/diff/
Testing
---
Tested with both Java 7 and Java 8
Thanks,
Mohit Sabharwal
l.java
9ae9bc0a267e41a852aa6f87bab532763f9c54b3
Diff: https://reviews.apache.org/r/29702/diff/
Testing
---
Added unit test
Thanks,
Mohit Sabharwal
etastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java
<https://reviews.apache.org/r/29807/#comment118095>
please use
HiveConf.ConfVars.METASTORE_SERVER_LONG_RUNNING_METHOD_TIMEOUT.varname
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.
ddressed in the unit tests.
Also, could you explain/add comment about why last day of the month is
significant. Shouldn't we be computing denominator based on getAcutalMaximum of
the two dates instead of a fixed "31" or is that the Oracle behaviour ?
- Mohit Sabharwal
O
to deal with nested fields).
Can we have duplicate column names across nesting levels ?
ql/src/test/queries/clientpositive/parquet_schema_evolution.q
<https://reviews.apache.org/r/32499/#comment126280>
Add a case where structs are nested (struct inside scruct) ?
- Mohit Sabharwal
On
STRING_GROUP ?
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java
<https://reviews.apache.org/r/32489/#comment126505>
19...a comment on where this comes from would be great
- Mohit Sabharwal
On March 27, 2015, 12:58 a.m., Alexand
u want to return null for dataStr.length() >
10 ?
As it stands now, long date+time string will get converted using:
Object writableValue = converters[i].convert(obj);
Timestamp ts = ((TimestampWritable) writableValue).getTimestamp();
return ts;
Is th
/GenericUDFMonthsBetween.java
<https://reviews.apache.org/r/32489/#comment127019>
nit: cleaner to just say (31 * 24 * 60 * 60)
- Mohit Sabharwal
On March 31, 2015, 8:08 p.m., Alexander Pivovarov wrote:
>
> ---
> This is an automatica
che.org/r/54393/#comment229110>
throw RuntimeException
- Mohit Sabharwal
On Dec. 6, 2016, 8:13 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
.org/r/56687/#comment238763>
what about this ?
- Mohit Sabharwal
On Feb. 23, 2017, 9:01 p.m., Misha Dmitriev wrote:
>
> ---
> This is an automatically generated
+1
On Tue, Feb 28, 2017 at 11:12 AM, Thejas Nair wrote:
> Note that upgrading the minimum required version to JDK8 also gives Hive
> the option of using more recent versions of several libraries including
> hikaricp (as default connection pool option) [1] and jetty [2]
>
> [1] https://issues.a
st-wise the branch (listeners != null) is expensive, so let's not do
it twice.
- Mohit Sabharwal
On March 17, 2017, 8:14 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically genera
> On March 17, 2017, 10:34 p.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListenerNotifier.java
> > Lines 138 (patched)
> > <https://reviews.apache.org/r/57626/diff/2/?file=1666420#file1666420line138>
> >
> >
ch makes it brittle.
- Mohit Sabharwal
On March 20, 2017, 10:33 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
time a new items is added.
As I said, you can simply add a new method called
getunmodifiableParameters() which returns
Collections.unmodifiableMap(parameters) without the need for this copy.
- Mohit Sabharwal
On March 28, 2017, 3:17 p.m., Sergio Pena wrote:
>
> -
> On March 30, 2017, 1:54 p.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java
> > Lines 51-52 (patched)
> > <https://reviews.apache.org/r/57626/diff/6/?file=1677663#file1677663line51>
> >
> >
> On March 30, 2017, 1:54 p.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java
> > Lines 51-52 (patched)
> > <https://reviews.apache.org/r/57626/diff/6/?file=1677663#file1677663line51>
> >
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57626/#review170943
---
Ship it!
Ship It!
- Mohit Sabharwal
On April 3, 2017, 10:34
217>
For clarity, move this to finally() inside cleanupRawStore(), so that all
thread local cleanup is captured in one place as
HMSHandler.threadLocalModifiedMetaConfKeys.remove().
- Mohit Sabharwal
On July 18, 2017, 10:
LocalModifiedConfig is non null before calling
notifyMetaListenersOnShutDown
- Mohit Sabharwal
On July 19, 2017, 7:40 a.m., PRASHANT GOLASH wrote:
>
> ---
> This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/#review181012
---
Ship it!
Ship It!
- Mohit Sabharwal
On July 20, 2017, 12:39
/listener/TestTransactionalDbNotificationListener.java
PRE-CREATION
Diff: https://reviews.apache.org/r/61244/diff/1/
Testing
---
Thanks,
Mohit Sabharwal
,
Mohit Sabharwal
estNegativeSparkCliDriver -Phadoop-2 -Dqfile=$line
-Dtest.output.overwrite=true; done
Thanks,
Mohit Sabharwal
operation/OperationManager.java
(line 65)
<https://reviews.apache.org/r/40500/#comment166342>
any reason we only want sqloperations ?
- Mohit Sabharwal
On Nov. 19, 2015, 8:53 p.m., Jimmy Xiang wrote:
>
> ---
> This is an automa
> On Nov. 20, 2015, 4:53 a.m., Mohit Sabharwal wrote:
> > LGTM. This patch only includes SQLOperations. Are we planning to add
> > metadata operations as well ? (so we can capture jdbc clients and Hue usage
> > as well...)
>
> Jimmy Xiang wrote:
> Than
these public ... only accessed in this class.
service/src/java/org/apache/hive/service/cli/operation/Operation.java (line 87)
<https://reviews.apache.org/r/40549/#comment166497>
is this conditional needed ?
- Mohit Sabharwal
On Nov. 20, 2015, 4:56 p.
> On Nov. 20, 2015, 7:30 p.m., Mohit Sabharwal wrote:
> > service/src/java/org/apache/hive/service/cli/operation/Operation.java, line
> > 56
> > <https://reviews.apache.org/r/40549/diff/1/?file=1134612#file1134612line56>
> >
> > what does MDC stand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40549/#review107416
---
Ship it!
Ship It!
- Mohit Sabharwal
On Nov. 20, 2015, 8:39 p.m
s.apache.org/r/40833/#comment168071>
Any reason why it shouldn't just default to what's specified in
HiveConf.HIVE_SERVER2_WEBUI_MAX_THREADS (which is 50) ?
- Mohit Sabharwal
On Dec. 1, 2015, 6:50 p.m., Jimmy Xiang wrote:
>
> ---
/java/org/apache/hive/http/HttpServer.java (line 274)
<https://reviews.apache.org/r/40833/#comment168177>
(!b.useSSL) ?
- Mohit Sabharwal
On Dec. 2, 2015, 8:09 p.m., Jimmy Xiang wrote:
>
> ---
> This is an automatica
/40898/diff/
Testing
---
TestEmbeddedThriftBinaryCLIService#testGlobalCompileLockTimeout
Thanks,
Mohit Sabharwal
d90002bd16e46b5ce970d4c6c544a9c7605328d1
Diff: https://reviews.apache.org/r/40898/diff/
Testing
---
TestEmbeddedThriftBinaryCLIService#testGlobalCompileLockTimeout
Thanks,
Mohit Sabharwal
Lenni Kuff wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 1280
> > <https://reviews.apache.org/r/40898/diff/2/?file=1152869#file1152869line1280>
> >
> > Can we include the query text here?
Done.
- Mohit
--
/CLIServiceTest.java
d90002bd16e46b5ce970d4c6c544a9c7605328d1
Diff: https://reviews.apache.org/r/40898/diff/
Testing
---
TestEmbeddedThriftBinaryCLIService#testGlobalCompileLockTimeout
Thanks,
Mohit Sabharwal
1 - 100 of 368 matches
Mail list logo
