-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29285/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-9181
https://issues.apache.org/jira/browse/HIVE-9181
Repository: hive-git
Description
-------
HIVE-9181 : Fix SkewJoinOptimizer related Java 8 ordering differences
(1) SkewJoinOptimizer adds items to ParseContext.topOps is different order in
Java 8 vs Java 7. This leads to differences in EXPLAIN output related to
MapWork.
(2) Dbproperties order for a "desc database" query is non-deterministic at the
HiveMetastore end between Java 8 and Java 7 (because Thrift maps are
un-ordered).
At client side, we serialize the dbproperties map returned from HMS as string
and write it to a temp file. The FetchTask then reads the temp file and returns
the string back to the user. In test environment, for consistent ordering, we
should sort the map before it is serialized to the temp file.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
c0c1e4d661f6aafd3bbcb7de50c0aadd4952d5c5
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java
84fc1c1bfbfbaf3382ed437e9e1fdc0b981a5d2a
ql/src/test/results/clientpositive/describe_database.q.out
f2f05335d31f47facc6d408bc329c8b44258a5ba
ql/src/test/results/clientpositive/quotedid_skew.q.out
782a4dbd6670ae954bf9ed2981725f155f041e8a
ql/src/test/results/clientpositive/skewjoin_mapjoin2.q.out
d424d8358d44abec0ecdad3b7900293cb7c24b9e
ql/src/test/results/clientpositive/skewjoin_union_remove_1.q.out
7b261ea29c3e253751e2fa9bfe0b120fd0b24ed8
ql/src/test/results/clientpositive/skewjoin_union_remove_2.q.out
161397655a573590564688574b112c7bfb2386cd
ql/src/test/results/clientpositive/skewjoinopt1.q.out
6f21dfb43a0924061884facb191d35fe9f864156
ql/src/test/results/clientpositive/skewjoinopt10.q.out
4ade62c5eb93268f29174d8e5cbde869281ffbd8
ql/src/test/results/clientpositive/skewjoinopt11.q.out
3d9f0685658e74fcc03845b5dee325edbd58b02a
ql/src/test/results/clientpositive/skewjoinopt12.q.out
18bf649d4d90f0ad0a2dd84cea7528419581e4c9
ql/src/test/results/clientpositive/skewjoinopt14.q.out
5659ff21e2cb6255dd15d66aea08fc8361c1db59
ql/src/test/results/clientpositive/skewjoinopt15.q.out
c448ab5c477627e774fbe138bc834f1949f1b44a
ql/src/test/results/clientpositive/skewjoinopt16.q.out
631463bb7660b8864b0db0b770f28c8de5bc1433
ql/src/test/results/clientpositive/skewjoinopt17.q.out
f7d032013f4998bce77698dc2c214e3a3f57609c
ql/src/test/results/clientpositive/skewjoinopt19.q.out
bb01e875f33b515fced4f0e3eee969dd66ea6afb
ql/src/test/results/clientpositive/skewjoinopt2.q.out
9c7072cde854d9359733ad4d7fba525ea7380193
ql/src/test/results/clientpositive/skewjoinopt20.q.out
8b2e2cbb7abd91dd4720c52bd7fcc321b813b622
ql/src/test/results/clientpositive/skewjoinopt3.q.out
27b01200b1ee3b3e0702dae37a689ceeeb90c8ae
ql/src/test/results/clientpositive/skewjoinopt4.q.out
b40995c28ee8feb5ec1a5caa508ce14afee9c2fe
ql/src/test/results/clientpositive/skewjoinopt5.q.out
85d280ab5093b4156ce28be781e53478a5736521
ql/src/test/results/clientpositive/skewjoinopt6.q.out
00e1b9b012386485d3b798f8e6f906912e7d0f36
ql/src/test/results/clientpositive/skewjoinopt7.q.out
564411e45b00e857f1151105318b2252fbc36ca1
ql/src/test/results/clientpositive/skewjoinopt8.q.out
d5439fd940df715582a7ac37f7d1add7645e7eed
Diff: https://reviews.apache.org/r/29285/diff/
Testing
-------
Tests in this patch pass for both Java 7 and Java 8
Thanks,
Mohit Sabharwal
