Re: Review Request 62706: HIVE-17473 implement workload management pools

2017-10-18 Thread j . prasanth . j
> On Oct. 17, 2017, 10:48 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java > > Lines 70 (patched) > > > > > > nit: throw if defaultPoolName is still null here. > > Serge

Re: Review Request 62706: HIVE-17473 implement workload management pools

2017-10-18 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62706/ --- (Updated Oct. 18, 2017, 8:45 p.m.) Review request for hive, Zhiyuan Yang and Pr

Re: Review Request 62706: HIVE-17473 implement workload management pools

2017-10-18 Thread Sergey Shelukhin
> On Oct. 11, 2017, 9:31 p.m., Zhiyuan Yang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java > > Lines 250 (patched) > > > > > > Why add up parallelism of parent node with children node?

Re: Review Request 62706: HIVE-17473 implement workload management pools

2017-10-18 Thread Sergey Shelukhin
> On Oct. 17, 2017, 10:48 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java > > Lines 70 (patched) > > > > > > nit: throw if defaultPoolName is still null here. Why? I ac

Re: Review Request 62706: HIVE-17473 implement workload management pools

2017-10-17 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62706/#review188406 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.ja

Re: Review Request 62706: HIVE-17473 implement workload management pools

2017-10-11 Thread Zhiyuan Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62706/#review187692 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.ja

Review Request 62706: HIVE-17473 implement workload management pools

2017-09-29 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62706/ --- Review request for hive, Zhiyuan Yang and Prasanth_J. Repository: hive-git De