----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62706/#review187692 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java Lines 250 (patched) <https://reviews.apache.org/r/62706/#comment264747> Why add up parallelism of parent node with children node? Shouldn't parent's paralleism be a sum of children's? ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java Lines 275 (patched) <https://reviews.apache.org/r/62706/#comment264753> This piece get really complicated right now. I think there is good chance this can be prettier. Are you going you rewrite this (as you mentioned in jira)? ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java Lines 322 (patched) <https://reviews.apache.org/r/62706/#comment264739> unreachable statement? ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java Lines 243 (patched) <https://reviews.apache.org/r/62706/#comment264751> Why can user use non-leaf queue? The fact that sum of sub-queue can be less than parent queue's resource looks weird. Is this by design? - Zhiyuan Yang On Sept. 30, 2017, 12:57 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62706/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2017, 12:57 a.m.) > > > Review request for hive, Zhiyuan Yang and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > 4f2997b95b > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java > 3f621271cc > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java > 7adf895077 > service/src/java/org/apache/hive/service/server/HiveServer2.java 5cb973ca95 > > > Diff: https://reviews.apache.org/r/62706/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
