://reviews.apache.org/r/68959/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68889/#review209181
---
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 3, 2018, 5
Diff: https://reviews.apache.org/r/68664/diff/3/
Changes: https://reviews.apache.org/r/68664/diff/2-3/
Testing
---
Thanks,
Alexander Kolbasov
6 (original), 883 (patched)
<https://reviews.apache.org/r/68889/#comment293460>
It is better to join using Path or FIle methods.
- Alexander Kolbasov
On Oct. 2, 2018, 9:55 p.m., Bharathkrishna Guruvayoor Murali wrote:
>
> ---
f/1-2/
Testing
---
Thanks,
Alexander Kolbasov
Diff: https://reviews.apache.org/r/68900/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68664/#review208866
---
On Sept. 20, 2018, 9:46 p.m., Alexander Kolbasov wr
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68828/#review209064
---
Ship it!
Ship It!
- Alexander Kolbasov
On Sept. 24, 2018, 8
store-server/src/test/java/org/apache/hadoop/hive/common/TestMetaStoreUtils.java
Lines 44 (patched)
<https://reviews.apache.org/r/68827/#comment293322>
It would be better to use hamcrest asserts and just check that you map
matches your expected map with a single assert.
- Alexander Kolbasov
On Sep
right of the
review board.
- Alexander Kolbasov
On Sept. 24, 2018, 8:37 p.m., Bharathkrishna Guruvayoor Murali wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
assed to the
listener?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
Line 746 (original), 746 (patched)
<https://reviews.apache.org/r/68828/#comment293306>
Looks like formatting is off here
- Alexander Kolbasov
On Sept.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68765/#review208776
---
Ship it!
Ship It!
- Alexander Kolbasov
On Sept. 19, 2018, 9
Alexander Kolbasov created HIVE-20589:
-
Summary: Collect metrics for HMS notifications
Key: HIVE-20589
URL: https://issues.apache.org/jira/browse/HIVE-20589
Project: Hive
Issue Type: Bug
Alexander Kolbasov created HIVE-20564:
-
Summary: Remove Hive Server dependency on Metastore Server
Key: HIVE-20564
URL: https://issues.apache.org/jira/browse/HIVE-20564
Project: Hive
: https://reviews.apache.org/r/68664/diff/2/
Changes: https://reviews.apache.org/r/68664/diff/1-2/
Testing
---
Thanks,
Alexander Kolbasov
PRE-CREATION
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java
30de1c4cfa1cf019186b10583a06da0bf5491634
Diff: https://reviews.apache.org/r/68664/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
,
Alexander Kolbasov
/hadoop/hive/metastore/utils/SecurityUtils.java
Diff: https://reviews.apache.org/r/68552/diff/2/
Changes: https://reviews.apache.org/r/68552/diff/1-2/
Testing
---
Thanks,
Alexander Kolbasov
Alexander Kolbasov created HIVE-20492:
-
Summary: Failing test [est_teradatabinaryfile
Key: HIVE-20492
URL: https://issues.apache.org/jira/browse/HIVE-20492
Project: Hive
Issue Type: Bug
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68571/#review208158
---
Ship it!
Ship It!
- Alexander Kolbasov
On Aug. 30, 2018, 7
a
Line 1676 (original), 1676 (patched)
<https://reviews.apache.org/r/68571/#comment291925>
It is better to use {} interpolation in logs:
`LOG.info("Deleted {} obsolete rows from WRITE_SET", delCnt)`
- Alexander Kolbasov
On Aug. 30, 2018, 4:37 p.m., Ka
-metastore/src/assembly/src.xml PRE-CREATION
Diff: https://reviews.apache.org/r/68509/diff/4/
Changes: https://reviews.apache.org/r/68509/diff/3-4/
Testing
---
Thanks,
Alexander Kolbasov
/MetaStoreUtils.java
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/SecurityUtils.java
Diff: https://reviews.apache.org/r/68552/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
Alexander Kolbasov created HIVE-20483:
-
Summary: Really move metastore common classes into metastore-common
Key: HIVE-20483
URL: https://issues.apache.org/jira/browse/HIVE-20483
Project: Hive
Alexander Kolbasov created HIVE-20482:
-
Summary: Remove dependency on metastore-server
Key: HIVE-20482
URL: https://issues.apache.org/jira/browse/HIVE-20482
Project: Hive
Issue Type: Sub
-metastore/pom.xml ee3daed92a8d2e8f6d43957cb2358b285c24065c
standalone-metastore/src/assembly/src.xml PRE-CREATION
Diff: https://reviews.apache.org/r/68509/diff/3/
Changes: https://reviews.apache.org/r/68509/diff/2-3/
Testing
---
Thanks,
Alexander Kolbasov
store/src/assembly/src.xml PRE-CREATION
Diff: https://reviews.apache.org/r/68509/diff/2/
Changes: https://reviews.apache.org/r/68509/diff/1-2/
Testing
---
Thanks,
Alexander Kolbasov
g/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
Lines 1209 (patched)
<https://reviews.apache.org/r/68395/#comment291744>
Hmm, this looks suspicious. Objects can have the same hash code and be
non-equal - shouldn't you compare va
/
Testing
---
Thanks,
Alexander Kolbasov
://reviews.apache.org/r/68351/diff/2-3/
Testing
---
Thanks,
Alexander Kolbasov
this.sd.outputFormat, etc?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
Lines 978 (patched)
<https://reviews.apache.org/r/68395/#comment291324>
Why do we need an explicit empty constructor?
Alexander Kolbasov created HIVE-20404:
-
Summary: Split HMS security classes into client and server parts
Key: HIVE-20404
URL: https://issues.apache.org/jira/browse/HIVE-20404
Project: Hive
---
Added unit test to verify the expected behavior.
Thanks,
Alexander Kolbasov
To reply, visit:
https://reviews.apache.org/r/68365/#review207354
-------
On Aug. 15, 2018, 8:18 p.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatical
ms(EXTERNAL=true),TableType.EXTERNAL_TABLE
> > as well?
Will add tests.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68365/#review207354
--
expected behavior.
Thanks,
Alexander Kolbasov
views.apache.org/r/68351/#review207286
---
On Aug. 15, 2018, 12:31 a.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatically generated e-mail. To rep
,
Alexander Kolbasov
35abd006d41f0eca354123fcfe6f590867f80cac
Diff: https://reviews.apache.org/r/68351/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
Alexander Kolbasov created HIVE-20390:
-
Summary: Split TxnUtils into common and server parts.
Key: HIVE-20390
URL: https://issues.apache.org/jira/browse/HIVE-20390
Project: Hive
Issue
Alexander Kolbasov created HIVE-20388:
-
Summary: Move common classes out of metastore-server
Key: HIVE-20388
URL: https://issues.apache.org/jira/browse/HIVE-20388
Project: Hive
Issue
Alexander Kolbasov created HIVE-20387:
-
Summary: Move non-server related methods from Warehouse to
MetastoreUtils
Key: HIVE-20387
URL: https://issues.apache.org/jira/browse/HIVE-20387
Project
/68308/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
/67954/diff/5-6/
Testing
---
Thanks,
Alexander Kolbasov
1422701be234be98097701f0f58df4eecc5e8838
Diff: https://reviews.apache.org/r/67981/diff/3/
Changes: https://reviews.apache.org/r/67981/diff/2-3/
Testing
---
Thanks,
Alexander Kolbasov
://reviews.apache.org/r/67731/diff/4-5/
Testing
---
Thanks,
Alexander Kolbasov
://reviews.apache.org/r/67981/diff/2/
Changes: https://reviews.apache.org/r/67981/diff/1-2/
Testing
---
Thanks,
Alexander Kolbasov
/67954/diff/5/
Changes: https://reviews.apache.org/r/67954/diff/4-5/
Testing
---
Thanks,
Alexander Kolbasov
d91f737450efa9de6db3806401072645c96bbb7d
Diff: https://reviews.apache.org/r/67954/diff/4/
Changes: https://reviews.apache.org/r/67954/diff/3-4/
Testing
---
Thanks,
Alexander Kolbasov
/
Testing
---
Thanks,
Alexander Kolbasov
://reviews.apache.org/r/67954/diff/2/
Changes: https://reviews.apache.org/r/67954/diff/1-2/
Testing
---
Thanks,
Alexander Kolbasov
s better to make
configurable?
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67954/#review206230
-------
On July 1
cb32236d548ecff58fd190f1f4df8da45a42fa1a
Diff: https://reviews.apache.org/r/67981/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
65bb86ee82cdeca63f9b6daf9bb262f65c6c61a0
Diff: https://reviews.apache.org/r/67731/diff/4/
Changes: https://reviews.apache.org/r/67731/diff/3-4/
Testing
---
Thanks,
Alexander Kolbasov
Alexander Kolbasov created HIVE-20198:
-
Summary: Constant time table drops/renames
Key: HIVE-20198
URL: https://issues.apache.org/jira/browse/HIVE-20198
Project: Hive
Issue Type
cb32236d548ecff58fd190f1f4df8da45a42fa1a
Diff: https://reviews.apache.org/r/67961/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
d91f737450efa9de6db3806401072645c96bbb7d
Diff: https://reviews.apache.org/r/67954/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
Alexander Kolbasov created HIVE-20196:
-
Summary: Separate MetastoreConf into common and server parts
Key: HIVE-20196
URL: https://issues.apache.org/jira/browse/HIVE-20196
Project: Hive
Alexander Kolbasov created HIVE-20195:
-
Summary: Split MetastoreUtils into common and server-specific parts
Key: HIVE-20195
URL: https://issues.apache.org/jira/browse/HIVE-20195
Project: Hive
Alexander Kolbasov created HIVE-20194:
-
Summary: HiveMetastoreClient should use reflection to instantiate
embedded HMS instance
Key: HIVE-20194
URL: https://issues.apache.org/jira/browse/HIVE-20194
Alexander Kolbasov created HIVE-20189:
-
Summary: Separate metastore client code into its own module
Key: HIVE-20189
URL: https://issues.apache.org/jira/browse/HIVE-20189
Project: Hive
Alexander Kolbasov created HIVE-20188:
-
Summary: Split server-specific code outside of standalone
metastore-common
Key: HIVE-20188
URL: https://issues.apache.org/jira/browse/HIVE-20188
Project
28ad152545e26d9df0ef8cc341840299e9b2743c
Diff: https://reviews.apache.org/r/67731/diff/3/
Changes: https://reviews.apache.org/r/67731/diff/2-3/
Testing
---
Thanks,
Alexander Kolbasov
Alexander Kolbasov created HIVE-20097:
-
Summary: Convert standalone-metastore to a submodule
Key: HIVE-20097
URL: https://issues.apache.org/jira/browse/HIVE-20097
Project: Hive
Issue
.java
ba46e63839e4b02d325007b16756ccd8f3240f63
Diff: https://reviews.apache.org/r/67801/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
---
Thanks,
Alexander Kolbasov
,
Alexander Kolbasov
Alexander Kolbasov created HIVE-19902:
-
Summary: Provide Metastore micro-benchmarks
Key: HIVE-19902
URL: https://issues.apache.org/jira/browse/HIVE-19902
Project: Hive
Issue Type
n O'Malley
wrote:
> I think that having benchmarks is a really good idea.
>
> You will need to make them a separate submodule of the standalone
> Metastore that isn't built by default, because we can't have a dependency
> on JMH, which is GPL licensed.
>
> .. O
I have a collection of Hive Metastore tools that talk to metastore over
Thrift. The most useful part of these is a collection of metastore
micro-benchmarks.
Currently tools live in my private repo (https://github.com/akolb1/hclient)
and I think that now when we have standalone metastore it makes s
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67485/#review204512
---
Ship it!
Ship It!
- Alexander Kolbasov
On June 7, 2018, 10
using of thread-safe map?
Another way you can do it is to collect added partitions in thread-safe
local map and then copy it to the resulting map once you are done with
concurrent part.
- Alexander Kolbasov
On June 1, 2018, 12:31 p.m., Marta Kuczora wrote:
>
>
.java
Line 331 (original), 331 (patched)
<https://reviews.apache.org/r/67351/#comment286779>
Please update Javadoc as well
- Alexander Kolbasov
On June 5, 2018, 7:54 a.m., Peter Vary wrote:
>
> ---
> This is an
Alexander Kolbasov created HIVE-19719:
-
Summary: Adding metastore batch API for partitions
Key: HIVE-19719
URL: https://issues.apache.org/jira/browse/HIVE-19719
Project: Hive
Issue Type
Alexander Kolbasov created HIVE-19718:
-
Summary: Adding partitions in bulk also fetches table for each
partition
Key: HIVE-19718
URL: https://issues.apache.org/jira/browse/HIVE-19718
Project
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66800/#review203011
---
Ship it!
Ship It!
- Alexander Kolbasov
On May 11, 2018, 2
eDirectSql.java
Lines 2761 (patched)
<https://reviews.apache.org/r/66800/#comment284850>
It is usually better to use !isEmpty() in such cases.
Also, it may be easier to read if you do
```
if (danglingColumnDescriptorIdList.isEmpty()) {
return;
}
```
- Alexan
Alexander Kolbasov created HIVE-19337:
-
Summary: Partition whitelist regex doesn't work (and never did)
Key: HIVE-19337
URL: https://issues.apache.org/jira/browse/HIVE-19337
Project:
Do you need to do this from C/C++? I have a set of tools that you can use
to talk to HMS via thrift using Java, Python or Go.
On Thu, Apr 26, 2018 at 5:23 AM, 侯宗田 wrote:
> Hi,
>
> I am writing a simple thrift HMS client to get table location on hdfs, I
> generate the cpp code from hive_metastore
Alexander Kolbasov created HIVE-19253:
-
Summary: HMS ignores tableType property for external tables
Key: HIVE-19253
URL: https://issues.apache.org/jira/browse/HIVE-19253
Project: Hive
---
Added both positive unit test verifying that stats are updated and negative
test verifying that stats are not updated when they shouldn't be.
Thanks,
Alexander Kolbasov
Looking at proposed changes for HIVE-19171 and other recent changes I am
wondering whether we start to use Hive Metastore as a dumping ground for
anything that should be stored somewhere. It would be good to establish
criteria on what belongs to Hive Metastore and what doesn't. This is
especially i
tastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Line 3595 (original), 3548 (patched)
<https://reviews.apache.org/r/7/#comment282718>
Note that cleanupPartitionFolders() here may throw an exception, thus
preventing other cleanup.
- Alexander
Alexander Kolbasov created HIVE-19241:
-
Summary: HMSHandler initialization isn't thread-safe
Key: HIVE-19241
URL: https://issues.apache.org/jira/browse/HIVE-19241
Project: Hive
Alexander Kolbasov created HIVE-19177:
-
Summary: ObjectStore.setConf() is doing dangerous work while
holding global lock
Key: HIVE-19177
URL: https://issues.apache.org/jira/browse/HIVE-19177
Alexander Kolbasov created HIVE-19086:
-
Summary: Write notifications in bulk only when commitTransaction
actually commits
Key: HIVE-19086
URL: https://issues.apache.org/jira/browse/HIVE-19086
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66288/#review27
---
Ship it!
Ship It!
- Alexander Kolbasov
On March 26, 2018
r the single row.
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
Lines 89 (patched)
<https://reviews.apache.org/r/66288/#comment280521>
s/is can/is likely to/
- Alexander Kolbasov
On March 26,
Can someone point me to the documentation for partition expressions?
Thanks,
- Alex
/apache/hadoop/hive/metastore/HiveMetaStore.java
Line 3162 (original), 3169 (patched)
<https://reviews.apache.org/r/65716/#comment279361>
is it possible that getSd() is null here?
- Alexander Kolbasov
On March 8, 2018, 4:52 p.m., Marta Kuczora
ines 99 (patched)
<https://reviews.apache.org/r/65985/#comment279354>
There is only a single consumer of this interface - it seems odd to have an
interface which is used in some special case. Should all access to listeners be
converted to the interface?
- Alexander Kolbasov
On March 8, 2018
Alexander Kolbasov created HIVE-18942:
-
Summary: ALTER TABLE may generate huge event (with all partitions)
Key: HIVE-18942
URL: https://issues.apache.org/jira/browse/HIVE-18942
Project: Hive
Alexander Kolbasov created HIVE-18941:
-
Summary: HMS non-transactional listener may be called in
transactional context
Key: HIVE-18941
URL: https://issues.apache.org/jira/browse/HIVE-18941
Alexander Kolbasov created HIVE-18940:
-
Summary: Hive notifications serialize all write DDL operations
Key: HIVE-18940
URL: https://issues.apache.org/jira/browse/HIVE-18940
Project: Hive
.
- Alexander Kolbasov
On March 7, 2018, 3:48 p.m., Marta Kuczora wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/hive/metastore/HiveMetaStore.java
662de9a66767f27f31998f14c68f854e59993ab6
Diff: https://reviews.apache.org/r/65943/diff/2/
Changes: https://reviews.apache.org/r/65943/diff/1-2/
Testing
---
Thanks,
Alexander Kolbasov
: https://reviews.apache.org/r/65943/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
ve. But anyway, setting of success above seems useless.
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Line 3095 (original), 3129 (patched)
<https://reviews.apache.org/r/65716/#comment279010&g
Alexander Kolbasov created HIVE-1:
-
Summary: Replace synchronizedMap with ConcurrentHashMap
Key: HIVE-1
URL: https://issues.apache.org/jira/browse/HIVE-1
Project: Hive
Issue
Alexander Kolbasov created HIVE-18885:
-
Summary: Cascaded alter table + notifications = disaster
Key: HIVE-18885
URL: https://issues.apache.org/jira/browse/HIVE-18885
Project: Hive
Issue
1 - 100 of 190 matches
Mail list logo
