----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68889/#review209167 -----------------------------------------------------------
The fix is fine, kust some style issues. itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java Lines 123 (patched) <https://reviews.apache.org/r/68889/#comment293458> Style: class fields usually follow normal camelCase. Do we need a subdirectory for tests? It is better to use joining with Path or File, e.g. Path currentPath = Paths.get(System.getProperty("java.io.tmpdir")); Path filePath = Paths.get(currentPath.toString(), "testDbNotif"); itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java Line 876 (original), 883 (patched) <https://reviews.apache.org/r/68889/#comment293460> It is better to join using Path or FIle methods. - Alexander Kolbasov On Oct. 2, 2018, 9:55 p.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68889/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2018, 9:55 p.m.) > > > Review request for hive, Alexander Kolbasov and Andrew Sherman. > > > Bugs: HIVE-20610 > https://issues.apache.org/jira/browse/HIVE-20610 > > > Repository: hive-git > > > Description > ------- > > Adding java.io.tmpdir as tmp directory instead of /tmp > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java > 82429e36a575918d92a9b22bedcd63788ec51c5f > > > Diff: https://reviews.apache.org/r/68889/diff/2/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
