----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66667/#review203099 -----------------------------------------------------------
Looks good, a few nits below. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Line 3227 (original), 3322 (patched) <https://reviews.apache.org/r/66667/#comment285171> Is it possible to do it once in constructor instead? I suspect that this is a no-trivial operation. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 3253 (patched) <https://reviews.apache.org/r/66667/#comment286933> Can you clarify that "clean up" means removing associated directory. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 3268 (patched) <https://reviews.apache.org/r/66667/#comment286934> Please add a Javadoc here explaining what is checked by validation. Also it isn't obvious that validation has side effects (updating partsToAdd) standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Line 3247 (original), 3343 (patched) <https://reviews.apache.org/r/66667/#comment286935> addedPartitions is not defined here so it isn't obvious that it should be thread-safe. Is it possible to allocate and return addedPartitions here so that you guarantee using of thread-safe map? Another way you can do it is to collect added partitions in thread-safe local map and then copy it to the resulting map once you are done with concurrent part. - Alexander Kolbasov On June 1, 2018, 12:31 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66667/ > ----------------------------------------------------------- > > (Updated June 1, 2018, 12:31 p.m.) > > > Review request for hive, Peter Vary, Sahil Takiar, and Adam Szita. > > > Bugs: HIVE-19046 > https://issues.apache.org/jira/browse/HIVE-19046 > > > Repository: hive-git > > > Description > ------- > > The biggest part of these methods use the same code. Refactored these code > parts to common methods. > > > Diffs > ----- > > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > d8b8414 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java > 88064d9 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitionsFromPartSpec.java > debcd0e > > > Diff: https://reviews.apache.org/r/66667/diff/5/ > > > Testing > ------- > > > Thanks, > > Marta Kuczora > >
