> On Aug. 15, 2018, 1:12 a.m., Vihang Karajgaonkar wrote: > > I think the DelegationToken* classes should be in the server module. For > > the method in SecurityUtils to get the name of TokenStore classes, we can > > keep it in MetastoreServerUtils class since I don't think it will be needed > > by MetastoreClient. Not sure if the repl*manager classes belong to common > > either. Can you specify why we need to move these classes in common?
There is a bunch of tangled dependencies coming from HiveMetastoreClient. I suggest to keep it like this for now and then try to antangle the security part and move some of it to the metastore-server server module as a follow-up work. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68351/#review207286 ----------------------------------------------------------- On Aug. 15, 2018, 12:31 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68351/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2018, 12:31 a.m.) > > > Review request for hive, Alan Gates, Peter Vary, and Vihang Karajgaonkar. > > > Bugs: HIVE-20388 > https://issues.apache.org/jira/browse/HIVE-20388 > > > Repository: hive-git > > > Description > ------- > > HIVE-20388: Move common classes out of metastore-server > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java > f746d2dff32573470ee104311d014893205894d5 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUpdaterThread.java > a50ec18b8aee0e24b632147f02c43526e0fe3071 > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java > d23e4389a770d11008d309d41780a8b692fc551a > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnCommonUtils.java > PRE-CREATION > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ColumnType.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 0441a33cd751e3668c43a1086adf932b0d67f169 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 324035a8096a001d3fb170b8640805258d5e2cdd > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 5ae00af564b05ec2720a03072f94c8f8579378a7 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsRebuildLockCleanerTask.java > 9ce7d6db497079ef874eef387d86d11d893d4470 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFS.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/TableIterable.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/conf/TimeValidator.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/partition/spec/CompositePartitionSpecProxy.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/partition/spec/PartitionListComposingSpecProxy.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/partition/spec/PartitionSpecProxy.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/partition/spec/PartitionSpecWithSharedSDProxy.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/DelegationTokenIdentifier.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/DelegationTokenSecretManager.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/DelegationTokenSelector.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/HadoopThriftAuthBridge.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/HadoopThriftAuthBridge23.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/MetastoreDelegationTokenManager.java > 8d84fd7f323af1de4ac994863d81e5b06be5bcce > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 015dfd9ec971adcdece7b6b55c1962bc09f6edee > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java > aac58110f9de718817bd5d71da69b0400b4fd74d > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/HdfsUtils.java > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java > 69846b77d15b6cde49d578e9c5530e074615136d > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/SecurityUtils.java > 0b0cfbda8017fb09433fee03b74c2006743f8218 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java > 35abd006d41f0eca354123fcfe6f590867f80cac > > > Diff: https://reviews.apache.org/r/68351/diff/2/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
