The vote to release HttpComponents HttpCore 5.2.5 based on RC1 has
passed with the following results
+1 (4 binding votes in total)
Gary Gregory *
Ryan Schmitt *
Arturo Bernal *
Oleg Kalnichevski *
no other votes
* binding votes
Original voting thread:
https://lists.apache.org/thread/ssj5o7h
strangelookingnerd opened a new pull request, #470:
URL: https://github.com/apache/httpcomponents-core/pull/470
This PR cleans up the test classes. The proposed changes include:
**Remove superfluous exceptions in throws clauses**
Superfluous exceptions within throws clauses have neg
garydgregory commented on PR #470:
URL:
https://github.com/apache/httpcomponents-core/pull/470#issuecomment-2191613075
I would not change public vs package visibility, but that's just me, and the
convention we've been using.
--
This is an automated message from the Apache Git Service.
To
ok2c commented on PR #470:
URL:
https://github.com/apache/httpcomponents-core/pull/470#issuecomment-2191594071
Oh, that is a big one.
> Make sure tests have at least one assertion
I am aware of this recommendation but I always felt it was not justified /
too extreme.
Is
strangelookingnerd commented on PR #470:
URL:
https://github.com/apache/httpcomponents-core/pull/470#issuecomment-2191634860
> > Make sure tests have at least one assertion
>
> I am aware of this recommendation but I always felt it was not justified /
too extreme.
I myself am
strangelookingnerd commented on PR #470:
URL:
https://github.com/apache/httpcomponents-core/pull/470#issuecomment-2191642879
> I would not change public vs package visibility, but that's just me, and
the convention we've been using.
The thing is that right now there is a mixture (at
