strangelookingnerd commented on PR #470: URL: https://github.com/apache/httpcomponents-core/pull/470#issuecomment-2191642879
> I would not change public vs package visibility, but that's just me, and the convention we've been using. The thing is that right now there is a mixture (at least for the methods) of `public` and `package` that would get resolved. As for the classes, I think it helps a lot in terms of readability and would make it consistent with the recommendation of the JUnit Team. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
