ok2c commented on PR #470: URL: https://github.com/apache/httpcomponents-core/pull/470#issuecomment-2191594071
Oh, that is a big one. > Make sure tests have at least one assertion I am aware of this recommendation but I always felt it was not justified / too extreme. Is there a chance you could split this PR into multiple commits? Can we start with ` Test classes and methods should have default package visibility`, `Remove duplicate tests` and `Fix assertion argument orders`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
