strangelookingnerd opened a new pull request, #470: URL: https://github.com/apache/httpcomponents-core/pull/470
This PR cleans up the test classes. The proposed changes include: **Remove superfluous exceptions in throws clauses** Superfluous exceptions within throws clauses have negative effects on the readability and maintainability of the code. **Test classes and methods should have default package visibility** It is ecommended to use the default package visibility to improve readability: > > Test classes, test methods, and lifecycle methods are not required to be public, but they must not be private. It is generally recommended to omit the public modifier for test classes, test methods, and lifecycle methods unless there is a technical reason for doing so – for example, when a test class is extended by a test class in another package. Another technical reason for making classes and methods public is to simplify testing on the module path when using the Java Module System. > — JUnit5 User Guide **Fix assertion argument orders** To me it seems like some assertions where not correctly upgraded when JUnit5 was introduced, where the order of arguments for some `Assertions` methods was changed. **Remove duplicate tests** Some test methods were implemented twice (=identical) under different names in the same class. **Make sure tests have at least one assertion** A test case should at least have one assertion made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
