[GitHub] [httpcomponents-core] ok2c commented on pull request #421: Support InetAddress throughout request execution

ok2c commented on PR #421: URL: https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1694220125 You are going about it all wrong. You are mixing up message composition and message routing responsibilities. Request builders build messages. They do not make connection setup an

[GitHub] [httpcomponents-core] ok2c closed pull request #421: Support InetAddress throughout request execution

ok2c closed pull request #421: Support InetAddress throughout request execution URL: https://github.com/apache/httpcomponents-core/pull/421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [httpcomponents-core] ok2c opened a new pull request, #422: Async requesters to support custom / resolved target endpoints

ok2c opened a new pull request, #422: URL: https://github.com/apache/httpcomponents-core/pull/422 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [httpcomponents-core] ok2c commented on pull request #421: Support InetAddress throughout request execution

ok2c commented on PR #421: URL: https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1694268016 @bpitman Superseded by #422 Feel to free to review / test / comment upon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [httpcomponents-core] garydgregory commented on a diff in pull request #422: Async requesters to support custom / resolved target endpoints

garydgregory commented on code in PR #422: URL: https://github.com/apache/httpcomponents-core/pull/422#discussion_r1306408906 ## httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2MultiplexingRequester.java: ## @@ -128,18 +130,38 @@ public Cancellable exe

[GitHub] [httpcomponents-client] ok2c opened a new pull request, #478: HTTPCLIENT-2284: internal cache storage improvements

ok2c opened a new pull request, #478: URL: https://github.com/apache/httpcomponents-client/pull/478 Added internal cache storage implementation that can be used to implement custom cache storage backends with specific cache entry eviction strategy. @arturobernalg Please review. --

[jira] [Commented] (HTTPCLIENT-2284) BasicHttpCacheStorage leaking variant keys in root response's variantMap

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759262#comment-17759262 ] Oleg Kalnichevski commented on HTTPCLIENT-2284: --- [~lacompas]  Please

[jira] [Comment Edited] (HTTPCLIENT-2284) BasicHttpCacheStorage leaking variant keys in root response's variantMap

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759262#comment-17759262 ] Oleg Kalnichevski edited comment on HTTPCLIENT-2284 at 8/26/23 4:07 PM: --

[GitHub] [httpcomponents-core] bpitman commented on pull request #422: Async requesters to support custom / resolved target endpoints

bpitman commented on PR #422: URL: https://github.com/apache/httpcomponents-core/pull/422#issuecomment-1694405377 Passing on intent from PR 421: I understand that you want no more connection/tls configuration in HttpRequest beyond what can be expressed in URI. In this case, why does the

[GitHub] [httpcomponents-core] ok2c commented on pull request #422: Async requesters to support custom / resolved target endpoints

ok2c commented on PR #422: URL: https://github.com/apache/httpcomponents-core/pull/422#issuecomment-1694407530 @bpitman The `#setHttpHost` method is merely a convenience method that copies the protocol scheme and the authority in one go from an existing `HttpHost`. I am not sure I

[GitHub] [httpcomponents-core] arturobernalg opened a new pull request, #423: HTTPCORE-756 - Enforced the requirement that "https" URIs must not have an empty host identifier

arturobernalg opened a new pull request, #423: URL: https://github.com/apache/httpcomponents-core/pull/423 This PR brings our `URIBuilder` in line with the standards set by RFC 9110, specifically Section 4.2.2 regarding HTTPS URIs. Changes: Implemented a check to ensure `ht