Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-12 Thread via GitHub
ok2c merged PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-12 Thread via GitHub
ok2c commented on PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#issuecomment-2408456486 > Shouldn't the tests rely solely on `TestContainers` automatic clean-up? Wouldn't adding explicit `@AfterEach` calls to stop containers be a good idea as a fail-safe, especially

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-11 Thread via GitHub
michael-o commented on PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#issuecomment-2408150612 > I use TextContainers elsewhere, works like champ! TextContainers for sure... :-D -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-11 Thread via GitHub
ok2c commented on PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#issuecomment-2407892866 If there are no further comments I will merge this PR as there is a few others that depend on it. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-11 Thread via GitHub
massdosage commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1797228784 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * ===

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-11 Thread via GitHub
ok2c commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1796927426 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * =

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-11 Thread via GitHub
massdosage commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1796768944 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * ===

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-11 Thread via GitHub
ok2c commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1796738752 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * =

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-11 Thread via GitHub
massdosage commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1796699503 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * ===

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-11 Thread via GitHub
massdosage commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1796695808 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * ===

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-11 Thread via GitHub
massdosage commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1796695808 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * ===

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-10 Thread via GitHub
arturobernalg commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1795864799 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + *

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-10 Thread via GitHub
ok2c commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1795854034 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * =

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-10 Thread Gary Gregory
I agree that "latest" doesn't sound reproducible but more importantly is not secure, this has been an issue in other ecosystems. We pin versions of dependencies in POMs, we should do it here as well. Good find! Gafy On Thu, Oct 10, 2024, 12:12 PM massdosage (via GitHub) wrote: > > massdosage co

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-10 Thread via GitHub
massdosage commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1795738709 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * ===

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-10 Thread via GitHub
garydgregory commented on PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#issuecomment-2404826384 I use TextContainers elsewhere, works like champ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

2024-10-10 Thread via GitHub
ok2c opened a new pull request, #494: URL: https://github.com/apache/httpcomponents-core/pull/494 Folks I just recently discovered [TestContainers](https://java.testcontainers.org/) and it this framework is an absolute marvel! I took it as an opportunity to revise and improve