massdosage commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1796695808
########## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ########## @@ -0,0 +1,94 @@ +/* + * ==================================================================== + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * ==================================================================== + * + * This software consists of voluntary contributions made by many + * individuals on behalf of the Apache Software Foundation. For more + * information on the Apache Software Foundation, please see + * <http://www.apache.org/>. + * + */ +package org.apache.hc.core5.testing.compatibility; + +import org.testcontainers.containers.GenericContainer; +import org.testcontainers.images.builder.ImageFromDockerfile; +import org.testcontainers.utility.DockerImageName; + +public final class ContainerImages { + + public static final String AAA = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"; + public static final String BBB = "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"; + public static final String CCC = "ccccccccccccccccccccccccccccccccccccccccccccccccc"; + public static final String PUSHY = "I am being very pushy"; + + public static int HTTP_PORT = 80; + + public static GenericContainer<?> httpBin() { + return new GenericContainer<>(DockerImageName.parse("kennethreitz/httpbin:latest")) Review Comment: OK, if if it's stable and updated infrequently then I suppose this is fine. I've just been bitten many times when a build starts failing with no code changes in the repo due to a "latest" version changing in a backwards-incompatible way. This will never happen if you lock to a specific version. Sounds like this is a calculated risk that you're willing to take in this way and maybe it's even intentional to test against the latest upstream versions and you'd like to know if this breaks the code here in any way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
