I agree that "latest" doesn't sound reproducible but more importantly is not secure, this has been an issue in other ecosystems. We pin versions of dependencies in POMs, we should do it here as well. Good find!
Gafy On Thu, Oct 10, 2024, 12:12 PM massdosage (via GitHub) <g...@apache.org> wrote: > > massdosage commented on code in PR #494: > URL: > https://github.com/apache/httpcomponents-core/pull/494#discussion_r1795738709 > > > ########## > > httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: > ########## > @@ -0,0 +1,94 @@ > +/* > + * ==================================================================== > + * Licensed to the Apache Software Foundation (ASF) under one > + * or more contributor license agreements. See the NOTICE file > + * distributed with this work for additional information > + * regarding copyright ownership. The ASF licenses this file > + * to you under the Apache License, Version 2.0 (the > + * "License"); you may not use this file except in compliance > + * with the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, > + * software distributed under the License is distributed on an > + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > + * KIND, either express or implied. See the License for the > + * specific language governing permissions and limitations > + * under the License. > + * ==================================================================== > + * > + * This software consists of voluntary contributions made by many > + * individuals on behalf of the Apache Software Foundation. For more > + * information on the Apache Software Foundation, please see > + * <http://www.apache.org/>. > + * > + */ > +package org.apache.hc.core5.testing.compatibility; > + > +import org.testcontainers.containers.GenericContainer; > +import org.testcontainers.images.builder.ImageFromDockerfile; > +import org.testcontainers.utility.DockerImageName; > + > +public final class ContainerImages { > + > + public static final String AAA = > "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"; > + public static final String BBB = > "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"; > + public static final String CCC = > "ccccccccccccccccccccccccccccccccccccccccccccccccc"; > + public static final String PUSHY = "I am being very pushy"; > + > + public static int HTTP_PORT = 80; > + > + public static GenericContainer<?> httpBin() { > + return new > GenericContainer<>(DockerImageName.parse("kennethreitz/httpbin:latest")) > > Review Comment: > I don't know what the philosophy is in this project but as a rule of > thumb I would avoid using `latest` - an upstream change could occur and > break the build here with no code changes having occurred in this repo. > Wouldn't it be better to use a specific version of this container instead? > > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > >
