ok2c commented on PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#issuecomment-2408456486
> Shouldn't the tests rely solely on `TestContainers` automatic clean-up? Wouldn't adding explicit `@AfterEach` calls to stop containers be a good idea as a fail-safe, especially in case of unexpected failures? LGTM @arturobernalg All right. I added an explicit `@afterAll` to close the containers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
