Re: Hello Everyone

2015-05-15 Thread Aljoscha Krettek
We'll look at why it failed and then decide whether it's good. So for those KafkaITCase fails we no that it doesn't matter right now. On Fri, May 15, 2015 at 12:56 AM, Lokesh Rajaram wrote: > This almost worked. Of the 5 build jobs four passed and one failed. > What's the acceptance criteria for

Re: Hello Everyone

2015-05-14 Thread Lokesh Rajaram
This almost worked. Of the 5 build jobs four passed and one failed. What's the acceptance criteria for a pull request? Do I need to build again to get all 5 build jobs passing? Thanks, Lokesh On Thu, May 14, 2015 at 8:50 AM, Robert Metzger wrote: > No, you don't have to wait. > The KafkaITCase

Re: Hello Everyone

2015-05-14 Thread Robert Metzger
No, you don't have to wait. The KafkaITCase is not always failing. If you're lucky, it will pass with the next run. On Thu, May 14, 2015 at 5:48 PM, Lokesh Rajaram wrote: > If I understand it correct, I have to wait for your pull request to be > merged, I can rebase and trigger build again. is t

Re: Hello Everyone

2015-05-14 Thread Lokesh Rajaram
If I understand it correct, I have to wait for your pull request to be merged, I can rebase and trigger build again. is that right? Thanks Robert, Aljoscha for super fast reply/help. Thanks, Lokesh On Thu, May 14, 2015 at 8:39 AM, Robert Metzger wrote: > However, you can only restart runs in y

Re: Hello Everyone

2015-05-14 Thread Robert Metzger
However, you can only restart runs in your travis account, not on the apache account (also used for validating pull requests). I have opened a pull request a few minutes ago which will reduce the number of KafakITCase failures (there is still one other unresolved issue). On Thu, May 14, 2015 at 5

Re: Hello Everyone

2015-05-14 Thread Aljoscha Krettek
Hi, don't worry, there are very few stupid questions. :D The KafkaITCase sometimes fails on Travis, this is a known problem currently. On travis you can restart the individual runs for a commit in the view of the failed run. Hope that helps. Cheers, Aljoscha On Thu, May 14, 2015 at 5:35 PM, Lok

Re: Hello Everyone

2015-05-14 Thread Lokesh Rajaram
Thanks Aljoscha, Robert. After adding guava dependency for flink-spargel I was able to progress further but now it's failing in flink-streaming-connectors for the following test case: KafkaITCase.brokerFailureTest:936->tryExecute:352 Test failed with: Job execution failed. Any pointers would help

Re: Hello Everyone

2015-05-14 Thread Robert Metzger
I think flink-spargel is missing the guava dependency. On Thu, May 14, 2015 at 8:18 AM, Aljoscha Krettek wrote: > @Robert, this seems like a problem with the Shading? > > On Thu, May 14, 2015 at 5:41 AM, Lokesh Rajaram > wrote: > > Thanks Aljioscha. I was able to change as recommended and able

Re: Hello Everyone

2015-05-13 Thread Aljoscha Krettek
@Robert, this seems like a problem with the Shading? On Thu, May 14, 2015 at 5:41 AM, Lokesh Rajaram wrote: > Thanks Aljioscha. I was able to change as recommended and able to run the > entire test suite in local successfully. > However Travis build is failing for pull request: > https://github.c

Re: Hello Everyone

2015-05-13 Thread Lokesh Rajaram
Thanks Aljioscha. I was able to change as recommended and able to run the entire test suite in local successfully. However Travis build is failing for pull request: https://github.com/apache/flink/pull/673. It's a compilation failure: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-

Re: Hello Everyone

2015-05-11 Thread Aljoscha Krettek
I think you can replace Validate.NotNull(p) with require(p != null, "p is null (or something like this)"). On Mon, May 11, 2015 at 12:27 AM, Lokesh Rajaram wrote: > 1. I think I can use require for replacing Validate.isTrue > 2. What about Validate.notNull? If require is used it would throw > Ill

Re: Hello Everyone

2015-05-10 Thread Lokesh Rajaram
1. I think I can use require for replacing Validate.isTrue 2. What about Validate.notNull? If require is used it would throw IllegalArgumentException, if assume or assert is used it would throw AssertionError which is not compatible with current implementation. Please let me know if my understandi

Re: Hello Everyone

2015-05-10 Thread Aljoscha Krettek
I would propose using the methods as Chiwan suggested. If everyone agrees I can change the Jira issue. On Sun, May 10, 2015 at 6:47 AM, Lokesh Rajaram wrote: > Thank you for the reference links. Which approach should I take, casting or > use scala methods. > If it's the latter option will the JIR

Re: Hello Everyone

2015-05-09 Thread Lokesh Rajaram
Thank you for the reference links. Which approach should I take, casting or use scala methods. If it's the latter option will the JIRA ticket FLINK-1711 be updated to reflect it? Thanks, Lokesh On Sat, May 9, 2015 at 8:16 PM, Chiwan Park wrote:

Re: Hello Everyone

2015-05-09 Thread Chiwan Park
Hi. There is some problems using Guava’s check method in Scala. (https://groups.google.com/forum/#!topic/guava-discuss/juwovq26R3k ) You can solve this error simply with casting last argument to java.lang.Object. But I think we’

Hello Everyone

2015-05-09 Thread Lokesh Rajaram
Hello All, I am new to Flink community and am very excited about the project and work you all have been doing. Kudos!! I was looking to pickup some starter task. Robert recommended to pick up https://issues.apache.org/jira/browse/FLINK-1711. Thanks Robert for your guidance. Sorry for a dumb ques