I would propose using the methods as Chiwan suggested. If everyone agrees I can change the Jira issue.
On Sun, May 10, 2015 at 6:47 AM, Lokesh Rajaram <rajaram.lok...@gmail.com> wrote: > Thank you for the reference links. Which approach should I take, casting or > use scala methods. > If it's the latter option will the JIRA ticket FLINK-1711 > <https://issues.apache.org/jira/browse/FLINK-1711> be updated to reflect it? > > Thanks, > Lokesh > > On Sat, May 9, 2015 at 8:16 PM, Chiwan Park <chiwanp...@icloud.com> wrote: > >> Hi. There is some problems using Guava’s check method in Scala. ( >> https://groups.google.com/forum/#!topic/guava-discuss/juwovq26R3k < >> https://groups.google.com/forum/#!topic/guava-discuss/juwovq26R3k>) You >> can solve this error simply with casting last argument to java.lang.Object. >> But I think we’d better use `require`, `assume`, `assert` method provided >> by Scala. ( >> http://daily-scala.blogspot.kr/2010/03/assert-require-assume.html < >> http://daily-scala.blogspot.kr/2010/03/assert-require-assume.html>) >> Because this changes affects many other codes, so we should discuss about >> changing Guava's method to Scala’s method. >> >> Regards. >> Chiwan Park (Sent with iPhone) >> >> >> >> > On May 10, 2015, at 11:49 AM, Lokesh Rajaram <rajaram.lok...@gmail.com> >> wrote: >> > >> > Hello All, >> > >> > I am new to Flink community and am very excited about the project and >> work >> > you all have been doing. Kudos!! >> > >> > I was looking to pickup some starter task. Robert recommended to pick up >> > https://issues.apache.org/jira/browse/FLINK-1711. Thanks Robert for your >> > guidance. >> > >> > Sorry for a dumb question. I am done with code changes but my "mvn >> verify" >> > failing only for the scala module as follows >> > >> > >> flink/flink-scala/src/main/scala/org/apache/flink/api/scala/joinDataSet.scala:77: >> > error: ambiguous reference to overloaded definition, >> > [ERROR] both method checkNotNull in object Preconditions of type [T](x$1: >> > T, x$2: String, x$3: <repeated...>[Object])T >> > [ERROR] and method checkNotNull in object Preconditions of type [T](x$1: >> > T, x$2: Any)T >> > [ERROR] match argument types ((L, R) => O,String) >> > [ERROR] Preconditions.checkNotNull(fun, "Join function must not be >> > null.") >> > >> > Same error I see for all of the Scala classes I changed. Any pointers >> here >> > will be very helpful for me to proceed further. Please let me know if you >> > need more information. >> > >> > Thanks in advance for your help and support. >> > >> > Thanks, >> > Lokesh >> >>
