Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-30 Thread Maximilian Michels
Thanks for reporting and providing a fix, Till! We have also fixed two issues with the new job manager web frontend and pushed them to the release-0.10 branch. Please review these changes in the new release candidate. On Wed, Oct 28, 2015 at 6:55 PM, Till Rohrmann wrote: > -1 from my side. I jus

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Till Rohrmann
-1 from my side. I just found a serious issue with the KryoSerializer (FLINK-2800) which in some cases produced duplicated elements or corrupted data. I opened a PR to fix the issue ( https://github.com/apache/flink/pull/1308). Cheers, Till ​ On Wed, Oct 28, 2015 at 5:38 PM, Maximilian Michels w

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Maximilian Michels
Not sure. I think I'd rather leave it as it is because it renders the normal view (when your screen is wide enough unreadable). I'd rather wait for a proper fix. Now https://drive.google.com/file/d/0BziY9U_qva1sYzdxR3RJakltM0E/view?usp=sharing Afterwards https://drive.google.com/file/d/0BziY9U_qva

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Sachin Goel
Yes. I just made it work in firefox. It was already working in Chrome this way. Maybe Piotr will have a better fix later on. -- Sachin Goel Computer Science, IIT Delhi m. +91-9871457685 On Wed, Oct 28, 2015 at 9:42 PM, Maximilian Michels wrote: > @Sachin: I've tried it out. It has the tendency

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Maximilian Michels
@Sachin: I've tried it out. It has the tendency to make things a bit harder to read (because it breaks words at arbitrary positions). However, we don't have a better fix. On Wed, Oct 28, 2015 at 4:46 PM, Sachin Goel wrote: > Sorry. Wrong commit. In case you've pulled already. > > -- Sachin Goel >

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Sachin Goel
Sorry. Wrong commit. In case you've pulled already. -- Sachin Goel Computer Science, IIT Delhi m. +91-9871457685 On Wed, Oct 28, 2015 at 9:09 PM, Sachin Goel wrote: > @Max: Here's a fix for the wrapping issue: > https://github.com/sachingoel0101/flink/tree/long-vertex-name. It's just > two line

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Sachin Goel
@Max: Here's a fix for the wrapping issue: https://github.com/sachingoel0101/flink/tree/long-vertex-name. It's just two lines, so I don't think opening a PR makes sense. Lemme know if I should. @Vasia: Can you test it out on your job? I've checked on firefox, chrome and IE and it seems to work. [Y

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Vasiliki Kalavri
Ah I see. Thanks Sachin, Max. I think a label would be nice there, yes. On 28 October 2015 at 15:45, Maximilian Michels wrote: > Yes, that's correct. One is running operators (top of the job view) > while the other lists all the parallel tasks (overview page, and > detail view in job view). I th

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Maximilian Michels
Yes, that's correct. One is running operators (top of the job view) while the other lists all the parallel tasks (overview page, and detail view in job view). I think it makes sense where they are displayed at the moment. It's just confusing how they are displayed. Could we add a label at the top o

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Sachin Goel
I think the squares on top of the job page are showing the status of vertices, not tasks. The squares on overview pages however show the number of tasks. Should we make it vertices or tasks everywhere, for consistency? -- Sachin Goel Computer Science, IIT Delhi m. +91-9871457685 On Wed, Oct 28, 2

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Sachin Goel
@Max, I will try to get the wrap working [rather ellipsifying the text in this case.]. Not very good with CSS unfortunately. @Vasia, there seems to be different things which are being used to render those two. For the running jobs page, job.tasks is rendered, while for the job page, job.status-cou

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Vasiliki Kalavri
The numbers I see in the overview are different. See https://drive.google.com/file/d/0BzQJrI2eGlyYMHZZUGs2ZFJzaXc/view?usp=sharing vs. https://drive.google.com/file/d/0BzQJrI2eGlyYc3kzMlQ4OXN6a3c/view?usp=sharing -Vasia. On 28 October 2015 at 14:51, Maximilian Michels wrote: > @Vasia: This is

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Maximilian Michels
@Vasia: This is a CSS problem which manifests because of a long class name. The colored boxes show the status of tasks from your job which you are viewing. Are the number not correct? @Sachin: Could you fix the wrapping of the column? On Wed, Oct 28, 2015 at 2:44 PM, Sachin Goel wrote: > The nam

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Sachin Goel
The name of the vertex is very long and isn't getting wrapped around to accommodate all the columns. There's a TODO at the relevant place in app/scripts/common/filters.coffee which was probably meant to handle this. -- Sachin Goel Computer Science, IIT Delhi m. +91-9871457685 On Wed, Oct 28, 201

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Vasiliki Kalavri
It's Firefox 41.0.2. Resizing doesn't work :/ See this screenshot for the colored boxes I'm referring to: https://drive.google.com/file/d/0BzQJrI2eGlyYX1VYQTlrQWNfUkE/view?usp=sharing. Shouldn't these numbers show tasks? On 28 October 2015 at 14:26, Maximilian Michels wrote: > @Vasia: > > - Ther

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Maximilian Michels
@Vasia: - There are two types of shapes which are colored :) The circles mark the running/finished/cancelled/failed jobs while the squares mark the status of a task within a job (cancelled/running/failed/restart/pending/finished/total). - I can see all four columns in the "Plan" tab on Firefox. W

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Vasiliki Kalavri
I think I found 2 more issues with the web interface. When inside a running job's view: - I think the colorful boxes with the number of tasks in each status show wrong values (or show something else?). I get different values than the ones I see in "Overview" and "Running Jobs" tabs. - In the "Plan

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Sachin Goel
While we're at it, we should also remove the dummy log and stdout tabs for task managers. The work on that hasn't been finished yet. I'll file a jira for both. On Oct 28, 2015 5:39 PM, "Vasiliki Kalavri" wrote: > I see, thank you! +1 for removing before the release :) > > On 28 October 2015 at 13

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Vasiliki Kalavri
I see, thank you! +1 for removing before the release :) On 28 October 2015 at 13:06, Sachin Goel wrote: > Those are hard coded values. > What exactly should be there, I'm not sure either. > On Oct 28, 2015 5:25 PM, "Vasiliki Kalavri" > wrote: > > > I have a question regarding the web interface

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Sachin Goel
Those are hard coded values. What exactly should be there, I'm not sure either. On Oct 28, 2015 5:25 PM, "Vasiliki Kalavri" wrote: > I have a question regarding the web interface :) > What is the "Job Accumulator/Statistics" tab supposed to show? No matter > what job I run, the values are the sam

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Maximilian Michels
It is supposed to show some general statistics about a job but it is currently just a place holder. The accumulators are shown in the overview. This page should be removed before the release. Thanks, Max On Wed, Oct 28, 2015 at 12:54 PM, Vasiliki Kalavri wrote: > I have a question regarding the

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Vasiliki Kalavri
I have a question regarding the web interface :) What is the "Job Accumulator/Statistics" tab supposed to show? No matter what job I run, the values are the same (operator=1, parallelism=2, subtasks=3). Are these hard-coded defaults? Thanks! -Vasia. On 28 October 2015 at 10:50, Maximilian Michels

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Maximilian Michels
Thanks for testing, Vasia :) Here is the new document: https://docs.google.com/document/d/1CR3DH4tUJvukxGFQ1ySxfnzO00LjPhSTwkeE7Mf98CY/edit I've transferred results which are unaffected by the changes of the new RC. On Wed, Oct 28, 2015 at 10:33 AM, Vasiliki Kalavri < vasilikikala...@gmail.com>

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-28 Thread Vasiliki Kalavri
Is there a new testing doc for rc2 or are we using the previous one? Thanks! On 27 October 2015 at 22:17, Maximilian Michels wrote: > Please vote on releasing the following candidate as Apache Flink version > 0.10.0: > > The commit to be voted on: > ed75049dfc9748eae81ace9d4d686907dcd7835c > > B

[VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc2)

2015-10-27 Thread Maximilian Michels
Please vote on releasing the following candidate as Apache Flink version 0.10.0: The commit to be voted on: ed75049dfc9748eae81ace9d4d686907dcd7835c Branch: release-0.10.0-rc2 (see https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git) The release artifacts to be voted on can be found at: