Re: TLF Unit Tests

2015-01-25 Thread Harbs
On Jan 25, 2015, at 9:06 AM, Justin Mclean wrote: >> 5) UN Universal Declaration of Human Rights > > This is copyright UN [1] according to copyright link at bottom of page [2] > which AFAIK hasn't expired. It’s actually a very small portion which is used in this file: sampleArabic.xml. I dou

Re: TLF version control/license issues

2015-01-25 Thread Alex Harui
Thanks for the list. I haven’t looked to verify any of it. Let’s discuss the alice.xml file header. It still seems to me that having the Apache header is correct as the text was significantly modified to have TextFlow markup in it. I think all that is missing is some comment or text in there pr

Re: TLF version control/license issues

2015-01-25 Thread Harbs
According to the link that Justin provided, there’s no need to add anything to the source file for public domain content. The only thing that should probably be done, is add something to the NOTICE that the tests contain public domain content. Nothing else needs to/should be done. On Jan 25, 2

Re: TLF Unit Tests

2015-01-25 Thread Alex Harui
On 1/25/15, 12:04 AM, "Harbs" wrote: >>The following are Adobe licensed and donated, so they are okay: >>> 1) Text from the Japanese OpenType guide. >> >> The original file is Adobe copyright and wasn't donated. > >This is a small section of the document in Japanese. I don’t think it’s a >prob

Re: TLF version control/license issues

2015-01-25 Thread Alex Harui
On 1/25/15, 12:12 AM, "Harbs" wrote: >According to the link that Justin provided, there’s no need to add >anything to the source file for public domain content. > >The only thing that should probably be done, is add something to the >NOTICE that the tests contain public domain content. Nothing

Re: TLF Unit Tests

2015-01-25 Thread Justin Mclean
Hi, > It’s actually a very small portion which is used in this file: > sampleArabic.xml. Any amount of text is an issue as "fair use" provisions are not universal. > If you have a suggestion here to make it better, feel free to swap out the > content for something else. It needs to be removed

Re: TLF version control/license issues

2015-01-25 Thread Justin Mclean
HI, > According to the link that Justin provided, there’s no need to add anything > to the source file for public domain content. That's incorrect. You can't just replace licenses with an Apache one unless they allow it. > The only thing that should probably be done, is add something to the NO

Re: TLF Unit Tests

2015-01-25 Thread Harbs
I’m familiar with the Hebrew texts out there. There’s a few freely available texts. The differences between them are very minimal. The text in the file has been processed for TLF, and there’s no way it’s going to match up to the text it came from. I’m 100% confident that Adobe did not have acce

Re: TLF version control/license issues

2015-01-25 Thread Justin Mclean
Hi, > Let’s discuss the alice.xml file header. It still seems to me that having > the Apache header is correct as the text was significantly modified to > have TextFlow markup in it. The modification are trivial, and non creative as they basically just adding paragraph marks at the start and en

Re: TLF Unit Tests

2015-01-25 Thread Justin Mclean
Hi, > There’s a few freely available texts. The differences between them are very > minimal. The text in the file has been processed for TLF, and there’s no way > it’s going to match up to the text it came from. Just because a test is freely available doesn't mean it's free of copyright or in

Re: TLF version control/license issues

2015-01-25 Thread Harbs
I’m not really convinced we need attribution at all. The content is not being released as a component of anything. Why can’t we have a general mention in NOTICE? If someone wants to put attribution in the source files, I have no problem with that. It does seem like a waste of effort though. On

Re: TLF Unit Tests

2015-01-25 Thread Harbs
Actually, I stand corrected. A likely source of the text is http://www.mechon-mamre.org/ Their texts are copyrighted. However, the tanach.xml file is not used anywhere, so we should probably remove it. On Jan 25, 2015, at 10:44 AM, Justin Mclean wrote: > Hi, > >> There’s a few freely availa

Re: TLF version control/license issues

2015-01-25 Thread Harbs
I just added the headers to all these files except whatnot.txt which does not require any headers. I also removed the tanach.xml file which is questionable and not needed. As far as the public domain attribution goes, I don’t care which way we go on that. I think anything is fine. On Jan 25, 2

Re: TLF version control/license issues

2015-01-25 Thread Harbs
Why is this a problem? On Jan 25, 2015, at 8:51 AM, Justin Mclean wrote: > Jar in version control: > ./ant/flexUnitTasks.jar > > Swcs in version control: > ./libs/flexunit-cilistener.swc > ./libs/flexunit-uilistener.swc > ./libs/flexunit.swc

Re: [FlexJS] FlexJSStore

2015-01-25 Thread Carlos Rovira
Awesome! :D Congrats for reach this milestone! :) 2015-01-24 21:22 GMT+01:00 jude : > Way to go! > > On Fri, Jan 23, 2015 at 11:12 PM, Angelo Anolin > wrote: > > > Great work Alex! (and to the rest of the guys/gals as well). Keep it up. > > > > On Fri, Jan 23, 2015 at 6:53 PM, OmPrakash Muppir

Re: JAR in TLF svn/git mirror

2015-01-25 Thread piotrz
Alex, There are plenty of tests which are using Arial font in TLF, but removing these ARIAL_FONT.swf wasn't have any wrong impact on our current working tests. I don't know what will happen once I started to fix the rest one - We will see. :) Harbs, I'm not sure whether tanach.xml won't be used

Re: JAR in TLF svn/git mirror

2015-01-25 Thread piotrz
Erik, As for the build. We need these files for TLF Flex unit: flexunit.swc flexunit-cilistener.swc flexunit-uilistener.swc They are part of Apache Flex Unit and for running through ant unit tests we need also flexUnitTasks.jar But maybe I'm wrong and we can replace these jar file to something

Re: JAR in TLF svn/git mirror

2015-01-25 Thread Harbs
I searched the repo for a reference to the file and did not find one. Are there more tests that are not in the repo? On Jan 25, 2015, at 8:51 PM, piotrz wrote: > Harbs, > > I'm not sure whether tanach.xml won't be used somewhere in the rest of the > tests. If it was a license problem I'm ok, b

Re: JAR in TLF svn/git mirror

2015-01-25 Thread piotrz
I know that this file is not used for now, but there are still more than 50 test classes in TLF which need to be fixed. Maybe some of them will require these file, so I would be really carefully removing anything. :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message i

Re: JAR in TLF svn/git mirror

2015-01-25 Thread Harbs
Where are these tests that need fixing? I’ll be happy to check whether the tanach.xml text is needed. On Jan 25, 2015, at 9:14 PM, piotrz wrote: > I know that this file is not used for now, but there are still more than 50 > test classes in TLF which need to be fixed. Maybe some of them will re

Re: JAR in TLF svn/git mirror

2015-01-25 Thread piotrz
Look into the module automation_tests and folders: automation_tests\src\UnitTest\Tests\ automation_tests\src\UnitTest\PerformanceTests\ All classes from these folders which are not in AllTestsSuite class need to be fixed/rewritten for Flex Unit 4. Piotr - Apache Flex PMC piotrzarzyck...@g

Re: JAR in TLF svn/git mirror

2015-01-25 Thread Harbs
Okay. I already searched all those files, and there was no reference to tanach.xml. I think we’re okay. If we do need extensive Hebrew texts for testing, I’ll be happy to put something together when we do. On Jan 25, 2015, at 9:24 PM, piotrz wrote: > Look into the module automation_tests and

Re: JAR in TLF svn/git mirror

2015-01-25 Thread piotrz
No problem :) I will ping you once we will require this. :) Thank you, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/JAR-in-TLF-svn-git-mirror-tp44554p44643.html Sent from the Apache Flex Development

Re: [DISCUSS] Release Apache Flex 4.14.0

2015-01-25 Thread piotrz
I've just tried to build with Approval script SDK and it's faile, but actually I don't know what these error mean. http://images.devs-on.net/Image/F45NuFBPL8CHYxWc-Obszar.png If I shouldn't care about it I will vote +1, because all mustella tests seems to be passed. Piotr - Apache Flex P

Re: [DISCUSS] Release Apache Flex 4.14.0

2015-01-25 Thread Dave Fisher
Hi - Guys - please. If there is a legitimate question about a given file's provenance then please do make that query in private or in public. Find the commit in the log, watch commit emails and call for it at the time. If there is a singular file here or there that is problematic then it is a

Re: [DISCUSS] Release Apache Flex 4.14.0

2015-01-25 Thread Alex Harui
On 1/25/15, 12:21 PM, "piotrz" wrote: >I've just tried to build with Approval script SDK and it's faile, but >actually I don't know what these error mean. > >http://images.devs-on.net/Image/F45NuFBPL8CHYxWc-Obszar.png > >If I shouldn't care about it I will vote +1, because all mustella tests >s

Re: [DISCUSS] Release Apache Flex 4.14.0

2015-01-25 Thread Justin Mclean
HI, It looks to me that the TLF code didn't get a good IP review after donation, I've counted 50+ IP violations in the code in version control. Some of these have already been fixed in the last couple of days. While rat has been run on the release it looks like it's never been run on the repo

Re: [VOTE] Apache Flex SDK 4.14.0 RC2

2015-01-25 Thread Mark Kessler
+1 (binding) Built successfully from source OS: Windows 7 64bit Java: 1.8 64 bit Player Global: 14.0 Compiled small test applications successfully... using both source locally built and distributed binaries. -Mark On Fri, Jan 23, 2015 at 7:17 AM, Erik de Bruin wrote: > Hi, > > This is a Ap

Re: JAR in TLF svn/git mirror

2015-01-25 Thread Alex Harui
On 1/25/15, 10:51 AM, "piotrz" wrote: >Alex, > >There are plenty of tests which are using Arial font in TLF, but removing >these ARIAL_FONT.swf wasn't have any wrong impact on our current working >tests. I don't know what will happen once I started to fix the rest one - >We >will see. :) It di

Re: [DISCUSS] Release Apache Flex 4.14.0

2015-01-25 Thread Alex Harui
On 1/25/15, 2:28 PM, "Justin Mclean" wrote: > >While rat has been run on the release it looks like it's never been run >on the repo as a whole, as only part of that repo is currently used in >the SDK release. So thankfully none of these files in question are in the >release candidate under consi

Re: TLF version control/license issues

2015-01-25 Thread Alex Harui
On 1/25/15, 12:42 AM, "Justin Mclean" wrote: >Hi, > >> Let’s discuss the alice.xml file header. It still seems to me that >>having >> the Apache header is correct as the text was significantly modified to >> have TextFlow markup in it. > >The modification are trivial, and non creative as they

Re: [VOTE] Apache Flex SDK 4.14.0 RC2

2015-01-25 Thread Justin Mclean
Hi, +1 binding - signatures correct - LICENSE and NOTICE correct - no unexpected binary files in source release - all source file have Apache headers - can compile from source - tests in CI passing - simple mobile, desktop and bowser apps work - RSL work Thanks, Justin

Re: [VOTE] Apache Flex SDK 4.14.0 RC2

2015-01-25 Thread piotrz
+1 (binding) Package https://dist.apache.org/repos/dist/dev/flex/sdk/4.14.0/rc2/apache-flex-sdk-4.14.0-src.zip Java 1.8 OS: Windows 7 amd64 6.1 Source kit signatures match: y Source kit builds: y README is ok: y RELEASE_NOTES is ok: y NOTICE is ok: y LICENSE is ok: y No unapproved licenses or archi

Installer error rate with 4.14 RC

2015-01-25 Thread Justin Mclean
Hi, JFYI The installer error rate for 4.14 RCs looks higher than normal (at about 50%) and there a new error I've not seen before: "no processor for formatnull" There's no errors other than that one above that particularly stands out. Justin

Re: Installer error rate with 4.14 RC

2015-01-25 Thread Justin Mclean
Hi, On the up side, 4.13.0 has had almost 18,000 installs via the installer. Justin

Re: Build failed in Jenkins: flex-tlf #316

2015-01-25 Thread Harbs
We’ve now had two failures of TLF since removing the Arial font. The tests all pass on my local machine though. Any ideas why the tests are failing on the CI server? On Jan 26, 2015, at 8:55 AM, flex.ci.bui...@gmail.com wrote: > See >

Re: Installer error rate with 4.14 RC

2015-01-25 Thread Alex Harui
On 1/25/15, 11:42 PM, "Justin Mclean" wrote: >Hi, > >JFYI > >The installer error rate for 4.14 RCs looks higher than normal (at about >50%) and there a new error I've not seen before: >"no processor for formatnull" What are the stats since RC2 was announced? Prior to that, there was a day or