Re: Shift Enter in TLF

2013-09-03 Thread Alex Harui
Excellent! On 9/3/13 5:11 AM, "Harbs" wrote: >Okay. I pushed my changes out. > >I added a flag in Configuration with three levels. Default is always soft >returns, but it could be changed by the user both at the class level >(using tlf_internal) and in the individual configuration object. I don'

RE: Shift Enter in TLF

2013-09-03 Thread Frédéric THOMAS
Nice, thanks :-) -Message d'origine- De : Harbs [mailto:harbs.li...@gmail.com] Envoyé : mardi 3 septembre 2013 14:28 À : dev@flex.apache.org Objet : Re: Shift Enter in TLF Yup. That's how it works. On Mac, Command Z invokes undo and both Command Y and Command/Shift Z now i

Re: Shift Enter in TLF

2013-09-03 Thread Harbs
> -Message d'origine- > De : Harbs [mailto:harbs.li...@gmail.com] > Envoyé : mardi 3 septembre 2013 14:11 > À : dev@flex.apache.org > Objet : Re: Shift Enter in TLF > > Okay. I pushed my changes out. > > I added a flag in Configuration with three levels. D

RE: Shift Enter in TLF

2013-09-03 Thread Frédéric THOMAS
Windows users should redo with CTRL+Y -Message d'origine- De : Harbs [mailto:harbs.li...@gmail.com] Envoyé : mardi 3 septembre 2013 14:11 À : dev@flex.apache.org Objet : Re: Shift Enter in TLF Okay. I pushed my changes out. I added a flag in Configuration with three levels. Defau

Re: Shift Enter in TLF

2013-09-03 Thread Harbs
Okay. I pushed my changes out. I added a flag in Configuration with three levels. Default is always soft returns, but it could be changed by the user both at the class level (using tlf_internal) and in the individual configuration object. I don't know if the user needs that level of control, bu

Re: Shift Enter in TLF

2013-09-02 Thread Alex Harui
On 9/2/13 1:03 PM, "Harbs" wrote: >I've done both the shift return and command+shift z for redo. I've tested >on Mac. I'll try to test on Windows before I commit. > >Question: How should shift-return behave within lists? Should they behave >like regular paragraphs where it only inserts a soft r

Re: Shift Enter in TLF

2013-09-02 Thread Harbs
I've done both the shift return and command+shift z for redo. I've tested on Mac. I'll try to test on Windows before I commit. Question: How should shift-return behave within lists? Should they behave like regular paragraphs where it only inserts a soft return, or should it create a hard return

Re: Shift Enter in TLF

2013-09-02 Thread Harbs
FYI this makes it work correctly in the current development build as well: ContainerController.tlf_internal::usesDiscretionaryHyphens = false;

Re: Shift Enter in TLF

2013-09-02 Thread Harbs
Here's a test case to make your life easier. Place your cursor after any of the line breaks and hit the delete key on Mac (which I think is the backspace key on Windows). It works correctly in 4.10.0, but does not work correctly in the develop branch code. http://ns.adobe.com/mxml/2009";

Re: Shift Enter in TLF

2013-09-02 Thread Harbs
Okay. Here's the deal: If your line return has text after it, the line return acts like any other character, but if you put your cursor at the end of the paragraph and delete(backspace) the text until you get to the line return, the line return will not get deleted. You can see the behavior in

Re: Shift Enter in TLF

2013-09-02 Thread Harbs
Never mind. I'm not seeing the problem in that test app. I'll have to figure out how to create a test case later… On Sep 2, 2013, at 6:04 PM, Harbs wrote: > Just pull my test app off here > https://issues.apache.org/jira/browse/FLEX-33693 > > And add in \u2028 somewhere to create a line break.

Re: Shift Enter in TLF

2013-09-02 Thread Harbs
Just pull my test app off here https://issues.apache.org/jira/browse/FLEX-33693 And add in \u2028 somewhere to create a line break. (I think \u000A will do the same.) On Sep 2, 2013, at 5:47 PM, Alex Harui wrote: > Yup, definitely possible. > > If you can make a small test case I will take a l

Re: Shift Enter in TLF

2013-09-02 Thread Alex Harui
Yup, definitely possible. If you can make a small test case I will take a look. For now, set the ContainerController flag to false to get back to old behavior. -Alex On 9/2/13 7:40 AM, "Harbs" wrote: >Alex, > >Is it possible that your latest changes broke the cursor movement for >soft line br

Re: Shift Enter in TLF

2013-09-02 Thread Harbs
Alex, Is it possible that your latest changes broke the cursor movement for soft line breaks? Here's the behavior I'm seeing in 4.10.0: With a line break (no new paragraph), and the cursor at the beginning of the new line I'm seeing the following: A backspace will delete the line break Left ar

Re: Shift Enter in TLF

2013-09-01 Thread Harbs
On Sep 1, 2013, at 5:59 PM, Alex Harui wrote: > If not static how will someone change the value? Something like this: var em:EditManager = new EditManager(new UndoManager()); em.tlf_internal::handleShiftAsSoftReturn = false; textFlow.interactionManager = em; (or it can be a proper attribute) >

Re: Shift Enter in TLF

2013-09-01 Thread Alex Harui
If not static how will someone change the value? Redo key seems platform specific. Y is default on windows? Sent via the PANTECH Discover, an AT&T 4G LTE smartphone. Harbs wrote: Okay. As soon as I manage to build the SDK I'll be able to test my changes… I'm putting the flag into EditManag

Re: Shift Enter in TLF

2013-09-01 Thread Harbs
Okay. As soon as I manage to build the SDK I'll be able to test my changes… I'm putting the flag into EditManager rather than ContainerController. That seems to make more sense to me. Please raise objections if you disagree. Also, should the flag be static, or does it make sense to make it a pro

Re: Shift Enter in TLF

2013-08-31 Thread Alex Harui
OK, pushed my changes. Have fun. On 8/31/13 9:40 PM, "Alex Harui" wrote: > > >On 8/31/13 9:31 PM, "Harbs" wrote: > >>Do you mean the user would have to manually set back the version number >>when they compile? >> >>That does sound like a bitter pill to swallow. Setting internal variables >>sou

Re: Shift Enter in TLF

2013-08-31 Thread Alex Harui
On 8/31/13 9:31 PM, "Harbs" wrote: >Do you mean the user would have to manually set back the version number >when they compile? > >That does sound like a bitter pill to swallow. Setting internal variables >sounds much more palatable to me. > >I'll create an internal bool handleShiftAsSoftReturn

Re: Shift Enter in TLF

2013-08-31 Thread Harbs
Do you mean the user would have to manually set back the version number when they compile? That does sound like a bitter pill to swallow. Setting internal variables sounds much more palatable to me. I'll create an internal bool handleShiftAsSoftReturn which will default to true. Makes sense?

Re: Shift Enter in TLF

2013-08-30 Thread Alex Harui
On 8/30/13 4:58 PM, "Justin Mclean" wrote: >Hi, > >Would a check on the SDK version number be a better way to handle this? That was Adobe policy, but it meant you had to go back to old code paths for any other paths changed in that version as well. IMO, that was too big a pill to swallow for s

Re: Shift Enter in TLF

2013-08-30 Thread Justin Mclean
Hi, Would a check on the SDK version number be a better way to handle this? Justin

Re: Shift Enter in TLF

2013-08-30 Thread Alex Harui
I'm ok with that, but please consider leaving the old code paths based on some flag for folks who may rely on the old behavior. I'm about to check in a bunch of changes to handle discretionary hyphens and put a tlf_internal flag in ContainerController to switch it off and on. -Alex On 8/30/13 2:

Re: Shift Enter in TLF

2013-08-30 Thread OmPrakash Muppirala
On Aug 30, 2013 2:36 AM, "Harbs" wrote: > > Currently, TLF (or rather EditManager.as) treats shift-enter as a regular return unless the context is in a ListElement. When the context is a ListElement, it does not create a new list item, but it does create a new paragraph. > > The general convention