Okay. As soon as I manage to build the SDK I'll be able to test my changes…
I'm putting the flag into EditManager rather than ContainerController. That seems to make more sense to me. Please raise objections if you disagree. Also, should the flag be static, or does it make sense to make it a property of the class instance? (That way different EditManagers in the same app could have different behaviors.) I don't really see a use case to having different behaviors in the same app… (but then again I don't see why someone wouldn't want to allow soft returns…) ;-) Once I'm making changes to EditManager, what about enabling shift+ command/control Z for redo? Currently, you need to use command/control y instead of the more standard shift modifier. Is there any reason that I'm not aware of that makes enabling the shift modifier a bad idea? Harbs On Sep 1, 2013, at 7:52 AM, Alex Harui wrote: > OK, pushed my changes. Have fun. > > On 8/31/13 9:40 PM, "Alex Harui" <aha...@adobe.com> wrote: > >> >> >> On 8/31/13 9:31 PM, "Harbs" <harbs.li...@gmail.com> wrote: >> >>> Do you mean the user would have to manually set back the version number >>> when they compile? >>> >>> That does sound like a bitter pill to swallow. Setting internal variables >>> sounds much more palatable to me. >>> >>> I'll create an internal bool handleShiftAsSoftReturn which will default >>> to true. >>> >>> Makes sense? >> Yep, that's what I would do. >> >> >> Let me check in my most recent changes to support discretionary hyphens >> before you get started so we don't get merge conflicts. >> >> -Alex >> >
