I've done both the shift return and command+shift z for redo. I've tested on Mac. I'll try to test on Windows before I commit.
Question: How should shift-return behave within lists? Should they behave like regular paragraphs where it only inserts a soft return, or should it create a hard return without creating a new list item? I'm coming from InDesign where a new paragraph is always a new list item. Unless you break the list completely, you need a soft return to break a list item. I'd like to mimic the InDesign paradigm. Any objections? Does it need an option to change the behavior? If yes, would IConfiguration be a good place to set that? Harbs On Sep 1, 2013, at 1:47 PM, Harbs wrote: > Okay. As soon as I manage to build the SDK I'll be able to test my changes… > > I'm putting the flag into EditManager rather than ContainerController. That > seems to make more sense to me. Please raise objections if you disagree. > Also, should the flag be static, or does it make sense to make it a property > of the class instance? (That way different EditManagers in the same app could > have different behaviors.) I don't really see a use case to having different > behaviors in the same app… (but then again I don't see why someone wouldn't > want to allow soft returns…) ;-) > > Once I'm making changes to EditManager, what about enabling shift+ > command/control Z for redo? Currently, you need to use command/control y > instead of the more standard shift modifier. Is there any reason that I'm not > aware of that makes enabling the shift modifier a bad idea? > > Harbs > > On Sep 1, 2013, at 7:52 AM, Alex Harui wrote: > >> OK, pushed my changes. Have fun. >> >> On 8/31/13 9:40 PM, "Alex Harui" <aha...@adobe.com> wrote: >> >>> >>> >>> On 8/31/13 9:31 PM, "Harbs" <harbs.li...@gmail.com> wrote: >>> >>>> Do you mean the user would have to manually set back the version number >>>> when they compile? >>>> >>>> That does sound like a bitter pill to swallow. Setting internal variables >>>> sounds much more palatable to me. >>>> >>>> I'll create an internal bool handleShiftAsSoftReturn which will default >>>> to true. >>>> >>>> Makes sense? >>> Yep, that's what I would do. >>> >>> >>> Let me check in my most recent changes to support discretionary hyphens >>> before you get started so we don't get merge conflicts. >>> >>> -Alex >>> >> >
