Re: [dpdk-dev] [PATCH 00/10] Infrastructure to detect iova mapping on the bus

2017-07-03 Thread santosh
Hi, On Thursday 08 June 2017 04:35 PM, Santosh Shukla wrote: > Q) Why do we need such infrastructure? > > A) Some NPU hardware like OCTEONTX follows push model to get the packet > from the pktio device. Where packet allocation and freeing done > by the HW. Since HW can operate on

Re: [dpdk-dev] [PATCH 00/10] Infrastructure to detect iova mapping on the bus

2017-07-04 Thread santosh
Hi Thomas, On Tuesday 04 July 2017 12:49 PM, Thomas Monjalon wrote: > 04/07/2017 06:41, santosh: >> Ping? > You should try to ping Sergio, memory maintainer, > and Anatoly, VFIO maintainer. > > Given that > - there is no review at all, By default if no review then its m

Re: [dpdk-dev] [PATCH 00/10] Infrastructure to detect iova mapping on the bus

2017-07-04 Thread santosh
On Tuesday 04 July 2017 02:33 PM, Thomas Monjalon wrote: > 04/07/2017 09:57, santosh: >> Hi Thomas, >> >> On Tuesday 04 July 2017 12:49 PM, Thomas Monjalon wrote: >> >>> 04/07/2017 06:41, santosh: >>>> Ping? >>> You should try to ping Se

Re: [dpdk-dev] [PATCH 00/10] Infrastructure to detect iova mapping on the bus

2017-07-04 Thread santosh
On Tuesday 04 July 2017 03:40 PM, Thomas Monjalon wrote: > Hi Santosh, > Let's try to make this proposal clearer in order to have some reviews. > > 08/06/2017 13:05, Santosh Shukla: >> Q) Why do we need such infrastructure? >> >> A) Some NPU hardware like OCT

Re: [dpdk-dev] [PATCH 0/2] Allow application set mempool handle

2017-07-04 Thread santosh
Hi Olivier, On Friday 30 June 2017 07:42 PM, Olivier Matz wrote: > Hi, > > On Tue, 20 Jun 2017 19:34:15 +0530, Jerin Jacob > wrote: >> -Original Message- >>> Date: Tue, 20 Jun 2017 16:07:17 +0530 >>> From: Hemant Agrawal >>> To: Jerin J

Re: [dpdk-dev] [PATCH 1/2] eal: Introducing option to set mempool handle

2017-07-04 Thread santosh
Hi Olivier, On Friday 30 June 2017 07:42 PM, Olivier Matz wrote: > Hi Santosh, > > On Thu, 1 Jun 2017 13:35:58 +0530, Santosh Shukla > wrote: >> Platform can have external PCI cards like Intel 40G card and >> Integrated NIC like OcteoTX. Where both NIC has their

Re: [dpdk-dev] [PATCH 2/2] ether/ethdev: Allow pmd to advertise preferred pool capability

2017-07-04 Thread santosh
On Friday 30 June 2017 07:43 PM, Olivier Matz wrote: > On Thu, 1 Jun 2017 13:35:59 +0530, Santosh Shukla > wrote: >> Platform with two different NICs like external PCI NIC and >> Integrated NIC, May want to use their preferred pool handle. >> Right now there is no way

Re: [dpdk-dev] [PATCH 1/4] mempool: get the external mempool capability

2017-07-04 Thread santosh
Hi Olivier, On Monday 03 July 2017 10:07 PM, Olivier Matz wrote: > Hi Santosh, > > On Wed, 21 Jun 2017 17:32:45 +, Santosh Shukla > wrote: >> Allow external mempool to advertise its capability. >> A handler been introduced called rte_mempool_ops_get_hw_cap. >

Re: [dpdk-dev] [PATCH 2/4] mempool: detect physical contiguous object in pool

2017-07-05 Thread santosh
Hi Olivier, On Monday 03 July 2017 10:07 PM, Olivier Matz wrote: > On Wed, 21 Jun 2017 17:32:46 +0000, Santosh Shukla > wrote: >> HW mempool blocks may need physical contiguous obj in a pool. > This should be clarified: the memory area containing all the > objects must be phy

Re: [dpdk-dev] [PATCH 3/4] mempool: introduce block size align flag

2017-07-05 Thread santosh
Hi Olivier, On Monday 03 July 2017 10:07 PM, Olivier Matz wrote: > On Wed, 21 Jun 2017 17:32:47 +0000, Santosh Shukla > wrote: >> Some mempool hw like octeontx/fpa block, demands block size aligned >> buffer address. >> > What is the meaning of block size aligned?

Re: [dpdk-dev] [PATCH 0/2] Allow application set mempool handle

2017-07-05 Thread santosh
Hi Olivier, On Tuesday 04 July 2017 09:29 PM, Olivier Matz wrote: > Hi Santosh, > > On Tue, 4 Jul 2017 17:55:54 +0530, santosh > wrote: >> Hi Olivier, >> >> On Friday 30 June 2017 07:42 PM, Olivier Matz wrote: >> >>> Hi, >>> >>&

Re: [dpdk-dev] [PATCH 00/10] Infrastructure to detect iova mapping on the bus

2017-07-05 Thread santosh
Hi Maxime, On Wednesday 05 July 2017 03:00 PM, Maxime Coquelin wrote: > > On 06/08/2017 01:05 PM, Santosh Shukla wrote: >> Q) Why do we need such infrastructure? >> >> A) Some NPU hardware like OCTEONTX follows push model to get the packet >> from the pktio devic

Re: [dpdk-dev] [PATCH 02/10] linuxapp/eal_pci: get iommu class

2017-07-05 Thread santosh
On Wednesday 05 July 2017 01:47 PM, Maxime Coquelin wrote: > > On 06/08/2017 01:05 PM, Santosh Shukla wrote: >> Get iommu class of PCI device on the bus and returns preferred iova >> mapping mode for that bus. >> >> IOVA mapping scheme for linuxapp case: >

Re: [dpdk-dev] [PATCH 05/10] linuxapp/eal: detect iova mode

2017-07-05 Thread santosh
Hi Hemant, On Wednesday 05 July 2017 06:47 PM, Hemant Agrawal wrote: > On 6/8/2017 4:35 PM, Santosh Shukla wrote: >> - Moving late bus scanning to up..just after eal_parsing. >> - Detect iova mapping mode based on user provided eal option >> (rte_eal_iov

Re: [dpdk-dev] [PATCH v7 1/6] bus: fix driver registration

2017-07-05 Thread santosh
e its device drivers. > > Fixes: 0fd1a0eaae19 ("pci: add bus driver") > Fixes: fea892e35f21 ("bus/vdev: use standard bus registration") > Fixes: 7e7df6d0a41d ("bus/fslmc: introduce fsl-mc bus driver") > > Signed-off-by: Thomas Monjalon > --- LGTM, Reviewed-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v7 2/6] bus: introduce parsing functionality

2017-07-06 Thread santosh
Hi Gaetan, On Wednesday 05 July 2017 05:25 AM, Gaetan Rivet wrote: > This operation can be used either to validate that a device > representation can be understood by a bus, as well as store the resulting > specialized device representation in any format determined by the bus. > > Signed-off-by:

Re: [dpdk-dev] [PATCH v7 3/6] vdev: implement parse bus operation

2017-07-06 Thread santosh
On Wednesday 05 July 2017 05:25 AM, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- LGTM, Reviewed-by: Santosh Shukla

Re: [dpdk-dev] [PATCH 07/10] linuxapp/eal_vfio: honor iova mode before mapping

2017-07-06 Thread santosh
On Thursday 06 July 2017 04:29 PM, Maxime Coquelin wrote: > > On 07/06/2017 11:49 AM, Jerin Jacob wrote: >> -Original Message- >>> Date: Thu, 6 Jul 2017 09:58:41 +0200 >>> From: Maxime Coquelin >>> To: Jerin Jacob >>> CC: Santosh S

Re: [dpdk-dev] [PATCH v7 2/6] bus: introduce parsing functionality

2017-07-06 Thread santosh
On Thursday 06 July 2017 06:00 PM, Gaëtan Rivet wrote: > On Thu, Jul 06, 2017 at 02:49:41PM +0530, santosh wrote: >> Hi Gaetan, >> >> On Wednesday 05 July 2017 05:25 AM, Gaetan Rivet wrote: >> >>> This operation can be used either to validate that a device >

Re: [dpdk-dev] [PATCH 07/10] linuxapp/eal_vfio: honor iova mode before mapping

2017-07-06 Thread santosh
On Thursday 06 July 2017 06:41 PM, Maxime Coquelin wrote: > > On 07/06/2017 03:08 PM, Maxime Coquelin wrote: >> >> >> On 07/06/2017 01:19 PM, santosh wrote: >>> On Thursday 06 July 2017 04:29 PM, Maxime Coquelin wrote: >>> >>>> >>>&

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread santosh
Hi Olivier, On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: > On Mon, 10 Jul 2017 11:42:34 +0000, Santosh Shukla > wrote: >> Check iova mode and accordingly return phy addr. >> >> Signed-off-by: Santosh Shukla >> Signed-off-by: Jerin Jacob >> ---

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread santosh
On Monday 10 July 2017 07:21 PM, Thomas Monjalon wrote: > 10/07/2017 15:30, santosh: >> Hi Olivier, >> >> On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: >>> I didn't check the patchset in detail, but in my understanding, >>> what we call physaddr

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread santosh
On Monday 10 July 2017 07:39 PM, Thomas Monjalon wrote: > 10/07/2017 15:56, santosh: >> On Monday 10 July 2017 07:21 PM, Thomas Monjalon wrote: >> >>> 10/07/2017 15:30, santosh: >>>> Hi Olivier, >>>> >>>> On Monday 10 July 2017 05:57

Re: [dpdk-dev] [PATCH 1/4] mempool: get the external mempool capability

2017-07-10 Thread santosh
On Monday 10 July 2017 07:25 PM, Olivier Matz wrote: > On Wed, 5 Jul 2017 12:11:52 +0530, santosh > wrote: >> Hi Olivier, >> >> On Monday 03 July 2017 10:07 PM, Olivier Matz wrote: >> >>> Hi Santosh, >>> >>> On Wed, 21 Jun 2017 17:32:45

Re: [dpdk-dev] [PATCH 3/4] mempool: introduce block size align flag

2017-07-10 Thread santosh
On Monday 10 July 2017 06:45 PM, Olivier Matz wrote: > On Wed, 5 Jul 2017 13:05:57 +0530, santosh > wrote: >> Hi Olivier, >> >> On Monday 03 July 2017 10:07 PM, Olivier Matz wrote: >> >>> On Wed, 21 Jun 2017 17:32:47 +, Santosh Shukla >>>

Re: [dpdk-dev] [PATCH v3 01/11] eal/pci: introduce PCI driver iova as va flag

2017-07-11 Thread santosh
Hi Maxime, On Tuesday 11 July 2017 02:39 PM, Maxime Coquelin wrote: > > > On 07/11/2017 08:16 AM, Santosh Shukla wrote: >> Introducing RTE_PCI_DRV_NEED_IOVA_VA flag. Flag used when driver needs >> to operate in iova=va mode. >> >> Why driver need iova=va mapping?

Re: [dpdk-dev] [PATCH v3 03/11] bsdapp/eal_pci: get iommu class

2017-07-11 Thread santosh
On Tuesday 11 July 2017 02:45 PM, Maxime Coquelin wrote: > > On 07/11/2017 08:16 AM, Santosh Shukla wrote: >> diff --git a/lib/librte_eal/common/include/rte_bus.h >> b/lib/librte_eal/common/include/rte_bus.h >> index af9f0e13f..7a0cfb165 100644 >> --- a/lib/librt

Re: [dpdk-dev] [PATCH v3 04/11] linuxapp/eal_pci: get iommu class

2017-07-11 Thread santosh
On Tuesday 11 July 2017 02:53 PM, Maxime Coquelin wrote: > > On 07/11/2017 08:16 AM, Santosh Shukla wrote: >> Get iommu class of PCI device on the bus and returns preferred iova >> mapping mode for that bus. >> >> Algorithm for iova scheme selection for PCI bus: >

Re: [dpdk-dev] [PATCH v3 04/11] linuxapp/eal_pci: get iommu class

2017-07-13 Thread santosh
Hi Sergio, On Wednesday 12 July 2017 01:50 PM, Sergio Gonzalez Monroy wrote: > On 11/07/2017 07:16, Santosh Shukla wrote: >> Get iommu class of PCI device on the bus and returns preferred iova >> mapping mode for that bus. >> >> Algorithm for iova scheme selection

Re: [dpdk-dev] [PATCH v3 07/11] linuxapp/eal: auto detect iova mode

2017-07-13 Thread santosh
On Thursday 13 July 2017 04:59 PM, Hemant Agrawal wrote: > On 7/11/2017 11:46 AM, Santosh Shukla wrote: >> - Moving late bus scanning to up..just after eal_parsing. >> - Auto detect iova mapping mode, based on the result of >> rte_bus_scan_iommu_class. >> >&

Re: [dpdk-dev] [PATCH v3 ] ethdev: introduce lock-free txq capability flag

2017-07-13 Thread santosh
ly completed. > * > + * If the PMD is DEV_TX_OFFLOAD_MT_LOCKFREE capable, multiple threads can > + * invoke this function concurrently on the same tx queue without SW lock. > + * @see rte_eth_dev_info_get, struct rte_eth_txconf::txq_flags > + * > * @param port_id > * The port identifier of the Ethernet device. > * @param queue_id Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v3 04/11] linuxapp/eal_pci: get iommu class

2017-07-14 Thread santosh
On Friday 14 July 2017 01:09 PM, Hemant Agrawal wrote: > On 7/11/2017 11:46 AM, Santosh Shukla wrote: >> Get iommu class of PCI device on the bus and returns preferred iova >> mapping mode for that bus. >> >> Algorithm for iova scheme selection for PCI bus: >> 0.

Re: [dpdk-dev] [PATCH v3 04/11] linuxapp/eal_pci: get iommu class

2017-07-14 Thread santosh
Hi Sergio, On Friday 14 July 2017 01:13 PM, Sergio Gonzalez Monroy wrote: > On 13/07/2017 09:23, santosh wrote: >> Hi Sergio, >> >> On Wednesday 12 July 2017 01:50 PM, Sergio Gonzalez Monroy wrote: >> >>> On 11/07/2017 07:16, Santosh Shukla wrote: >>&

Re: [dpdk-dev] [PATCH v3 05/11] bus: get iommu class

2017-07-14 Thread santosh
On Friday 14 July 2017 01:37 PM, Hemant Agrawal wrote: > On 7/11/2017 11:46 AM, Santosh Shukla wrote: >> API(rte_bus_get_iommu_class) helps to automatically detect and select >> appropriate iova mapping scheme for iommu capable device on that bus. >> >> Algorithm for io

Re: [dpdk-dev] [PATCH v3 04/11] linuxapp/eal_pci: get iommu class

2017-07-14 Thread santosh
On Friday 14 July 2017 01:36 PM, Hemant Agrawal wrote: > On 7/14/2017 1:25 PM, santosh wrote: >> On Friday 14 July 2017 01:09 PM, Hemant Agrawal wrote: >> >>> On 7/11/2017 11:46 AM, Santosh Shukla wrote: >>>> Get iommu class of PCI device on the bus and retu

Re: [dpdk-dev] [PATCH v3 04/11] linuxapp/eal_pci: get iommu class

2017-07-14 Thread santosh
On Friday 14 July 2017 02:16 PM, santosh wrote: > On Friday 14 July 2017 01:36 PM, Hemant Agrawal wrote: > >> On 7/14/2017 1:25 PM, santosh wrote: >>> On Friday 14 July 2017 01:09 PM, Hemant Agrawal wrote: >>> >>>> On 7/11/2017 11:46 AM, Santosh Shukla

Re: [dpdk-dev] [PATCH v3 07/11] linuxapp/eal: auto detect iova mode

2017-07-14 Thread santosh
On Friday 14 July 2017 02:19 PM, Hemant Agrawal wrote: > On 7/13/2017 11:55 PM, santosh wrote: >> On Thursday 13 July 2017 04:59 PM, Hemant Agrawal wrote: >> >>> On 7/11/2017 11:46 AM, Santosh Shukla wrote: >>>> - Moving late bus scanning to up..just after

Re: [dpdk-dev] [PATCH v3 05/11] bus: get iommu class

2017-07-14 Thread santosh
On Friday 14 July 2017 03:09 PM, Hemant Agrawal wrote: > On 7/14/2017 2:00 PM, santosh wrote: >> On Friday 14 July 2017 01:37 PM, Hemant Agrawal wrote: >> >>> On 7/11/2017 11:46 AM, Santosh Shukla wrote: >>>> API(rte_bus_get_iommu_class) helps to automaticall

Re: [dpdk-dev] [PATCH v3 05/11] bus: get iommu class

2017-07-14 Thread santosh
On Friday 14 July 2017 03:52 PM, santosh wrote: > On Friday 14 July 2017 03:09 PM, Hemant Agrawal wrote: > >> On 7/14/2017 2:00 PM, santosh wrote: >>> On Friday 14 July 2017 01:37 PM, Hemant Agrawal wrote: >>> >>>> On 7/11/2017 11:46 AM, Santosh Shukl

Re: [dpdk-dev] [PATCH v3 05/11] bus: get iommu class

2017-07-14 Thread santosh
On Friday 14 July 2017 04:21 PM, Hemant Agrawal wrote: > On 7/14/2017 3:59 PM, santosh wrote: >> On Friday 14 July 2017 03:52 PM, santosh wrote: >> >>> On Friday 14 July 2017 03:09 PM, Hemant Agrawal wrote: >>> >>>> On 7/14/2017 2:00 PM, santosh

Re: [dpdk-dev] [PATCH v2 0/6] Infrastructure to support octeontx HW mempool manager

2017-07-17 Thread santosh
On Thursday 13 July 2017 03:02 PM, Santosh Shukla wrote: > v2: > (Note: v2 work is based on deprecation notice [1], It's for 17.11) > > In order to support octeontx HW mempool manager, the common mempool layer must > meet below condition. > - Object start address should be

Re: [dpdk-dev] [PATCH v4 06/12] bus: get iommu class

2017-07-18 Thread santosh
Hi Hemant, On Tuesday 18 July 2017 04:35 PM, Hemant Agrawal wrote: > On 7/18/2017 11:29 AM, Santosh Shukla wrote: >> API(rte_bus_get_iommu_class) helps to automatically detect and select >> appropriate iova mapping scheme for iommu capable device on that bus. >> >>

Re: [dpdk-dev] [PATCH v4 08/12] linuxapp/eal: auto detect iova mode

2017-07-18 Thread santosh
On Tuesday 18 July 2017 05:04 PM, Hemant Agrawal wrote: > On 7/18/2017 11:29 AM, Santosh Shukla wrote: >> - Moving late bus scanning to up..just after eal_parsing. >> - Auto detect iova mapping mode, based on the result of >> rte_bus_scan_iommu_class. >> >&

Re: [dpdk-dev] [PATCH] mempool: add notice to change mempool API/ABI

2017-07-20 Thread santosh
On Thursday 20 July 2017 02:16 PM, Olivier Matz wrote: > On Thu, 13 Jul 2017 09:12:31 +0000, Santosh Shukla > wrote: >> [PATCH] mempool: add notice to change mempool API/ABI > I think the usual titles for these notices are more: > > doc: announce API/ABI changes for mempo

Re: [dpdk-dev] [PATCH v2] doc: announce API/ABI changes for mempool

2017-07-20 Thread santosh
On Thursday 20 July 2017 03:59 PM, Santosh Shukla wrote: > An API/ABI change is planned for 17.11 to change following > > * Remove unused flag param from rte_mempool_generic_get and _put. > * Change data type for mempool 'flag' from int to unsigned int. > Refer [1]. &

Re: [dpdk-dev] [PATCH] eal: add notice to make DPDK IOVA aware

2017-07-20 Thread santosh
On Tuesday 11 July 2017 03:31 PM, Jerin Jacob wrote: > When we run DPDK on guest or VFIO mode on host, > the dpdk library or device will not be directly accessing > the physical address. Instead, the device does go through > an IO address translation memory management unit. On x86, > we call it as

Re: [dpdk-dev] [PATCH v2] doc: announce API/ABI changes for mempool

2017-08-03 Thread santosh
On Thursday 03 August 2017 07:51 PM, Jerin Jacob wrote: > -Original Message- >> Date: Thu, 20 Jul 2017 15:59:15 +0530 >> From: Santosh Shukla >> To: olivier.m...@6wind.com, dev@dpdk.org >> CC: thomas.monja...@6wind.com, Santosh Shukla >> >> Subje

Re: [dpdk-dev] [PATCH] eal: add notice to make DPDK IOVA aware

2017-08-03 Thread santosh
_mem_virt2phy() > rte_dump_physmem_layout() > rte_eal_get_physmem_layout() > rte_eal_get_physmem_size() > rte_malloc_virt2phy() > rte_mem_phy2mch() > > > Signed-off-by: Jerin Jacob > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-08-03 Thread santosh
Hi Thomas, On Monday 10 July 2017 08:07 PM, Thomas Monjalon wrote: > 10/07/2017 16:22, santosh: >> On Monday 10 July 2017 07:39 PM, Thomas Monjalon wrote: >> >>> 10/07/2017 15:56, santosh: >>>> On Monday 10 July 2017 07:21 PM, Thomas Monjalon wrote:

Re: [dpdk-dev] [PATCH v3 1/2] test/test: free mempool on exit

2017-04-04 Thread santosh
s") > Cc: sta...@dpdk.org > > Signed-off-by: Shreyansh Jain > --- > v3: fix the incorrect split > v2: separte the bug fix from change > > test/test/test_mempool.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Santosh Shukla > diff --git a

Re: [dpdk-dev] [RFC] eal/memory: introducing an option to set iova as va

2017-06-01 Thread santosh
Ping? On Wednesday 24 May 2017 09:41 PM, Santosh Shukla wrote: > Some NPU hardware like OCTEONTX follows push model to get > the packet from the pktio device. Where packet allocation > and freeing done by the HW. Since HW can operate only on > IOVA with help of SMMU/IOMMU, When pac

Re: [dpdk-dev] [RFC] eal/memory: introducing an option to set iova as va

2017-06-04 Thread santosh
Hi Bruce, On Friday 02 June 2017 02:57 PM, Bruce Richardson wrote: > On Fri, Jun 02, 2017 at 09:54:46AM +0530, santosh wrote: >> Ping? >> >> On Wednesday 24 May 2017 09:41 PM, Santosh Shukla wrote: >> >>> Some NPU hardware like OCTEONTX follows push model

Re: [dpdk-dev] [PATCH 1/2] test/test_mbuf: Remove mempool global var

2017-06-04 Thread santosh
On Thursday 11 May 2017 04:00 PM, Santosh Shukla wrote: > Cc: sta...@dpdk.org > Signed-off-by: Santosh Shukla > --- Ping?

Re: [dpdk-dev] [PATCH 2/2] test/test_mbuf: Free mempool on exit

2017-06-04 Thread santosh
On Thursday 11 May 2017 04:00 PM, Santosh Shukla wrote: > Cc: sta...@dpdk.org > Signed-off-by: Santosh Shukla > --- ping?

Re: [dpdk-dev] [PATCH 1/2] test/test_mbuf: Remove mempool global var

2017-06-08 Thread santosh
Hi Olivier, On Thursday 08 June 2017 03:38 PM, Olivier Matz wrote: > Hi Santosh, > > On Thu, 11 May 2017 16:00:43 +0530, Santosh Shukla > wrote: >> Cc: sta...@dpdk.org >> Signed-off-by: Santosh Shukla >> --- &

Re: [dpdk-dev] [PATCH v2] test/test_mbuf: remove mempool global var

2017-06-19 Thread santosh
On Tuesday 20 June 2017 02:07 AM, Thomas Monjalon wrote: > 08/06/2017 16:28, Santosh Shukla: >> Let test_mbuf alloc and free mempool. >> >> Cc: sta...@dpdk.org >> Signed-off-by: Santosh Shukla > Why Cc stable? > Is it fixing something? > w/o this fix, applicat

Re: [dpdk-dev] [PATCH v2] test/test_mbuf: remove mempool global var

2017-06-21 Thread santosh
On Tuesday 20 June 2017 01:05 PM, Thomas Monjalon wrote: > 20/06/2017 06:14, santosh: >> On Tuesday 20 June 2017 02:07 AM, Thomas Monjalon wrote: >> >>> 08/06/2017 16:28, Santosh Shukla: >>>> Let test_mbuf alloc and free mempool. >>>> >>>

Re: [dpdk-dev] [PATCH v2] test/test_mbuf: remove mempool global var

2017-06-21 Thread santosh
Hi Yuanhan, On Tuesday 20 June 2017 01:52 PM, Yuanhan Liu wrote: > On Tue, Jun 20, 2017 at 09:35:07AM +0200, Thomas Monjalon wrote: >> 20/06/2017 06:14, santosh: >>> On Tuesday 20 June 2017 02:07 AM, Thomas Monjalon wrote: >>> >>>> 08/06/2017 16:28, Santos

Re: [dpdk-dev] [PATCH] eal: don't advertise a physical address when no hugepages

2017-06-26 Thread santosh
Hi Olivier, On Friday 23 June 2017 10:38 PM, Jan Blunck wrote: > On Fri, Jun 23, 2017 at 10:11 AM, Olivier Matz wrote: >> Hi Jan, >> >> On Sat, 10 Jun 2017 10:31:22 +0200, Jan Blunck wrote: >>> On Fri, Jun 9, 2017 at 10:29 AM, Olivier Matz >>> wrote: When populating a mempool with a virt

Re: [dpdk-dev] [PATCH v3 2/2] test/test: support default mempool autotest

2017-04-05 Thread santosh
> @@ -606,6 +631,9 @@ static int test_mempool_single_consumer(void) > if (test_mempool_basic(mp_stack, 1) < 0) > goto err; > > + if (test_mempool_basic(default_pool, 1) < 0) > + goto err; > + > rte_mempool_list_dump(stdout); > > ret = 0; > @@ -614,6 +642,8 @@ static int test_mempool_single_consumer(void) > rte_mempool_free(mp_nocache); > rte_mempool_free(mp_cache); > rte_mempool_free(mp_stack); > + rte_mempool_free(default_pool); > + Rest looks okay to me: Reviewed-by: Santosh Shukla > return ret; > } >

Re: [dpdk-dev] [PATCH 1/2] test/mempool_perf: Free mempool on exit

2017-04-05 Thread santosh
Hi Shreyansh, On Wednesday 05 April 2017 03:27 PM, Shreyansh Jain wrote: > Hello Santosh, > On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote: >> Mempool_perf test not freeing pool memory. >> Cc: sta...@dpdk.org >> Signed-off-by: Santosh Shukla >> --- >

Re: [dpdk-dev] [PATCH 2/2] test/mempool_perf: support default mempool autotest

2017-04-05 Thread santosh
Hi Shreyansh, On Wednesday 05 April 2017 03:32 PM, Shreyansh Jain wrote: > Hi Santosh, > On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote: >> Mempool_perf autotest currently does perf regression for: >> * nochache >> * cache >> Introducing default_pool, m

Re: [dpdk-dev] [PATCH v2 1/2] test/mempool_perf: Free mempool on exit

2017-04-09 Thread santosh
Hi Olivier, On Monday 10 April 2017 12:47 AM, Shukla, Santosh wrote: > > > > *From:* Olivier Matz > *Sent:* Friday, April 7, 2017 9:21 PM > *To:* Shukla, Santosh > *Cc:* dev@dpdk.org; h

Re: [dpdk-dev] [PATCH v3 1/3] test/test/mempool_perf: Remove mempool global vars

2017-04-18 Thread santosh
Hi Olivier, On Tuesday 18 April 2017 07:12 PM, Olivier MATZ wrote: > Hi Santosh, > > On Tue, 18 Apr 2017 14:04:46 +0530, Santosh Shukla > wrote: >> Cc: sta...@dpdk.org >> Signed-off-by: Santosh Shukla >> --- >> v3: >> - Cleanup code change as pe

Re: [dpdk-dev] [PATCH] config: set cache line as 128B in the generic arm64 config

2017-04-27 Thread santosh
/config/defconfig_arm64-xgene1-linuxapp-gcc > b/config/defconfig_arm64-xgene1-linuxapp-gcc > index f096166b7..d8e544728 100644 > --- a/config/defconfig_arm64-xgene1-linuxapp-gcc > +++ b/config/defconfig_arm64-xgene1-linuxapp-gcc > @@ -32,3 +32,4 @@ > #include "defconfig_arm64-armv8a-linuxapp-gcc" > > CONFIG_RTE_MACHINE="xgene1" > +CONFIG_RTE_CACHE_LINE_SIZE=64 Acked-by : Santosh Shukla Thanks,!

Re: [dpdk-dev] [PATCH] mempool/octeontx: fix pool to aura mapping

2018-06-27 Thread santosh
> > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla Nits: May be introduce a macro something like #define AURA_IDX(gpool) (gpool << FPA_GAURA_SHIFT) Thanks.

Re: [dpdk-dev] [PATCH v2 2/2] eal: remove experimental tag from user mbuf pool ops func

2018-06-27 Thread santosh
On Tuesday 26 June 2018 03:26 PM, Olivier Matz wrote: > External Email > > Remove experimental tag from rte_eal_mbuf_user_pool_ops(). > > Signed-off-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v2 1/2] eal: remove deprecated function returning mbuf pool ops name

2018-06-27 Thread santosh
On Tuesday 26 June 2018 03:26 PM, Olivier Matz wrote: > External Email > > rte_eal_mbuf_default_mempool_ops() is replaced by > rte_mbuf_best_mempool_ops(). > > Signed-off-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH] event/octeontx: prefetch mbuf instead of wqe

2018-07-17 Thread santosh
On Tuesday 17 July 2018 08:03 PM, Pavan Nikhilesh wrote: > Prefetch mbuf pointer instead of wqe when SSO receives pkt from PKI. > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH] net/octeontx: fix packet corruption on Tx

2018-08-17 Thread santosh
s: 9e747589bd4c ("net/octeontx: add packet transmit burst function") > Cc: sta...@dpdk.org > > Reported-by: Vikas Aggarwal > Signed-off-by: Jerin Jacob > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH] eal: force IOVA mode to physical

2018-08-30 Thread santosh
On Thursday 30 August 2018 05:43 PM, Hemant wrote: > External Email > > Hi, > > On 8/30/2018 3:13 PM, Gaëtan Rivet wrote: >> Hi, >> >> On Thu, Aug 30, 2018 at 10:09:04AM +0100, Burakov, Anatoly wrote: >>> On 29-Aug-18 4:58 PM, eric zhang wrote: This patch adds a configuration option to force

Re: [dpdk-dev] [PATCH] eal: force IOVA mode to physical

2018-08-30 Thread santosh
On Thursday 30 August 2018 07:26 PM, Legacy, Allain wrote: > External Email > >> -Original Message----- >> From: santosh [mailto:santosh.shu...@caviumnetworks.com] >> Sent: Thursday, August 30, 2018 8:59 AM >> To: hemant.agra...@nxp.com; Gaëtan Rivet; Burakov, A

Re: [dpdk-dev] [PATCH] eal: copy optarg when parsing mempool ops name

2018-05-06 Thread santosh
he latter could be clobbered > later and result in reading wrong mbuf pool ops name > by rte_mempool library. > > Typically, this flaw could be avoided by using strdup() > to remember the string value of the option. > > Fixes: a103a97e7191 ("eal: allow user to override default

Re: [dpdk-dev] [PATCH] mbuf: remove experimental tag from pool ops functions

2018-06-11 Thread santosh
ubject: [dpdk-dev] [PATCH] mbuf: remove experimental tag from pool ops >> functions >> X-Mailer: git-send-email 2.7.4 >> >> Signed-off-by: Hemant Agrawal Acked-by: Santosh Shukla Thanks.

Re: [dpdk-dev] [PATCH v4 1/2] drivers: add common folder

2018-04-03 Thread santosh
On Monday 02 April 2018 02:39 PM, Pavan Nikhilesh wrote: > Add driver/common folder and skeleton makefile for adding commonly used > functions across mempool, event and net devices. > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v4 2/2] octeontx: move mbox to common folder

2018-04-03 Thread santosh
reg += SSO_VHGRP_PF_MBOX(1); >> +if (octeontx_mbox_set_reg(reg)) { >> +mbox_log_err("Invalid Failed to set mbox_reg"); >> +return -EINVAL; >> +} >> +} >> + >> rte_wmb(); >> mbox_log_dbg("Domain=%d group=%d total_ssovfs=%d", res->domain, >> res->vfid, sdev.total_ssovfs); > With above changes: > > Acked-by: Jerin Jacob > Acked-by: Santosh Shukla Thanks.

Re: [dpdk-dev] [PATCH v3 03/11] mempool: ensure the mempool is initialized before populating

2018-04-04 Thread santosh
Andrew Rybchenko > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v3 04/11] mempool: add op to calculate memory size to be allocated

2018-04-04 Thread santosh
n accordance with driver requirements and > advertise requirements on minimum memory chunk size and alignment > in a generic way. > > Bump ABI version since the patch breaks it. > > Suggested-by: Olivier Matz > Signed-off-by: Andrew Rybchenko > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v3 05/11] mempool: add op to populate objects using provided memory

2018-04-04 Thread santosh
: Andrew Rybchenko > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v3 06/11] mempool: remove callback to get capabilities

2018-04-04 Thread santosh
icient to describe mempool driver features. If required > in the future, API which returns structured information may be > added. > > Signed-off-by: Andrew Rybchenko > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v3 08/11] mempool/octeontx: prepare to remove register memory area op

2018-04-04 Thread santosh
On Monday 26 March 2018 09:39 PM, Andrew Rybchenko wrote: > Callback to populate pool objects has all required information and > executed a bit later than register memory area callback. > > Signed-off-by: Andrew Rybchenko > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v3 10/11] mempool: remove callback to register memory area

2018-04-04 Thread santosh
On Monday 26 March 2018 09:39 PM, Andrew Rybchenko wrote: > The callback is not required any more since there is a new callback > to populate objects using provided memory area which provides > the same information. > > Signed-off-by: Andrew Rybchenko > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v3 00/68] Memory Hotplug for DPDK

2018-04-05 Thread santosh
ourtesy of Gowrishankar @ IBM > - Fixes for mempool size calculation > - Added convenience memseg walk() API's > - Added alloc validation callback > > v2: - fixed deadlock at init > - reverted rte_panic changes at init, this is now handled inside IPC Tested-by: Santosh Shukla

Re: [dpdk-dev] [RFC PATCH 2/6] mempool: implement clustered object allocation

2018-01-17 Thread santosh
  if (total_elt_sz == 0) >>>   return 0; >>>   +    if (flags & MEMPOOL_F_CAPA_ALLOCATE_IN_CLUSTERS) { >>> +    unsigned int align_shift = >>> +    rte_bsf32( >>> +    rte_align32pow2(total_elt_sz * >>> +    i

Re: [dpdk-dev] [PATCH] mempool/octeontx: fix natural alignment being optimized out

2018-01-18 Thread santosh
ixes: aecb8e093b52 ("event/octeontx: introduce specialized mbox message > copy") > Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v6 1/7] eal: prefix mbuf pool ops name with user defined

2018-01-22 Thread santosh
On Monday 22 January 2018 07:21 PM, Hemant Agrawal wrote: > This patch prefix the mbuf pool ops name with "user" to indicate > that it is user defined. > > Signed-off-by: Hemant Agrawal > Acked-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v6 2/7] mbuf: maintain user and compile time mempool ops name

2018-01-22 Thread santosh
gt; Acked-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v6 3/7] mbuf: add pool ops name selection API helpers

2018-01-22 Thread santosh
orm registered and compile time configured. > > Signed-off-by: Hemant Agrawal > Acked-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v6 4/7] mbuf: pktmbuf pool create helper for specific mempool ops

2018-01-22 Thread santosh
On Monday 22 January 2018 07:21 PM, Hemant Agrawal wrote: > Introduce a new helper for pktmbuf pool, which will allow > the application to optionally specify the mempool ops name > as well. > > Signed-off-by: Hemant Agrawal > Acked-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v6 5/7] app/testpmd: set preferred mempool as default pktpool

2018-01-22 Thread santosh
eviewed-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH 03/18] octeontx: align dynamic log names with standard

2018-01-25 Thread santosh
On Thursday 25 January 2018 02:30 PM, Harry van Haaren wrote: > This commit aligns the names for dynamic logging with > the newly defined logging format. > > Signed-off-by: Harry van Haaren > > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v6 08/12] linuxapp/eal: auto detect iova mode

2017-08-17 Thread santosh
On Wednesday 16 August 2017 11:08 PM, Aaron Conole wrote: > Santosh Shukla writes: > >> - Moving late bus scanning to up..just after eal_parsing. >> - Auto detect iova mapping mode, based on the result of >> rte_bus_scan_iommu_class. >> >> Signed-off-by: San

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: allow pmd to advertise pool handle

2017-09-04 Thread santosh
Hi Olivier, On Monday 04 September 2017 05:41 PM, Olivier MATZ wrote: > Hi Santosh, > > On Tue, Aug 15, 2017 at 01:37:17PM +0530, Santosh Shukla wrote: >> Now that dpdk supports more than one mempool drivers and >> each mempool driver works best for specific PMD, exampl

Re: [dpdk-dev] [PATCH v3 0/2] Dynamically configure mempool handle

2017-09-04 Thread santosh
Hi Sergio, On Monday 04 September 2017 03:11 PM, Sergio Gonzalez Monroy wrote: > On 15/08/2017 09:07, Santosh Shukla wrote: >> v3: >> - Rebased on top of v17.11-rc0 >> - Updated version.map entry to v17.11. >> >> v2: >> >> DPDK has support for

Re: [dpdk-dev] [PATCH v4 1/7] mempool: fix flags data type

2017-09-04 Thread santosh
On Monday 04 September 2017 07:41 PM, Olivier MATZ wrote: > On Tue, Aug 15, 2017 at 11:37:37AM +0530, Santosh Shukla wrote: >> mp->flags is int and mempool API updates unsigned int >> value in 'flags', so fix the 'flags' data type. >> >> P

Re: [dpdk-dev] [PATCH v4 2/7] mempool: add mempool arg in xmem size and usage

2017-09-04 Thread santosh
On Monday 04 September 2017 07:52 PM, Olivier MATZ wrote: > On Tue, Aug 15, 2017 at 11:37:38AM +0530, Santosh Shukla wrote: >> xmem_size and xmem_usage need to know the status of mp->flag. >> Following patch will make use of that. >> >> Signed-off-by: Santosh

Re: [dpdk-dev] [PATCH v4 4/7] mempool: get the mempool capability

2017-09-04 Thread santosh
Hi Olivier, On Monday 04 September 2017 08:02 PM, Olivier MATZ wrote: > On Tue, Aug 15, 2017 at 11:37:40AM +0530, Santosh Shukla wrote: >> Allow mempool to advertise its capability. >> A handler been introduced called rte_mempool_ops_get_capabilities. >> - Upon ->get_ca

Re: [dpdk-dev] [PATCH v4 5/7] mempool: detect physical contiguous object in pool

2017-09-04 Thread santosh
On Monday 04 September 2017 08:13 PM, Olivier MATZ wrote: > On Tue, Aug 15, 2017 at 11:37:41AM +0530, Santosh Shukla wrote: >> The memory area containing all the objects must be physically >> contiguous. >> Introducing MEMPOOL_F_CAPA_PHYS_CONTIG flag for such use-case. >

Re: [dpdk-dev] [PATCH v4 2/7] mempool: add mempool arg in xmem size and usage

2017-09-04 Thread santosh
On Monday 04 September 2017 08:16 PM, Olivier MATZ wrote: > On Mon, Sep 04, 2017 at 08:03:53PM +0530, santosh wrote: >> >> On Monday 04 September 2017 07:52 PM, Olivier MATZ wrote: >>> On Tue, Aug 15, 2017 at 11:37:38AM +0530, Santosh Shukla wrote: >>>> xmem_

Re: [dpdk-dev] [PATCH v7 2/9] eal/pci: get iommu class

2017-09-04 Thread santosh
Hi Anatoly, On Monday 04 September 2017 08:23 PM, Burakov, Anatoly wrote: >> From: Santosh Shukla [mailto:santosh.shu...@caviumnetworks.com] >> Sent: Thursday, August 31, 2017 4:26 AM >> To: dev@dpdk.org >> Cc: tho...@monjalon.net; jerin.ja...@caviumnetworks.com; &

  1   2   3   4   5   6   7   8   >