On Wednesday 04 April 2018 08:59 AM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Mon, 2 Apr 2018 14:40:00 +0530
>> From: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com>
>> To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com,
>> tho...@monjalon.net, anatoly.bura...@intel.com, lir...@marvell.com,
>> bruce.richard...@intel.com, fiona.tr...@intel.com, shreyansh.j...@nxp.com,
>> hemant.agra...@nxp.com
>> Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavat...@caviumnetworks.com>
>> Subject: [dpdk-dev] [PATCH v4 2/2] octeontx: move mbox to common folder
>> X-Mailer: git-send-email 2.16.3
>>
>> Move commonly used functions across mempool, event and net devices to a
>> common folder in drivers.
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com>
>> ---
snip
>> vfid == 0 ?
>>
>> + ram_mbox_base = octeontx_ssovf_bar(OCTEONTX_SSO_HWS, 0, 4);
also ram_mbox_base may throw build warning in case vfid>0..right?
>> + if (octeontx_mbox_set_ram_mbox_base(ram_mbox_base)) {
>> + mbox_log_err("Invalid Failed to set ram mbox base");
>> + return -EINVAL;
>> + }
>> + }
>> +
>> rte_wmb();
>> mbox_log_dbg("Domain=%d hws=%d total_ssowvfs=%d", res->domain,
>> res->vfid, sdev.total_ssowvfs);
>> @@ -213,6 +221,7 @@ ssovf_probe(struct rte_pci_driver *pci_drv, struct
>> rte_pci_device *pci_dev)
>> uint16_t vfid;
>> uint8_t *idreg;
>> struct ssovf_res *res;
>> + uint8_t *reg;
>>
>> RTE_SET_USED(pci_drv);
>>
>> @@ -246,6 +255,15 @@ ssovf_probe(struct rte_pci_driver *pci_drv, struct
>> rte_pci_device *pci_dev)
>> res->domain = val & 0xffff;
>>
>> sdev.total_ssovfs++;
>> + if (!vfid) {
> vfid == 0 ?
>
>> + reg = octeontx_ssovf_bar(OCTEONTX_SSO_GROUP, 0, 0);
ditto for reg.
>> + reg += SSO_VHGRP_PF_MBOX(1);
>> + if (octeontx_mbox_set_reg(reg)) {
>> + mbox_log_err("Invalid Failed to set mbox_reg");
>> + return -EINVAL;
>> + }
>> + }
>> +
>> rte_wmb();
>> mbox_log_dbg("Domain=%d group=%d total_ssovfs=%d", res->domain,
>> res->vfid, sdev.total_ssovfs);
> With above changes:
>
> Acked-by: Jerin Jacob <jerin.ja...@caviumnetworks.com>
>
Acked-by: Santosh Shukla <santosh.shu...@caviumnetworks.com>
Thanks.
