On 05/01/2017 01:31, Yang, Qiming wrote:
[..]
+ if (strcmp(drvinfo->driver, "net_ixgbe") == 0)
Do you need this check. I think it is not good idea to add this kind
of checks into ethtool app. Why not just print "%d.%d.%d %#X, major,
minor, patch, etrack" for all cases ?
> Qiming: because
On 09/01/2017 07:16, Yang, Qiming wrote:
-Original Message-
From: Stephen Hemminger [mailto:step...@networkplumber.org]
[..]
void
+rte_eth_dev_fw_version_get(uint8_t port_id, char *fw_version, int
+fw_length) {
+ struct rte_eth_dev *dev;
+
+ RTE_ETH_VALID_PORTID_OR_RET(por
Even though only primary processes should setup PMDs, secondary
processes were also blanket zeroing ethernet device memory. The
result was NULL dereference crashes in multi-process setups.
Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device")
Signed-off-by: Remy Horton
On 11/01/2017 14:22, Thomas Monjalon wrote:
2017-01-11 02:42, Remy Horton:
Even though only primary processes should setup PMDs, secondary
processes were also blanket zeroing ethernet device memory. The
result was NULL dereference crashes in multi-process setups.
Fixes: 7f95f78a8aea ("e
On 11/01/2017 06:41, Qiming Yang wrote:
This patch adds a new function eth_igb_fw_version_get.
Signed-off-by: Qiming Yang
[..]
+static int
+eth_igb_fw_version_get(struct rte_eth_dev *dev, char *fw_version,
+ size_t fw_size)
+{
+ struct e1000_hw *hw = E1000_DEV_PRIV
h] moved from Patch 2/3 to 1/3.
* Reintroduced non-port values (RTE_METRICS_NONPORT)
* Added spinlocks to metric library
* Removed spurious test registration/update
* Added release notes entries
v2 changes:
* Uses a new metrics library rather than being part of ethdev
Remy Horton (4):
lib: add inf
This patch adds a new information metric library that allows other
modules to register named metrics and update their values. It is
intended to be independent of ethdev, rather than mixing ethdev
and non-ethdev information in xstats.
Signed-off-by: Remy Horton
---
MAINTAINERS
This patch adds a library that calculates peak and average data-rate
statistics. For ethernet devices. These statistics are reported using
the metrics library.
Signed-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base
ic get API of the new metrics library.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
---
MAINTAINERS| 4 +
app/proc_info/main.c | 73
app/test-pmd/testpmd.c | 10 +
config/c
Signed-off-by: Remy Horton
---
app/test-pmd/testpmd.c | 36
1 file changed, 36 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index bfb2f8e..a0b7430 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -79,6 +79,10
On 12/01/2017 13:41, Thomas Monjalon wrote:
2017-01-12 00:03, Remy Horton:
Add a library designed to calculate latency statistics and report them
to the application when queried. The library measures minimum, average and
maximum latencies, and jitter in nano seconds. The current implementation
On 12/01/2017 13:22, Thomas Monjalon wrote:
2017-01-12 00:03, Remy Horton:
[..]
--- /dev/null
+++ b/lib/librte_metrics/rte_metrics.h
+/** Used to indicate port-independent information */
+#define RTE_METRICS_NONPORT -1
I do not understand this constant.
Why using the word "port" t
On 12/01/2017 19:05, Thomas Monjalon wrote:
2017-01-12 15:30, Remy Horton:
[..]
The metric library hold two sets of values: Ones specific to ports, and
ones that are global/aggregate. Agree "non port" is not the clearest
choice of name..
I think you should not use the word &qu
On 11/01/2017 16:15, Stephen Hemminger wrote:
[..]
You want these statistics to be cache aligned (ie not 0) to avoid
false cache sharing.
Done.
Since these statistics are often associated with a device would it
not make sense to have a NUMA socket associated with the alllocation?
Makes sens
ic library
* Removed spurious test registration/update
* Added release notes entries
v2 changes:
* Uses a new metrics library rather than being part of ethdev
Remy Horton (3):
lib: add information metrics library
lib: add bitrate statistics library
app/test-pmd: add bitrate statistics cal
This patch adds a new information metric library that allows other
modules to register named metrics and update their values. It is
intended to be independent of ethdev, rather than mixing ethdev
and non-ethdev information in xstats.
Signed-off-by: Remy Horton
---
MAINTAINERS
From: Reshma Pattan
Modify the dpdk-procinfo process to display the newly added metrics.
Added new command line option "--metrics" to display metrics.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
---
app/proc_info/main.c | 73 +
This patch adds a library that calculates peak and average data-rate
statistics. For ethernet devices. These statistics are reported using
the metrics library.
Signed-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base
Calculate bitrate statistics using the bitrate stats library. The
resulting statistics can be viewed via proc_info.
Signed-off-by: Remy Horton
---
app/test-pmd/testpmd.c | 36
1 file changed, 36 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test
From: Reshma Pattan
Modify testpmd code to initialize/uninitialize latency statistics
calulation.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
---
app/test-pmd/testpmd.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
stats.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base | 5 +
doc/api/doxy-api-index.md | 1 +
doc/api/doxy-api.conf
On 17/01/2017 04:29, Jerin Jacob wrote:
[..]
It is a value added feature for DPDK. But what is the plan for incorporating
the mbuf change? I have 8 month old mbuf change for ARM for natural
alignment. If we are accepting any mbuf change then we need to include
outstanding mbuf changes to avoid f
On 17/01/2017 11:01, Van Haaren, Harry wrote:
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Remy Horton
[..]
Nit: why the _s in rte_metrics_meta_s? Is there a reason why struct
rte_metrics_meta { is not suitable? Same question for
rte_metrics_data_s.
Think
On 17/01/2017 11:08, Van Haaren, Harry wrote:
[..]
+ " --metrics: to display derived metrics of the ports, disabled by
"
+ "default\n"
[..]
I presume there is no need for a --metrics-reset as the values are reset when
printed, correct?
Reset is not (cur
On 17/01/2017 11:16, Van Haaren, Harry wrote:
[..]
+struct rte_stats_bitrates_s *
+rte_stats_bitrate_create(void)
+{
+ return rte_zmalloc(NULL, sizeof(struct rte_stats_bitrates_s),
+ RTE_CACHE_LINE_SIZE);
+}
Is the socket relevant here? Perhaps pass socket_id to the functio
r latency stats
app/test-pmd: add latency statistics calculation
Remy Horton (3):
lib: add information metrics library
lib: add bitrate statistics library
app/test-pmd: add bitrate statistics calculation
Reshma Pattan (1):
app/proc_info: add metrics displaying
MAINTAINERS
From: Reshma Pattan
Modify the dpdk-procinfo process to display the newly added metrics.
Added new command line option "--metrics" to display metrics.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
---
app/proc_info/main.c | 74 +
This patch adds a new information metric library that allows other
modules to register named metrics and update their values. It is
intended to be independent of ethdev, rather than mixing ethdev
and non-ethdev information in xstats.
Signed-off-by: Remy Horton
---
MAINTAINERS
Calculate bitrate statistics using the bitrate stats library. The
resulting statistics can be viewed via proc_info.
Signed-off-by: Remy Horton
---
app/test-pmd/testpmd.c | 38 +-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd
This patch adds a library that calculates peak and average data-rate
statistics. For ethernet devices. These statistics are reported using
the metrics library.
Signed-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base
From: Harry van Haaren
This commit adds a uint64_t to the mbuf struct,
allowing collection of latency and jitter statistics
by measuring packet I/O timestamps. This change is
required by the latencystats library.
Signed-off-by: Reshma Pattan
Signed-off-by: Harry van Haaren
---
lib/librte_mbuf
From: Harry van Haaren
This patch adds latency stats commandline argument to testpmd,
allowing to specify the lcore to use for latencystats updates.
Signed-off-by: Reshma Pattan
Signed-off-by: Harry van Haaren
Signed-off-by: Remy Horton
---
v7 -> v8 changes:
- add optarg to ena
From: Harry van Haaren
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
Signed-off-by: Harry van Haaren
---
v7 to v8 changes:
- CYCLES_PER_NS now a static inline function
- "hidden" pthread creation now has polling API instead. The application
must call rte_latencystats_u
ase notes entries
v2 changes:
* Uses a new metrics library rather than being part of ethdev
Harry van Haaren (3):
mbuf: add a timestamp to the mbuf for latencystats
lib: added new library for latency stats
app/test-pmd: add latency statistics calculation
Remy Horton (3):
lib: add inf
From: Reshma Pattan
Modify the dpdk-procinfo process to display the newly added metrics.
Added new command line option "--metrics" to display metrics.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
---
app/proc_info/main.c | 79 +
This patch adds a new information metric library that allows other
modules to register named metrics and update their values. It is
intended to be independent of ethdev, rather than mixing ethdev
and non-ethdev information in xstats.
Signed-off-by: Remy Horton
---
MAINTAINERS
This patch adds a library that calculates peak and average data-rate
statistics. For ethernet devices. These statistics are reported using
the metrics library.
Signed-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base
Calculate bitrate statistics using the bitrate stats library. The
resulting statistics can be viewed via proc_info.
Signed-off-by: Remy Horton
---
app/test-pmd/testpmd.c | 41 -
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd
stats.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
Signed-off-by: Harry van Haaren
---
MAINTAINERS| 4 +
config/common_base | 5 +
doc/api/doxy-api-index.md | 1 +
doc/api/doxy
From: Harry van Haaren
This commit adds a uint64_t to the mbuf struct,
allowing collection of latency and jitter statistics
by measuring packet I/O timestamps. This change is
required by the latencystats library.
Signed-off-by: Reshma Pattan
Signed-off-by: Harry van Haaren
---
lib/librte_mbuf
From: Harry van Haaren
This patch adds latency stats commandline argument to testpmd,
allowing to specify the lcore to use for latencystats updates.
Signed-off-by: Reshma Pattan
Signed-off-by: Harry van Haaren
Signed-off-by: Remy Horton
---
app/test-pmd/parameters.c | 20
On 20/01/2017 18:37, Thomas Monjalon wrote:
[..]
3 comments here:
- it is in the wrong section (EAL instead of Drivers)
- secondary processes can setup a vdev PMD
- before Yuanhan's patch, even PCI PMD were blanking primary process data
Since the code being changed is in rte_ether rather than
On 23/01/2017 11:56, Yuanhan Liu wrote:
[..]
http://dpdk.org/ml/archives/dev/2017-January/054422.html
Yes, it should fix that issue.
Well, few more thoughts: it may fix the crash issue Remy saw, but it
looks like more a workaround to me. Basically, if primary and secondary
shares a same por
On 24/01/2017 10:49, Thomas Monjalon wrote:
[..]
Seems OK to me, assuming Yuanhan's patch is going in as-is.
Yuanhan's patch is already part of RC1.
Ah ok. I'll rebase a v2 then..
Secondary processes were blanket zeroing ethernet device memory,
resulting in NULL dereference crashes in multi-process setups.
Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device")
Signed-off-by: Remy Horton
---
doc/guides/rel_notes/release_17_02.rst | 5 +
lib/li
On 25/01/2017 11:56, Thomas Monjalon wrote:
[..]
It does not describe exactly the use-case it is fixing (same in commit message).
I guess you saw an issue when creating a vdev in the primary process and
another one in a secondary process, erasing the data of the first one.
In my use-case the s
On 24/01/2017 15:01, Remy Horton wrote:
Secondary processes were blanket zeroing ethernet device memory,
resulting in NULL dereference crashes in multi-process setups.
Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device")
Signed-off-by: Remy Horton
Self-NAK: Condit
On 25/01/2017 14:31, Thomas Monjalon wrote:
2017-01-25 14:02, Remy Horton:
[..]
Self-NAK: Condition is now tautology on code path that was causing crashes
What do you mean exactly?
There is an if(rte_eal_process_type() == RTE_PROC_PRIMARY) in a calling
function, so the one my patch was
On 28/01/2017 13:14, Yuanhan Liu wrote:
[..]
I'll apply the patch from Remy which fixes a case where process creates
I would ask you not to apply that. IMO, his patch may have "fixed" a crash
he saw, but it doesn't looks like to me it really fixes anything: the driver
may reference rte_eth_dat
Some points addressed. Will cover other ones later.
On 30/01/2017 15:50, Thomas Monjalon wrote:
[..]
+CONFIG_RTE_LIBRTE_METRICS=y
I know the config file is not so well sorted.
However it would be a bit more logical below CONFIG_RTE_LIBRTE_JOBSTATS.
Done. Rebase merging doesn't help with sor
From: Reshma Pattan
Modify the dpdk-procinfo process to display the newly added metrics.
Added new command line option "--metrics" to display metrics.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
---
app/proc_info/main.c | 79 +
f for latencystats
lib: added new library for latency stats
app/test-pmd: add latency statistics calculation
Remy Horton (3):
lib: add information metrics library
lib: add bitrate statistics library
app/test-pmd: add bitrate statistics calculation
Reshm
This patch adds a library that calculates peak and average data-rate
statistics. For ethernet devices. These statistics are reported using
the metrics library.
Signed-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base
stats.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
Signed-off-by: Harry van Haaren
---
MAINTAINERS| 4 +
config/common_base | 5 +
doc/api/doxy-api-index.md | 1 +
doc/api/doxy
-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base | 5 +
doc/api/doxy-api-index.md | 1 +
doc/api/doxy-api.conf | 1 +
doc/guides/prog_guide/index.rst| 1 +
doc/guides
From: Harry van Haaren
This commit adds a uint64_t to the mbuf struct,
allowing collection of latency and jitter statistics
by measuring packet I/O timestamps. This change is
required by the latencystats library.
Signed-off-by: Reshma Pattan
Signed-off-by: Harry van Haaren
---
lib/librte_mbuf
Calculate bitrate statistics using the bitrate stats library. The
resulting statistics can be viewed via proc_info.
Signed-off-by: Remy Horton
---
app/test-pmd/testpmd.c | 41 -
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd
From: Harry van Haaren
This patch adds latency stats commandline argument to testpmd,
allowing to specify the lcore to use for latencystats updates.
Signed-off-by: Reshma Pattan
Signed-off-by: Harry van Haaren
Signed-off-by: Remy Horton
---
app/test-pmd/parameters.c | 20
---
doc/guides/nics/features/virtio.ini | 1 +
1 file changed, 1 insertion(+)
Acked-by: Remy Horton
/rel_notes/release_17_02.rst ought to be updated as well. Code
itself looks ok though..
Acked-by: Remy Horton
ll spotted.. :)
Acked-by: Remy Horton
nteger ids")
Signed-off-by: Olivier Matz
Acked-by: Remy Horton
On 23/12/2016 20:35, Olivier Matz wrote:
Reword the Api documentation of xstats ethdev.
CC: sta...@dpdk.org
Signed-off-by: Olivier Matz
Acked-by: Remy Horton
On 08/07/2017 16:45, Andrew Rybchenko wrote:
From: Ivan Malov
Signed-off-by: Ivan Malov
Signed-off-by: Andrew Rybchenko
[..]
Reviewed-by: Remy Horton
+ rc = sfc_port_update_mac_stats(sa);
+ if (rc != 0) {
+ SFC_ASSERT(rc > 0);
+ ret =
length that the public API expects.
Fixes: 349950ddb9c5 ("metrics: add information metrics library")
Signed-off-by: Remy Horton
---
lib/librte_metrics/rte_metrics.c | 4 +++-
lib/librte_metrics/rte_metrics.h | 3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff -
On 18/07/2017 13:03, Yong Wang wrote:
Signed-off-by: Yong Wang
---
doc/guides/prog_guide/metrics_lib.rst | 1 +
1 file changed, 1 insertion(+)
Acked-by: Remy Horton
s changed, 51 insertions(+)
Reviewed-by: Remy Horton
/**
+ * Reset a Ethernet device and keep its port id.
+ *
+ * When a port has to be reset passively, the DPDK application can invoke this
+ * function. For example a PF is reset, all its VFs should also be reset.
+ * Normally, a DPDK ap
Unless the plan is for this patch to be squashed, ought to have a brief
commit message..
On 17/07/2017 16:15, Wei Dai wrote:
Signed-off-by: Wei Dai
---
doc/guides/prog_guide/poll_mode_drv.rst | 40 +
1 file changed, 40 insertions(+)
Reviewed-by: Remy Horton
/rel_notes/deprecation.rst | 6 ++
1 file changed, 6 insertions(+)
Acked-by: Remy Horton
eintroduced non-port values (RTE_METRICS_NONPORT)
* Added spinlocks to metric library
* Removed spurious test registration/update
* Added release notes entries
v2 changes:
* Uses a new metrics library rather than being part of ethdev
Harry van Haaren (2):
lib: added new library for latency stats
-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base | 5 +
doc/api/doxy-api-index.md | 1 +
doc/api/doxy-api.conf | 1 +
doc/guides/prog_guide/index.rst| 1 +
doc/guides
From: Reshma Pattan
Modify the dpdk-procinfo process to display the newly added metrics.
Added new command line option "--metrics" to display metrics.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
---
app/proc_info/main.c | 79 +
This patch adds a library that calculates peak and average data-rate
statistics. For ethernet devices. These statistics are reported using
the metrics library.
Signed-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base
stats.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
Signed-off-by: Harry van Haaren
---
MAINTAINERS| 4 +
config/common_base | 5 +
doc/api/doxy-api-index.md | 1 +
doc/api/doxy
From: Harry van Haaren
This patch adds latency stats commandline argument to testpmd,
allowing to specify the lcore to use for latencystats updates.
Signed-off-by: Reshma Pattan
Signed-off-by: Harry van Haaren
Signed-off-by: Remy Horton
---
app/test-pmd/parameters.c | 20
Calculate bitrate statistics using the bitrate stats library. The
resulting statistics can be viewed via proc_info.
Signed-off-by: Remy Horton
---
app/test-pmd/testpmd.c | 41 -
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd
On 28/03/2017 15:14, Pattan, Reshma wrote:
[..]
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+# library name
+LIB = librte_metrics.a
+
+CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR)
How about adding -O3 to flags?
Off the top of my mind, I think such flags are added to CFLAGS
separately. I think optimisat
On 28/03/2017 16:30, Pattan, Reshma wrote:
[..]
+CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR)
+
Adding -O3 flags?
Not here, as I don't think optimization flags should be in non top-level
Makefiles (someone correct me if this is wrong..).
Other changes done.
rt values (RTE_METRICS_NONPORT)
* Added spinlocks to metric library
* Removed spurious test registration/update
* Added release notes entries
v2 changes:
* Uses a new metrics library rather than being part of ethdev
Remy Horton (3):
lib: add information metrics library
lib: add bitrate statistics lib
From: Reshma Pattan
Modify the dpdk-procinfo process to display the newly added metrics.
Added new command line option "--metrics" to display metrics.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
---
app/proc_info/main.c | 79 +
This patch adds a library that calculates peak and average data-rate
statistics. For ethernet devices. These statistics are reported using
the metrics library.
Signed-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base
Calculate bitrate statistics using the bitrate stats library. The
resulting statistics can be viewed via proc_info.
Signed-off-by: Remy Horton
---
app/test-pmd/testpmd.c | 41 +++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd
stats.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
Signed-off-by: Harry van Haaren
---
MAINTAINERS| 4 +
config/common_base | 5 +
doc/api/doxy-api-index.md | 1 +
doc/api/doxy
From: Reshma Pattan
This patch adds latency stats commandline argument to testpmd,
allowing to specify the lcore to use for latencystats updates.
Signed-off-by: Reshma Pattan
Signed-off-by: Harry van Haaren
Signed-off-by: Remy Horton
---
app/test-pmd/parameters.c | 20
-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base | 5 +
doc/api/doxy-api-index.md | 3 +-
doc/api/doxy-api.conf | 3 +-
doc/guides/prog_guide/index.rst| 3 +-
doc/guides
e
* Added release notes entries
v2 changes:
* Uses a new metrics library rather than being part of ethdev
Remy Horton (3):
lib: add information metrics library
lib: add bitrate statistics library
app/test-pmd: add bitrate statistics calculation
Reshma Pattan (3):
app/proc_info: ad
-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base | 5 +
doc/api/doxy-api-index.md | 3 +-
doc/api/doxy-api.conf | 3 +-
doc/guides/prog_guide/index.rst| 3 +-
doc/guides
From: Reshma Pattan
Modify the dpdk-procinfo process to display the newly added metrics.
Added new command line option "--metrics" to display metrics.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
---
app/proc_info/main.c | 79 +
Calculate bitrate statistics using the bitrate stats library. The
resulting statistics can be viewed via proc_info.
Signed-off-by: Remy Horton
---
app/test-pmd/testpmd.c | 41 +++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd
This patch adds a library that calculates peak and average data-rate
statistics. For ethernet devices. These statistics are reported using
the metrics library.
Signed-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base
stats.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
Signed-off-by: Harry van Haaren
---
MAINTAINERS| 4 +
config/common_base | 5 +
doc/api/doxy-api-index.md | 1 +
doc/api/doxy
From: Reshma Pattan
This patch adds latency stats commandline argument to testpmd,
allowing to specify the lcore to use for latencystats updates.
Signed-off-by: Reshma Pattan
Signed-off-by: Harry van Haaren
Signed-off-by: Remy Horton
---
app/test-pmd/parameters.c | 22
On 04/04/2017 11:15, Thomas Monjalon wrote:
Ping
[..]
--- a/examples/ethtool/ethtool-app/Makefile
+++ b/examples/ethtool/ethtool-app/Makefile
+ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)
+LDLIBS += -lrte_pmd_ixgbe
+endif
Please, could you confirm we can remove the same LDLIBS line from
examples/
On 16/02/2017 16:17, Markos Chandras wrote:
The librte_ethtool library depends on librte_pmd_ixgbe if that
pmd driver is enabled so we need to link against it when we compile
the ethtool application. It fixes the following build problem:
For some reason this is not an issue with my Fedora box,
On 17/02/2017 16:27, Markos Chandras wrote:
On 02/17/2017 04:11 PM, Remy Horton wrote:
[..]
Yeah I am seen this problem in the openSUSE Tumbleweed distribution. I
think Nirmoy may have seen that in openSUSE Leap but I will let him
confirm that.
Tried Tumbleweed (version 13.3 I think) but
On 16/02/2017 16:17, Markos Chandras wrote:
[..]
Cc: Nirmoy Das
Signed-off-by: Markos Chandras
Acked-by: Remy Horton
On 16/02/2017 10:53, Thomas Monjalon wrote:
2017-02-03 10:33, Remy Horton:
[..]
I think there are three remaining questions:
- When the metrics computation are done? (in which thread?)
Actual calculation is not done by libmetrics itself - it only handles
distribution. Calculation is done
On 22/02/2017 19:06, Dumitrescu, Cristian wrote:
[..]
This essentially leads to the "other" repos becoming second class
citizens that can be broken at any time without prior notice or the
right to influence the change. The amount of maintenance work becomes
very difficult to quantify (e.g. we al
-off-by: Remy Horton
---
MAINTAINERS| 4 +
config/common_base | 5 +
doc/api/doxy-api-index.md | 1 +
doc/api/doxy-api.conf | 1 +
doc/guides/prog_guide/index.rst| 1 +
doc/guides
From: Reshma Pattan
Modify the dpdk-procinfo process to display the newly added metrics.
Added new command line option "--metrics" to display metrics.
Signed-off-by: Reshma Pattan
Signed-off-by: Remy Horton
---
app/proc_info/main.c | 79 +
1 - 100 of 532 matches
Mail list logo
