On 08/07/2017 16:45, Andrew Rybchenko wrote:
From: Ivan Malov <[email protected]>

Signed-off-by: Ivan Malov <[email protected]>
Signed-off-by: Andrew Rybchenko <[email protected]>
[..]

Reviewed-by: Remy Horton <[email protected]>


+       rc = sfc_port_update_mac_stats(sa);
+       if (rc != 0) {
+               SFC_ASSERT(rc > 0);
+               ret = -rc;

sfc_port_update_mac_stats() really ought to be returning -EINVAL or -ENOMEM rather than EINVAL/ENOMEM then doing a negation here.

Other than that, code seems OK..

Reply via email to