On 08/07/2017 16:45, Andrew Rybchenko wrote:
From: Ivan Malov <ivan.ma...@oktetlabs.ru>

Signed-off-by: Ivan Malov <ivan.ma...@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com>
[..]

Reviewed-by: Remy Horton <remy.hor...@intel.com>


+       rc = sfc_port_update_mac_stats(sa);
+       if (rc != 0) {
+               SFC_ASSERT(rc > 0);
+               ret = -rc;

sfc_port_update_mac_stats() really ought to be returning -EINVAL or -ENOMEM rather than EINVAL/ENOMEM then doing a negation here.

Other than that, code seems OK..

Reply via email to