On Tue, Mar 25, 2025 at 5:03 PM Bruce Richardson
wrote:
>
> A number of libs and drivers had special optimized AVX2 and AVX512 code
> paths for performance reasons, and these tended to have copy-pasted
> logic to build those files. Centralise that logic in the main
> drivers/ and lib/ meson.build
Update atomic_init_locks to immediately return if memory allocation
fails. Atomic queue and atq tests updated to handle atomic locks being
null.
Coverity issue: 457876
Fixes: 9d619f82321b ("app/eventdev: introduce atomic tests")
Signed-off-by: Luka Jankovic
---
app/test-eventdev/test_atomic_atq
Hi all,
Here is a list of patches targeted for stable release 22.11.8.
The planned date for the final release is 2025/04/10.
Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validatio
https://bugs.dpdk.org/show_bug.cgi?id=1616
Thomas Monjalon (tho...@monjalon.net) changed:
What|Removed |Added
Resolution|--- |FIXED
Status|
https://bugs.dpdk.org/show_bug.cgi?id=1586
Thomas Monjalon (tho...@monjalon.net) changed:
What|Removed |Added
Resolution|--- |FIXED
Status|
https://bugs.dpdk.org/show_bug.cgi?id=1559
Thomas Monjalon (tho...@monjalon.net) changed:
What|Removed |Added
Resolution|--- |FIXED
Status|
https://bugs.dpdk.org/show_bug.cgi?id=1531
Thomas Monjalon (tho...@monjalon.net) changed:
What|Removed |Added
Resolution|--- |FIXED
Status|
https://bugs.dpdk.org/show_bug.cgi?id=898
Thomas Monjalon (tho...@monjalon.net) changed:
What|Removed |Added
Resolution|--- |FIXED
Status|U
The definition of IXGBE_LE32_TO_CPUS macro is meant to modify the value
in place - similar to the le32_to_cpus() macro in kernel. Fixing the
definition allows us to remove some warning flags, and removes the need
for the uintptr_t typecasts.
Fixes: aa4fc14d2cee ("ixgbe: update base driver")
Cc: st
Simplify the build of the various intel base code directories, by
clearing compiler warnings so the files can be compiled directly along
with the regular driver files.
Bruce Richardson (7):
net/iavf/base: remove unused meson.build file
net/ixgbe/base: correct definition of macro
net/ixgbe/ba
Improve base code macros to reduce the number of issues with unused
variables in the code. Issues still remain with unused-but-set
variables, but completely unused variable warnings are eliminated.
Signed-off-by: Bruce Richardson
---
drivers/net/intel/ice/base/ice_osdep.h | 6 +++---
drivers/ne
Now that base-code warning flags have been removed from a number of
drivers, we can simplify their build configuration by just including the
base code files in the regular list of driver files passed back. There
is no need to use pre-compiled objects.
Signed-off-by: Bruce Richardson
---
drivers/
Fix warnings about unused values - parameters, variables, etc., and
remove the warning disable flags for them. Although modifying the
base-code files is not ideal, the changes required are minor, and only
affect two files from the imported base code.
Fixes: 8db9e2a1b232 ("i40e: base driver")
Cc: s
Add a single-line fix to the base code, and then the remaining two
compiler warning disable flags can be removed from the driver base code
build file.
Fixes: 8db9e2a1b232 ("i40e: base driver")
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
drivers/net/intel/i40e/base/i40e_diag.c | 2 +
On Tue, Mar 25, 2025 at 05:22:15PM +, Bruce Richardson wrote:
> When doing a build for a target that already has the instruction sets
> for AVX2/AVX512 enabled, skip emitting the AVX compiler flags, or the
> skylake-avx512 '-march' flags, as they are unnecessary. Instead, when
> the default fla
Simplify the build of the various intel base code directories, by
clearing compiler warnings so the files can be compiled directly along
with the regular driver files.
v2: added missing patch for fm10k
Bruce Richardson (8):
net/fm10k/base: fix compilation warnings
net/iavf/base: remove unused
Caught in OBS for Fedora Rawhide on aarch64:
[ 198s] In file included from ../lib/acl/acl_run_neon.h:7,
[ 198s] from ../lib/acl/acl_run_neon.c:5:
[ 198s] In function ‘alloc_completion’,
[ 198s] inlined from ‘acl_start_next_trie’ at
../lib/acl/acl_run.h:140:24,
[ 1
From: Pavan Nikhilesh
The event vector adapter supports offloading creation of
event vectors by vectorizing objects (mbufs/ptrs/u64s).
Applications can create a vector adapter associated with
an event queue and enqueue objects to be vectorized.
When the vector reaches the configured size or when
On Wed, Mar 26, 2025 at 01:02:32PM +0100, David Marchand wrote:
> On Mon, Mar 17, 2025 at 4:43 PM David Marchand
> wrote:
> >
> > So far, each DPDK library (or driver) exposing symbols in an ABI had to
> > maintain a version.map and use some macros for symbol versioning,
> > specially crafted with
From: Pavan Nikhilesh
When event device PMD doesn't support vector adapter,
the library will fallback to software implementation
which relies on service core to check for timeouts
and vectorizes the objects on enqueue.
Signed-off-by: Pavan Nikhilesh
---
lib/eventdev/eventdev_pmd.h
From: Pavan Nikhilesh
The event vector adapter supports offloading the creation of event vectors
by vectorizing objects (mbufs/ptrs/u64s).
An event vector adapter has the following working model:
┌──┐
│ Vector ├─┐
│ adapter0 │ │
└──┘ │
Removing myself as maintainer for iavf and i40e.
Signed-off-by: Ian Stokes
---
MAINTAINERS | 2 --
1 file changed, 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4b01103f8e..5f2f413da8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -802,7 +802,6 @@ F: doc/guides/nics/intel_vf.rst
F
On Wed, Mar 26, 2025 at 01:02:32PM +0100, David Marchand wrote:
> On Mon, Mar 17, 2025 at 4:43 PM David Marchand
> wrote:
> >
> > So far, each DPDK library (or driver) exposing symbols in an ABI had to
> > maintain a version.map and use some macros for symbol versioning,
> > specially crafted with
On Wed, Mar 26, 2025 at 01:30:10PM +, Ian Stokes wrote:
> Removing myself as maintainer for iavf and i40e.
>
> Signed-off-by: Ian Stokes
> ---
Acked-by: Bruce Richardson
https://bugs.dpdk.org/show_bug.cgi?id=1683
Bug ID: 1683
Summary: use after on interrupt thread during EAL cleanup
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: norm
On Mon, Mar 17, 2025 at 4:43 PM David Marchand
wrote:
>
> So far, each DPDK library (or driver) exposing symbols in an ABI had to
> maintain a version.map and use some macros for symbol versioning,
> specially crafted with the GNU linker in mind.
>
> This series proposes to rework the whole princi
We can remove almost all of the "unused parameter" and "unused variable"
warnings by just improving the macro definitions in the osdep.h header.
Remaining two instances can be fixed by just one-line additions to the
code, so add those to give us a clean build with the warnings enabled.
Fixes: af75
The fixes required to re-enable warnings in the fm10k base code are
trivial, so let's make the changes and get a clean compile without any
warning disable flags.
* provide definitions for the UNREFERENCED_PARAMETER macros
* fix the spelling of the work "fallthrough" in comments
* provide a definit
On Wed, Mar 26, 2025 2:37 PM Bruce Richardson
wrote:
> > - I am considering making rte_function_versioning.h a non exported
> > header (precisely, moving it to buildtools/ and maybe renaming it).
> >
> > This header contains macros not prefixed with RTE_.
> > Using it requires some build trick (se
++
> -Original Message-
> From: pbhagavat...@marvell.com
> Sent: Wednesday, March 26, 2025 6:45 PM
> To: Jerin Jacob
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula
>
> Subject: [RFC 0/2] introduce event vector adapter
>
> From: Pavan Nikhilesh
>
> The event vector adapter supports o
The meson.build file in the base folder was never used, as the base
files were just included in the main sources list for iavf.
Fixes: f1fdc9ddba5e ("drivers: move iavf common folder to iavf net")
Signed-off-by: Bruce Richardson
---
drivers/net/intel/iavf/base/meson.build | 10 --
1 fil
The definition of IXGBE_LE32_TO_CPUS macro is meant to modify the value
in place - similar to the le32_to_cpus() macro in kernel. Fixing the
definition allows us to remove some warning flags, and removes the need
for the uintptr_t typecasts.
Fixes: aa4fc14d2cee ("ixgbe: update base driver")
Cc: st
We can remove almost all of the "unused parameter" and "unused variable"
warnings by just improving the macro definitions in the osdep.h header.
Remaining two instances can be fixed by just one-line additions to the
code, so add those to give us a clean build with the warnings enabled.
Fixes: af75
Fix warnings about unused values - parameters, variables, etc., and
remove the warning disable flags for them. Although modifying the
base-code files is not ideal, the changes required are minor, and only
affect two files from the imported base code.
Fixes: 8db9e2a1b232 ("i40e: base driver")
Cc: s
The meson.build file in the base folder was never used, as the base
files were just included in the main sources list for iavf.
Fixes: f1fdc9ddba5e ("drivers: move iavf common folder to iavf net")
Signed-off-by: Bruce Richardson
---
drivers/net/intel/iavf/base/meson.build | 10 --
1 fil
I’ll set up the CI testing environment on kernel 4.19 as per the
current minimum requirement then.
Thanks,
Cody Cheng
On Sat, Mar 22, 2025 at 9:02 AM Morten Brørup
wrote:
>
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Friday, 21 March 2025 16.53
> >
> > On Fri, 21
Add a single-line fix to the base code, and then the remaining two
compiler warning disable flags can be removed from the driver base code
build file.
Fixes: 8db9e2a1b232 ("i40e: base driver")
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
drivers/net/intel/i40e/base/i40e_diag.c | 2 +
Now that base-code warning flags have been removed from a number of
drivers, we can simplify their build configuration by just including the
base code files in the regular list of driver files passed back. There
is no need to use pre-compiled objects.
Signed-off-by: Bruce Richardson
---
drivers/
Improve base code macros to reduce the number of issues with unused
variables in the code. Issues still remain with unused-but-set
variables, but completely unused variable warnings are eliminated.
Signed-off-by: Bruce Richardson
---
drivers/net/intel/ice/base/ice_osdep.h | 6 +++---
drivers/ne
The test case "test_multi_alloc_statistics" was brittle in that it did
some allocations and frees and then checked statistics without
considering the initial state of the malloc heaps. This meant that,
depending on what allocations/frees were done beforehand, the test can
sometimes fail.
We can im
> On Wed, 26 Mar 2025 18:44:36 +0530
> wrote:
>
> > +struct sw_vector_adapter_service_data {
> > + uint32_t service_id;
> > + RTE_ATOMIC(rte_mcslock_t *) lock;
> > + RTE_TAILQ_HEAD(, sw_vector_adapter_data) adapter_list;
> > +};
>
> Why the indirect pointer to the lock? rather than embeddi
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Wednesday, 26 March 2025 17.22
>
> On Tue, Mar 25, 2025 at 05:22:15PM +, Bruce Richardson wrote:
> > When doing a build for a target that already has the instruction sets
> > for AVX2/AVX512 enabled, skip emitting the AVX com
On Wed, 26 Mar 2025 17:25:32 +
Pavan Nikhilesh Bhagavatula wrote:
> > On Wed, 26 Mar 2025 18:44:36 +0530
> > wrote:
> >
> > > +struct sw_vector_adapter_service_data {
> > > + uint32_t service_id;
> > > + RTE_ATOMIC(rte_mcslock_t *) lock;
> > > + RTE_TAILQ_HEAD(, sw_vector_adapter_data) ad
https://bugs.dpdk.org/show_bug.cgi?id=1582
Thomas Monjalon (tho...@monjalon.net) changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resoluti
While reviewing use of null device for testing, noticed several things
this driver is doing which are unnecessary.
Stephen Hemminger (4):
net/null: Tx optimizations
net/null: fix packet copy
net/null: optimize Rx
net/null: count all queues
drivers/net/null/#rte_eth_null.c# | 754
> From: David Marchand [mailto:david.march...@redhat.com]
> Sent: Wednesday, 26 March 2025 13.03
>
[...]
> And I don't see symbol versioning as a MUST infrastructure that DPDK
> needs to provide to datapath applications.
Agree.
Getting rid of the exotic stuff like symbol versioning would make t
From: Pavan Nikhilesh
Migrate all invocations of rte_event_dma_adapter_op
API to rte_dma_op.
Signed-off-by: Pavan Nikhilesh
Acked-by: Amit Prakash Shukla
---
app/test-eventdev/test_perf_common.c | 6 +-
app/test-eventdev/test_perf_common.h | 4 +-
app/test/test_event_dma_a
From: Pavan Nikhilesh
Add enqueue/dequeue operations that use struct rte_dma_op
to communicate with the dma device.
These operations need to be enabled at dma device configuration
time by setting the flag rte_dma_conf::enable_enq_deq if the
device supports RTE_DMA_CAPA_OPS_ENQ_DEQ capability.
The
From: Pavan Nikhilesh
Implement DMA enqueue/dequeue operations when
application enables it via configuration.
Signed-off-by: Pavan Nikhilesh
---
drivers/dma/cnxk/cnxk_dmadev.c| 25 +-
drivers/dma/cnxk/cnxk_dmadev.h| 7 ++
drivers/dma/cnxk/cnxk_dmadev_fp.c | 140 +
From: Pavan Nikhilesh
Introduce DMA enqueue/dequeue operations to the DMA device library.
The enqueue/dequeue operations allow applications to communicate with the
DMA device using the rte_dma_op structure, providing a more flexible and
efficient way to manage DMA operations.
The programming mo
> Subject: Re: [EXTERNAL] Re: [patch v2 0/6] Support VMBUS channels without
> monitoring enabled
>
> On Wed, 12 Mar 2025 00:33:52 +
> Long Li wrote:
>
> > > Subject: [EXTERNAL] Re: [patch v2 0/6] Support VMBUS channels
> > > without monitoring enabled
> > >
> > > On Mon, 10 Mar 2025 14:42:51
If doing copy on transmit, can potentially copy past the data
in the mbuf. Change to only copy data from that segment.
Fixes: c743e50c475f ("null: new poll mode driver")
Cc: muk...@igel.co.jp
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
drivers/net/null/rte_eth_null.c | 12 ++---
On Wed, 26 Mar 2025 19:06:58 +0100
Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Wednesday, 26 March 2025 17.22
> >
> > On Tue, Mar 25, 2025 at 05:22:15PM +, Bruce Richardson wrote:
> > > When doing a build for a target that already has the i
Modify the implementation of the dtb queue
request and release interfaces,
and add the implementation of queue initialization.
Signed-off-by: Bingbin Chen
---
drivers/net/zxdh/zxdh_np.c | 491 +
drivers/net/zxdh/zxdh_np.h | 97
2 files changed, 482 i
No other rx_burst function checks args, remove it.
Since rx_burst can only safely be called by a single thread
at a time, there is no need for atomic operations on statistics.
Signed-off-by: Stephen Hemminger
---
drivers/net/null/rte_eth_null.c | 22 +-
1 file changed, 5 ins
If RTE_ETHDEV_QUEUE_STAT_CNTRS is less than the number of queues
in a device, the device should still count packets for all queues.
Remove the igb_ prefix which was inherited from other driver.
Signed-off-by: Stephen Hemminger
---
drivers/net/null/rte_eth_null.c | 31 +--
All the null device does is call pktmbuf_free, can be marked lockless.
The statitistics need to use atomic for this.
Use rte_pktmbuf_free_bulk instead of a loop.
And pktmbuf_free handles multi-segment packets without problems.
There is no reason for eth_null_tx to check arguments,
no other tx_bur
++
> -Original Message-
> From: pbhagavat...@marvell.com
> Sent: Thursday, March 27, 2025 1:07 AM
> To: Jerin Jacob
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula
>
> Subject: [RFC v2 0/3] Introduce DMA enqueue/dequeue operations
>
> From: Pavan Nikhilesh
>
> Introduce DMA enqueue/d
Start a new release cycle with empty release notes.
Bump version and ABI minor.
Signed-off-by: David Marchand
---
.github/workflows/build.yml| 2 +-
ABI_VERSION| 2 +-
VERSION| 2 +-
doc/guides/rel_notes/index.rst
On Wed, Mar 26, 2025 at 10:00:03AM +0100, David Marchand wrote:
> Start a new release cycle with empty release notes.
> Bump version and ABI minor.
>
> Signed-off-by: David Marchand
> ---
One query below, otherwise LGTM
Acked-by: Bruce Richardson
> .github/workflows/build.yml|
> A number of libs and drivers had special optimized AVX2 and AVX512 code
> paths for performance reasons, and these tended to have copy-pasted
> logic to build those files. Centralise that logic in the main
> drivers/ and lib/ meson.build files to avoid duplication.
>
> v5: fix RTE_ARCH_X86 ma
On Wed, Mar 26, 2025 at 10:11 AM Bruce Richardson
wrote:
> > diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
> > index fba46b920f..0cc4d12b0b 100644
> > --- a/.github/workflows/build.yml
> > +++ b/.github/workflows/build.yml
> > @@ -12,7 +12,7 @@ defaults:
> > env:
> >R
On Wed, Mar 26, 2025 at 11:09:50AM +0100, David Marchand wrote:
> On Wed, Mar 26, 2025 at 10:11 AM Bruce Richardson
> wrote:
> > > diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
> > > index fba46b920f..0cc4d12b0b 100644
> > > --- a/.github/workflows/build.yml
> > > +++ b/.g
On Wed, Mar 26, 2025 at 02:54:32PM +0100, David Marchand wrote:
> On Wed, Mar 26, 2025 2:37 PM Bruce Richardson
> wrote:
> > > - I am considering making rte_function_versioning.h a non exported
> > > header (precisely, moving it to buildtools/ and maybe renaming it).
> > >
> > > This header contai
On Wed, 26 Mar 2025 18:44:36 +0530
wrote:
> +
> +struct sw_vector_adapter_service_data {
> + uint32_t service_id;
> + RTE_ATOMIC(rte_mcslock_t *) lock;
> + RTE_TAILQ_HEAD(, sw_vector_adapter_data) adapter_list;
> +};
Do you really need mcslock here?
mcslock is for locks where there i
Although af_packet PMD supports setting the fanout algorithm, it is not
explicitly declared during registration. Add fanout parameter registration
to facilitate users in quickly obtaining supported fanout algorithms.
Additionally, add configuration parameter printing during initialization.
Fixes:
> -Original Message-
> From: Akhil Goyal
> Sent: Monday, 17 March 2025 12:23
> To: Shani Peretz ; dev@dpdk.org
> Cc: Suanming Mou ; sta...@dpdk.org; Brian
> Dooley ; Pablo de Lara
>
> Subject: RE: [EXTERNAL] [PATCH] app/crypto-perf: fix aad offset alignment
>
> External email: Use caut
> -Original Message-
> From: Vamsi Krishna
> Sent: Monday, March 24, 2025 4:39 PM
> To: dev@dpdk.org
> Cc: Jerin Jacob ; Vamsi Krishna Attunuru
> ; Vidya Sagar Velumuri
> Subject: [PATCH v0 1/1] net/octeon_ep: fix buffer refill failure
>
> From: Vidya Sagar Velumuri
>
> Fix the buff
Hello Bruce,
Hi Gregory, some high-level feedback:
* I'd suggest for future revisions splitting this into two patches. The rust
example should be separate from a patch adding the basic rust
infrastructure.
In progress.
* For the example, I'd suggest that the helloworld rust example should
69 matches
Mail list logo
