On Wed, Mar 26, 2025 at 02:54:32PM +0100, David Marchand wrote: > On Wed, Mar 26, 2025 2:37 PM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > - I am considering making rte_function_versioning.h a non exported > > > header (precisely, moving it to buildtools/ and maybe renaming it). > > > > > > This header contains macros not prefixed with RTE_. > > > Using it requires some build trick (see use_function_versioning). > > > And I don't see symbol versioning as a MUST infrastructure that DPDK > > > needs to provide to datapath applications. > > > > > > Yet technically, this change would be an API breakage if some > > > applications indeed relied on it. > > > > > > > Is it not needed for exporting if an exported library header had versioned > > symbols is in? > > That could be, though we don't expose such versionned symbols atm (and > I don't think we ever did in DPDK). > The only public symbol is always the symbol implemented for the latest > ABI for newly compiled applications. >
Ok, that's good. Looking through code and code history I do indeed see that the use of function versioning in the past seems to have all been done through the C file. Therefore, no issues with making the header internal-only and not exported. /Bruce
