If doing copy on transmit, can potentially copy past the data
in the mbuf. Change to only copy data from that segment.

Fixes: c743e50c475f ("null: new poll mode driver")
Cc: muk...@igel.co.jp
Cc: sta...@dpdk.org

Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
---
 drivers/net/null/rte_eth_null.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index 3a05af2e32..baae81c572 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -35,7 +35,7 @@ struct null_queue {
        struct pmd_internals *internals;
 
        struct rte_mempool *mb_pool;
-       struct rte_mbuf *dummy_packet;
+       void *dummy_packet;
 
        RTE_ATOMIC(uint64_t) rx_pkts;
        RTE_ATOMIC(uint64_t) tx_pkts;
@@ -156,14 +156,14 @@ eth_null_tx(void *q, struct rte_mbuf **bufs, uint16_t 
nb_bufs)
 static uint16_t
 eth_null_copy_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
 {
-       int i;
        struct null_queue *h = q;
-       unsigned int packet_size;
+       unsigned int i;
 
-       packet_size = h->internals->packet_size;
        for (i = 0; i < nb_bufs; i++) {
-               rte_memcpy(h->dummy_packet, rte_pktmbuf_mtod(bufs[i], void *),
-                                       packet_size);
+               struct rte_mbuf *m = bufs[i];
+               unsigned int len = RTE_MIN(h->internals->packet_size, 
m->data_len);
+
+               rte_memcpy(h->dummy_packet, rte_pktmbuf_mtod(m, void *), len);
                rte_pktmbuf_free(bufs[i]);
        }
 
-- 
2.47.2

Reply via email to