Take the RSS hash value for the title packet for
flow tag and packet header CQE zipping formats.
Fixes: 54c2d46b16 ("net/mlx5: support flow tag and packet header miniCQEs")
Cc: sta...@dpdk.org
Signed-off-by: Alexander Kozyrev
---
drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 9 +
drivers/n
Dear Thomas,
As you expected, I have attached the throughput under this release.
My testing was conducted using pktgen 24.10.3. I just set the size
and then start all. The test results are as follows:
size/throughputrtl8125brtl8126
641709 MBit/s 3080 MBit
21/11/2024 10:32, Howard Wang:
> Dear Thomas,
>
> As you expected, I have attached the throughput under this release.
> My testing was conducted using pktgen 24.10.3. I just set the size
> and then start all. The test results are as follows:
>
> size/throughputrtl8125brtl8126
> 6
> -Original Message-
> From: Alexander Kozyrev
> Sent: Thursday, November 21, 2024 14:32
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava Ovsiienko
> ; Matan Azrad ; Dariusz
> Sosnowski ; Bing Zhao ;
> Suanming Mou
> Subject: [PATCH] net/mlx5: fix RSS hash for non-RSS
06/07/2023 01:45, Stephen Hemminger:
> The mailmap file is supposed to be in sorted order,
> but several entries are in the wrong place.
Sorting a space may be done in various ways.
We tried in the past to have a good sort
handling both spaces and accents, but we failed to automate it.
So we are d
Reviewed-by: Patrick Robb
On Tue, Nov 19, 2024 at 11:52:38AM +, Bruce Richardson wrote:
> On Fri, Nov 15, 2024 at 07:14:25PM +, Vladimir Medvedkin wrote:
> > 'i40e_get_outer_vlan()' does not check 'i40e_aq_debug_read_register()'
> > return value. This patch fixes this issue.
>
> I think a little more detail on the
Acked-by: Chengwen Feng
On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Tyler Retzlaff
>
> MSVC does not support optional C11 VLAs. When building for Windows
> enable -Wvla so that mingw and clang also fail if a VLA is used.
>
> Signed-off-by: Tyler Retzlaff
> Acked-by: Bruce Richardson
>
Acked-by: Chengwen Feng
On 2024/11/22 2:23, Stephen Hemminger wrote:
> The loop over policy actions will always exit when it sees
> the flow end action, so the next check is redundant.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: f29fa2c59b85 ("app/testpmd: support policy
The parenthesis were in the wrong place so that comparison
took precedence over assignment in handling IPv6 extension
headers. Break up the loop condition to avoid the problem.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 15ccc647526e ("test/security: test inline reassembly with m
From: Konstantin Ananyev
gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
that first entries in pkts[] can be already occupied by
un-processed packets.
Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
Cc: sta...@dpdk.org
Signed-off-by: Konstantin Ananyev
Acked-by: Ferr
From: Tyler Retzlaff
Include alloca.h for Linux and malloc.h for Windows to get declaration
of alloca().
Signed-off-by: Tyler Retzlaff
---
lib/eal/freebsd/include/rte_os.h | 1 +
lib/eal/linux/include/rte_os.h | 1 +
lib/eal/windows/include/rte_os.h | 1 +
3 files changed, 3 insertions(+)
d
From: Konstantin Ananyev
1) ./lib/ethdev/rte_ethdev.c:3244:16
: warning: ISO C90 forbids variable length array ‘xstats_names’
2) ./lib/ethdev/rte_ethdev.c:3345:17
: warning: ISO C90 forbids variable length array ‘ids_copy’
3) ./lib/ethdev/rte_ethdev.c:3538:16
: warning: ISO C90 forbid
From: Konstantin Ananyev
1) ./lib/rcu/rte_rcu_qsbr.c:359:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
2) ./lib/rcu/rte_rcu_qsbr.c:422:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
In both cases we allocate VLA for one element from RCU deferred que
From: Konstantin Ananyev
../lib/gro/rte_gro.c:182:34: warning:
variable length array used [-Wvla]
../lib/gro/rte_gro.c:363:34: warning:
variable length array used [-Wvla]
In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to
collect un-used by GRO packets, and then cop
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
---
drivers/common/idpf/idpf_common_rxtx.c
From: Konstantin Ananyev
1) ./lib/hash/rte_thash.c:774:9
: warning: ISO C90 forbids variable length array ‘tmp_tuple’
The tuple can exceed sizeof(union rte_thash_tuple), for example if any tunneling
header is used in the RSS hash calculation.
The longest RSS hash key currently supported is
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
app/test-pmd/cmdline.c | 2 +-
app/test-pmd/cmdline_flow.c | 15
1) MSVC does not support VLAs. Use standard fixed C arrays of
maximum size required instead.
2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8:
error: array subscript 9 is outside array bounds of 'uint64_t[16]'
{aka 'long unsigned int[16]'} [-Werror=array-bounds=]
3695
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Reviewed-by: Bruce Richardson
---
drivers/net/i40e/i40e_testpmd.c | 5 ++-
From: Konstantin Ananyev
../drivers/net/ice/ice_rxtx.c:1871:29: warning:
variable length array used [-Wvla]
Here VLA is used as a temp array for mbufs that will be used as a split
RX data buffers.
As at any given time only one thread can do RX from particular queue,
at rx_queue_setup() we ca
MSVC does not support VLAs, replace VLAs with standard C arrays.
Signed-off-by: Andre Muezerie
---
lib/hash/rte_thash_gf2_poly_math.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/hash/rte_thash_gf2_poly_math.c
b/lib/hash/rte_thash_gf2_poly_math.c
index 1c6297
From: Konstantin Ananyev
1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning:
variable length array used [-Wvla]
2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning:
variable length array used [-Wvla]
3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning:
variable len
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/common/mlx5/mlx5_common.h| 4 ++--
drivers/common/mlx5/mlx
On Wed, Nov 20, 2024 at 09:12:15AM -0800, Stephen Hemminger wrote:
> On Tue, 19 Nov 2024 19:13:01 -0800
> Andre Muezerie wrote:
>
> > From: Tyler Retzlaff
> >
> > Include alloca.h for Linux and malloc.h for Windows to get declaration
> > of alloca().
> >
> > Signed-off-by: Tyler Retzlaff
> >
The expression for checking which lcore is enabled for 0-7
was wrong (missing case for 6).
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: b0209034f2bb ("test/eal: check number of cores before running subtests")
Cc: msant...@redhat.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemmi
As per guidance technical board meeting 2024/04/17. This series
removes the use of VLAs from code built for Windows for all 3
toolchains. If there are additional opportunities to convert VLAs
to regular C arrays please provide the details for incorporation
into the series.
MSVC does not support VL
From: Konstantin Ananyev
1) ./lib/eal/linux/eal_interrupts.c:1073:16
: warning: ISO C90 forbids variable length array ‘events’
MSVC does not support VLAs. Use alloca() to allocate the memory on
the stack.
2) ./lib/eal/linux/eal_interrupts.c:1319:16
: warning: ISO C90 forbids variable le
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Andre Muezerie
---
app/test-pmd/shared_rxq_fwd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
Acked-by: Chengwen Feng
On 2024/11/22 2:23, Stephen Hemminger wrote:
> The order of comparison is wrong, and potentially allows
> referencing past the array.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: 3e3edab530a1 ("ethdev: add flow quota")
> Cc: getel...@nvidia.com
> C
Acked-by: Chengwen Feng
On 2024/11/22 2:23, Stephen Hemminger wrote:
> Do not use same variable for outer and inner loop in bonding test.
> Since the loop is just freeing the resulting burst use bulk free.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: 92073ef961ee ("bond:
Dear Thomas,
Sure, r8169pmd will support more network cards, such as the 1G NICs (rtl8168
series).
Best Wishes,
Howard Wang
-邮件原件-
发件人: Thomas Monjalon
发送时间: 2024年11月21日 18:33
收件人: 王颢
抄送: dev@dpdk.org; pro_nic_d...@realtek.com; Stephen Hemminger
; ferruh.yi...@amd.com
主题: Re: r8169
I added additional reference links and definitions to many
of the terms in the glossary. Please feel free to provide
feedback to ensure my definitions suit the proper context
in the DPDK community.
Signed-off-by: Nandini Persad
---
doc/guides/prog_guide/glossary.rst | 101 ++-
Acked-by: Chengwen Feng
On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Tyler Retzlaff
>
> MSVC does not support VLAs, replace VLAs with standard C arrays
> or alloca(). alloca() is available for all toolchain/platform
> combinations officially supported by DPDK.
>
> Signed-off-by: Tyler Ret
On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Konstantin Ananyev
>
> 1) ./lib/ethdev/rte_ethdev.c:3244:16
> : warning: ISO C90 forbids variable length array ‘xstats_names’
> 2) ./lib/ethdev/rte_ethdev.c:3345:17
> : warning: ISO C90 forbids variable length array ‘ids_copy’
> 3) ./lib/e
Acked-by: Chengwen Feng
On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Konstantin Ananyev
>
> 1) ./lib/hash/rte_cuckoo_hash.c:2362:9
> : warning: ISO C90 forbids variable length array ‘positions’
> 2) ../lib/hash/rte_cuckoo_hash.c:2478:9
> : warning: ISO C90 forbids variable length a
Acked-by: Chengwen Feng
On 2024/11/22 2:23, Stephen Hemminger wrote:
> The parenthesis were in the wrong place so that comparison
> took precedence over assignment in handling IPv6 extension
> headers. Break up the loop condition to avoid the problem.
>
> Link: https://pvs-studio.com/en/blog/po
Acked-by: Chengwen Feng
On 2024/11/22 2:23, Stephen Hemminger wrote:
> The first argument of 'memcmp' function was equal to the second argument.
> Therefore ASSERT would always be true.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: 92073ef961ee ("bond: unit tests")
> Cc: d
On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Konstantin Ananyev
>
> 1) ./lib/hash/rte_thash.c:774:9
> : warning: ISO C90 forbids variable length array ‘tmp_tuple’
>
> The tuple can exceed sizeof(union rte_thash_tuple), for example if any
> tunneling header is used in the RSS hash calcul
Acked-by: Chengwen Feng
On 2024/11/22 5:41, Andre Muezerie wrote:
> MSVC does not support VLAs, replace VLAs with standard C arrays
> or alloca(). alloca() is available for all toolchain/platform
> combinations officially supported by DPDK.
>
> Signed-off-by: Andre Muezerie
> ---
> app/test-pm
I added additional reference links and definitions to many
of the terms in the glossary. Please feel free to provide
feedback to ensure my definitions suit the proper context
in the DPDK community.
Signed-off-by: Nandini Persad
---
doc/guides/prog_guide/glossary.rst | 107 ++-
From: Tyler Retzlaff
Include alloca.h for Linux and malloc.h for Windows to get declaration
of alloca().
Signed-off-by: Tyler Retzlaff
---
lib/eal/freebsd/include/rte_os.h | 1 +
lib/eal/linux/include/rte_os.h | 1 +
lib/eal/windows/include/rte_os.h | 1 +
3 files changed, 3 insertions(+)
d
From: Konstantin Ananyev
1) ./lib/hash/rte_cuckoo_hash.c:2362:9
: warning: ISO C90 forbids variable length array ‘positions’
2) ../lib/hash/rte_cuckoo_hash.c:2478:9
: warning: ISO C90 forbids variable length array ‘positions’
Both rte_hash_lookup_bulk_data() and
rte_hash_lookup_with_hash
On Wed, Nov 20, 2024 at 10:40:07AM +, Medvedkin, Vladimir wrote:
> Hi Andre,
>
> On 20/11/2024 03:13, Andre Muezerie wrote:
> >From: Konstantin Ananyev
> >
> >1) ./lib/hash/rte_thash.c:774:9
> > : warning: ISO C90 forbids variable length array ‘tmp_tuple’
> >
> > From my understanding, tup
Hi,
We are adding support for vDPA user backend for virtio-crypto PMD in DPDK. We
have come up with functional changes which is similar to the support available
in net:
commit 6b901437056eed3ed7c9932c333ba24ac5be116f
net/virtio: introduce vhost-vDPA backend
vhost-vDPA is a new virti
As per guidance technical board meeting 2024/04/17. This series
removes the use of VLAs from code built for Windows for all 3
toolchains. If there are additional opportunities to convert VLAs
to regular C arrays please provide the details for incorporation
into the series.
MSVC does not support VL
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
app/test/test.c | 2 +-
app/test/test_cmdline_s
From: Konstantin Ananyev
1) ./lib/rcu/rte_rcu_qsbr.c:359:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
2) ./lib/rcu/rte_rcu_qsbr.c:422:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
In both cases we allocate VLA for one element from RCU deferred que
From: Konstantin Ananyev
1) ./lib/hash/rte_cuckoo_hash.c:2362:9
: warning: ISO C90 forbids variable length array ‘positions’
2) ../lib/hash/rte_cuckoo_hash.c:2478:9
: warning: ISO C90 forbids variable length array ‘positions’
Both rte_hash_lookup_bulk_data() and
rte_hash_lookup_with_hash
From: Konstantin Ananyev
gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
that first entries in pkts[] can be already occupied by
un-processed packets.
Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
Cc: sta...@dpdk.org
Signed-off-by: Konstantin Ananyev
Acked-by: Ferr
From: Konstantin Ananyev
1) ./lib/hash/rte_thash.c:774:9
: warning: ISO C90 forbids variable length array ‘tmp_tuple’
The tuple can exceed sizeof(union rte_thash_tuple), for example if any
tunneling header is used in the RSS hash calculation.
The longest RSS hash key currently supported is
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
---
drivers/common/idpf/idpf_common_rxtx.c
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Reviewed-by: Bruce Richardson
---
drivers/net/i40e/i40e_testpmd.c | 5 ++-
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
app/test-pmd/cmdline.c | 2 +-
app/test-pmd/cmdline_flow.c | 15
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Andre Muezerie
---
app/test-pmd/shared_rxq_fwd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
1) MSVC does not support VLAs. Use standard fixed C arrays of
maximum size required instead.
2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8:
error: array subscript 9 is outside array bounds of 'uint64_t[16]'
{aka 'long unsigned int[16]'} [-Werror=array-bounds=]
3695
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/common/mlx5/mlx5_common.h| 4 ++--
drivers/common/mlx5/mlx
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/net/mlx5/mlx5.c | 5 ++---
drivers/net/mlx5/mlx5_flow.c |
From: Tyler Retzlaff
MSVC does not support optional C11 VLAs. When building for Windows
enable -Wvla so that mingw and clang also fail if a VLA is used.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
---
config/meson.build | 4
1 file changed, 4 insertions(+)
diff --git a/conf
From: Konstantin Ananyev
1) ../lib/eal/common/eal_common_proc.c:695:15
: warning: variable length array used
As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced
it with fixed size array.
Signed-off-by: Konstantin Ananyev
Acked-by: Stephen Hemminger
---
lib/eal/common/eal_common
From: Konstantin Ananyev
1) ./lib/ethdev/rte_ethdev.c:3244:16
: warning: ISO C90 forbids variable length array ‘xstats_names’
2) ./lib/ethdev/rte_ethdev.c:3345:17
: warning: ISO C90 forbids variable length array ‘ids_copy’
3) ./lib/ethdev/rte_ethdev.c:3538:16
: warning: ISO C90 forbid
MSVC does not support VLAs, replace VLAs with standard C arrays.
Signed-off-by: Andre Muezerie
---
lib/hash/rte_thash_gf2_poly_math.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/hash/rte_thash_gf2_poly_math.c
b/lib/hash/rte_thash_gf2_poly_math.c
index 1c6297
From: Konstantin Ananyev
../lib/gro/rte_gro.c:182:34: warning:
variable length array used [-Wvla]
../lib/gro/rte_gro.c:363:34: warning:
variable length array used [-Wvla]
In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to
collect un-used by GRO packets, and then cop
From: Konstantin Ananyev
1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning:
variable length array used [-Wvla]
2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning:
variable length array used [-Wvla]
3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning:
variable len
On Wed, Nov 20, 2024 at 10:51:26AM +, Medvedkin, Vladimir wrote:
> Hi Andre,
>
> On 20/11/2024 03:13, Andre Muezerie wrote:
> >MSVC does not support VLAs, replace VLAs with standard C arrays.
> >
> >Signed-off-by: Andre Muezerie
> >---
> > lib/hash/rte_thash_gf2_poly_math.c | 7 ---
> > 1
On Thu, Nov 21, 2024 at 09:51:36PM +0100, Thomas Monjalon wrote:
> 21/11/2024 20:39, Andre Muezerie:
> > On Tue, Nov 19, 2024 at 09:32:07AM +0100, Morten Brørup wrote:
> > > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> > > > Sent: Tuesday, 19 November 2024 05.35
> > > >
> > > > F
On Wed, Nov 20, 2024 at 09:20:29AM -0800, Stephen Hemminger wrote:
> On Tue, 19 Nov 2024 17:54:43 -0800
> Andre Muezerie wrote:
>
> > From: Tyler Retzlaff
> >
> > MSVC does not support optional C11 VLAs. When building for Windows
> > enable -Wvla so that mingw and clang also fail if a VLA is us
From: Tyler Retzlaff
MSVC does not support optional C11 VLAs. When building for Windows
enable -Wvla so that mingw and clang also fail if a VLA is used.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
---
config/meson.build | 4
1 file changed, 4 insertions(+)
diff --git a/conf
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/net/mlx5/mlx5.c | 5 ++---
drivers/net/mlx5/mlx5_flow.c |
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
app/test/test.c | 2 +-
app/test/test_cmdline_s
On Tue, Nov 19, 2024 at 09:32:07AM +0100, Morten Brørup wrote:
> > From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> > Sent: Tuesday, 19 November 2024 05.35
> >
> > From: Tyler Retzlaff
> >
> > MSVC struct packing is not compatible with GCC. Provide a macro that
> > can be used to pus
From: Konstantin Ananyev
1) ../lib/eal/common/eal_common_proc.c:695:15
: warning: variable length array used
As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced
it with fixed size array.
Signed-off-by: Konstantin Ananyev
Acked-by: Stephen Hemminger
---
lib/eal/common/eal_common
From: Konstantin Ananyev
../drivers/net/ice/ice_rxtx.c:1871:29: warning:
variable length array used [-Wvla]
Here VLA is used as a temp array for mbufs that will be used as a split
RX data buffers.
As at any given time only one thread can do RX from particular queue,
at rx_queue_setup() we ca
From: Konstantin Ananyev
1) ./lib/eal/linux/eal_interrupts.c:1073:16
: warning: ISO C90 forbids variable length array ‘events’
MSVC does not support VLAs. Use alloca() to allocate the memory on
the stack.
2) ./lib/eal/linux/eal_interrupts.c:1319:16
: warning: ISO C90 forbids variable le
The first argument of 'memcmp' function was equal to the second argument.
Therefore ASSERT would always be true.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 92073ef961ee ("bond: unit tests")
Cc: declan.dohe...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
a
The event_dev_config initialization had duplicate assignments
to the same element. Change to use structure initialization
so that compiler will catch this type of bug.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: f8f9d233ea0e ("test/eventdev: add unit tests")
Cc: jerin.ja...@cavium
The code was duplicating the same condition three times?
Reading the commit message, the intention was:
Add unit tests to verify the zero len TLS records. Zero len packets are
allowed when content type is app data while zero packet length with
other content type (such as handshake) wou
Do not use same variable for outer and inner loop in bonding test.
Since the loop is just freeing the resulting burst use bulk free.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 92073ef961ee ("bond: unit tests")
Cc: declan.dohe...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Steph
The test loop was much shorter than desired because when
MAX_NUM is defined with out paren's the divide operator /
takes precedence over shift.
But when MAX_NUM is fixed, some tests take too long
and have to be modified to avoid running over full N^2
space of 1<<20.
Note: this is a very old bug,
Recent blog post from PVS studio referenced lots bugs found by
their analyzer against DPDK. This set addresses the ones in
the test suite.
v4 - rebase and drop code that was already fixed (removed)
Stephen Hemminger (9):
app/test: do not duplicate loop variable
app/test: fix typo in address c
The order of comparison is wrong, and potentially allows
referencing past the array.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: 3e3edab530a1 ("ethdev: add flow quota")
Cc: getel...@nvidia.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
Acked-by: Bruce Richardson
---
The loop over policy actions will always exit when it sees
the flow end action, so the next check is redundant.
Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color")
Cc: haif...@nvidia.com
Signed-off-by: Stephen Hemminger
Acked
21/11/2024 20:39, Andre Muezerie:
> On Tue, Nov 19, 2024 at 09:32:07AM +0100, Morten Brørup wrote:
> > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> > > Sent: Tuesday, 19 November 2024 05.35
> > >
> > > From: Tyler Retzlaff
> > >
> > > MSVC struct packing is not compatible with
83 matches
Mail list logo
