Re: [PATCH v12 18/21] build: enable vla warnings on Windows built code

[fengchengwen]

Acked-by: Chengwen Feng <fengcheng...@huawei.com>

On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Tyler Retzlaff <roret...@linux.microsoft.com>
> 
> MSVC does not support optional C11 VLAs. When building for Windows
> enable -Wvla so that mingw and clang also fail if a VLA is used.
> 
> Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com>
> Acked-by: Bruce Richardson <bruce.richard...@intel.com>
> ---
>  config/meson.build | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/config/meson.build b/config/meson.build
> index 6aaad6d8a4..ebca19b4e5 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -342,6 +342,10 @@ if cc.get_id() == 'intel'
>          warning_flags += '-diag-disable=@0@'.format(i)
>      endforeach
>  endif
> +# no VLAs in code built on Windows
> +if is_windows
> +    warning_flags += '-Wvla'
> +endif
>  foreach arg: warning_flags
>      if cc.has_argument(arg)
>          add_project_arguments(arg, language: 'c')