On Wed, Nov 20, 2024 at 09:12:15AM -0800, Stephen Hemminger wrote: > On Tue, 19 Nov 2024 19:13:01 -0800 > Andre Muezerie <andre...@linux.microsoft.com> wrote: > > > From: Tyler Retzlaff <roret...@linux.microsoft.com> > > > > Include alloca.h for Linux and malloc.h for Windows to get declaration > > of alloca(). > > > > Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com> > > --- > > lib/eal/linux/include/rte_os.h | 1 + > > lib/eal/windows/include/rte_os.h | 1 + > > 2 files changed, 2 insertions(+) > > What about FreeBSD? > https://man.freebsd.org/cgi/man.cgi?alloca > > Looks like to be pedantic stdlib.h should be included there.
Indeed. I'll include it. Is FreeBSD tested when a patch is submitted? I did not see it in the list of OSes/distros tested. I'm asking because it's always possible to break something inadvertently if not tested. Regards, Andre