Re: [PATCH v4 1/9] app/test: do not duplicate loop variable

[fengchengwen]

Acked-by: Chengwen Feng <fengcheng...@huawei.com>

On 2024/11/22 2:23, Stephen Hemminger wrote:
> Do not use same variable for outer and inner loop in bonding test.
> Since the loop is just freeing the resulting burst use bulk free.
> 
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
> 
> Fixes: 92073ef961ee ("bond: unit tests")
> Cc: declan.dohe...@intel.com
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> Acked-by: Bruce Richardson <bruce.richard...@intel.com>
> ---
>  app/test/test_link_bonding.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
> index 4d54706c21..805613d7dd 100644
> --- a/app/test/test_link_bonding.c
> +++ b/app/test/test_link_bonding.c
> @@ -2288,12 +2288,7 @@ test_activebackup_rx_burst(void)
>               }
>  
>               /* free mbufs */
> -             for (i = 0; i < MAX_PKT_BURST; i++) {
> -                     if (rx_pkt_burst[i] != NULL) {
> -                             rte_pktmbuf_free(rx_pkt_burst[i]);
> -                             rx_pkt_burst[i] = NULL;
> -                     }
> -             }
> +             rte_pktmbuf_free_bulk(rx_pkt_burst, burst_size);
>  
>               /* reset bonding device stats */
>               rte_eth_stats_reset(test_params->bonding_port_id);